Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-22 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/#review222105
---


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 21, 2020, 10:34 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72938/
> ---
> 
> (Updated Oct. 21, 2020, 10:34 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3984
> https://issues.apache.org/jira/browse/ATLAS-3984
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add UI Date Timezone and UI Date Format in Session api.
> 
> Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
> values from property file.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 3a6139f 
> 
> 
> Diff: https://reviews.apache.org/r/72938/diff/4/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-21 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

(Updated Oct. 22, 2020, 5:34 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/4/

Changes: https://reviews.apache.org/r/72938/diff/3-4/


Testing
---

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console


Thanks,

Mandar Ambawane



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-21 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/#review222093
---


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 136 (patched)


update property "atlas.ui.date.timezone" => 
"atlas.ui.date.timezone.format.enabled"

UI_DATE_TIMEZONE => UI_DATE_TIMEZONE_FORMAT_ENABLED


- Sarath Subramanian


On Oct. 21, 2020, 6:19 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72938/
> ---
> 
> (Updated Oct. 21, 2020, 6:19 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3984
> https://issues.apache.org/jira/browse/ATLAS-3984
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add UI Date Timezone and UI Date Format in Session api.
> 
> Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
> values from property file.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 3a6139f 
> 
> 
> Diff: https://reviews.apache.org/r/72938/diff/3/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-21 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

(Updated Oct. 21, 2020, 1:19 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/3/

Changes: https://reviews.apache.org/r/72938/diff/2-3/


Testing
---

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console


Thanks,

Mandar Ambawane



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-20 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/#review222086
---


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 200 (patched)


why is 'uiDateTimezone' a boolean flag - do we expect a timezone value? If 
you are expecting a boolean value, consider giving a meaningful property name.


- Sarath Subramanian


On Oct. 8, 2020, 11:21 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72938/
> ---
> 
> (Updated Oct. 8, 2020, 11:21 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3984
> https://issues.apache.org/jira/browse/ATLAS-3984
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add UI Date Timezone and UI Date Format in Session api.
> 
> Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
> values from property file.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 3a6139f 
> 
> 
> Diff: https://reviews.apache.org/r/72938/diff/2/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

(Updated Oct. 9, 2020, 6:21 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

UI date format changed from "MM/dd/ hh:mm:ss tt" to "MM/DD/ hh:mm:ss A"


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/2/

Changes: https://reviews.apache.org/r/72938/diff/1-2/


Testing
---


Thanks,

Mandar Ambawane



Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-07 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/1/


Testing
---


Thanks,

Mandar Ambawane