Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-11-10 Thread Nikhil Bonte 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222187
---


Ship it!




Ship It!

- Nikhil Bonte


On Nov. 10, 2020, 12:21 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 10, 2020, 12:21 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/179/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-11-09 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222186
---


Ship it!




Ship It!

- Sarath Subramanian


On Nov. 9, 2020, 4:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 9, 2020, 4:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/179/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-11-09 Thread Ashutosh Mestry via Review Board 


> On Nov. 10, 2020, 6:02 a.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
> > Line 108 (original), 108 (patched)
> > 
> >
> > why ignore relationships flag is turned ON?

This is a use case where all the imported entities should have the 
_replicatedFrom_ attribute set. This 
https://issues.apache.org/jira/browse/ATLAS-3109 inadvertently removed that 
behavior causing only the top-level entities to have that attribite.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222183
---


On Nov. 10, 2020, 12:21 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 10, 2020, 12:21 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-11-09 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222183
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
Line 108 (original), 108 (patched)


why ignore relationships flag is turned ON?


- Sarath Subramanian


On Nov. 9, 2020, 4:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 9, 2020, 4:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-11-09 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/
---

(Updated Nov. 10, 2020, 12:21 a.m.)


Review request for atlas, Nikhil Bonte and Sarath Subramanian.


Changes
---

Updates include: 
- Addressed review comments.
- Fixed bug introduced by https://issues.apache.org/jira/browse/ATLAS-3109


Bugs: ATLAS-4006 and ATLAS-4007
https://issues.apache.org/jira/browse/ATLAS-4006
https://issues.apache.org/jira/browse/ATLAS-4007


Repository: atlas


Description
---

**Background**
Existing implementation does not support export and import of _Business 
Metadata_ (BM) attributes. 

**Implementation**
- Export: Updated existing flow to include detecting BM attributes and adding 
the types to the exported payload.
- Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
and update.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
 542106f36 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
0491a853a 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
 664af9166 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
 b65807742 
  
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
 0d78dbe57 
  
repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
 f9b7cd11f 
  repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72991/diff/3/

Changes: https://reviews.apache.org/r/72991/diff/2-3/


Testing
---

**Unit tests**
New tests added.

**Functional testing**
End-to-end tests. (Export-import-export).

**Pre-commit Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/


File Attachments


Stocks with BM
  
https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip


Thanks,

Ashutosh Mestry

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-11-05 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222170
---




repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
Lines 185 (patched)


Consider replacing #184 - #186 with:
  for (String bmTypeName : entityType.getBusinessAttributes().keySet()) {
AtlasBusinessMetadataType bmType = 
typeRegistry.getBusinessMetadataTypeByName(bmTypeName);

addBusinessMetadataType(bmType, context);
  }

This will ensure that attribute-types of the business-metadata type will be 
processed as well (#179), like enum type attribute.


- Madhan Neethiraj


On Nov. 4, 2020, 2:35 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 4, 2020, 2:35 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-11-03 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/
---

(Updated Nov. 4, 2020, 2:35 a.m.)


Review request for atlas, Nikhil Bonte and Sarath Subramanian.


Changes
---

Updates include: Addressed review comments.


Bugs: ATLAS-4006 and ATLAS-4007
https://issues.apache.org/jira/browse/ATLAS-4006
https://issues.apache.org/jira/browse/ATLAS-4007


Repository: atlas


Description
---

**Background**
Existing implementation does not support export and import of _Business 
Metadata_ (BM) attributes. 

**Implementation**
- Export: Updated existing flow to include detecting BM attributes and adding 
the types to the exported payload.
- Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
and update.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
0491a853a 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
 664af9166 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
 b65807742 
  
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
 0d78dbe57 
  
repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
 f9b7cd11f 
  repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72991/diff/2/

Changes: https://reviews.apache.org/r/72991/diff/1-2/


Testing
---

**Unit tests**
New tests added.

**Functional testing**
End-to-end tests. (Export-import-export).

**Pre-commit Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/


File Attachments (updated)


Stocks with BM
  
https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip


Thanks,

Ashutosh Mestry

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-28 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222137
---




repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
Line 56 (original), 58 (patched)


Shouldn't there be a call to update businessMetadataDefs(), from here - to 
handle changes to business-metadata defs?



repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
Lines 71 (patched)


When an entity-type has updates to attributes and business-metadata, 
typeDefStore will be updated twice for this type - #66 and #71. Consider the 
following:

  boolean entityDefUpdated = false;
  
  if (existing != null) {
entityDefUpdated = addAttributes(existing, def);
entityDefUpdated = addBusinessMetadata(existing, def) || 
entityDefUpdated;
  }
  
  if (entityDefUpdated) {
typeDefStore.updateEntityDefByName(existing.getName(), existing);

result.incrementMeticsCounter("typedef:entitydef:update");
  }



repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
Lines 72 (patched)


"typedef:businessmetadata:update": update is on entity-def and not the 
business-metadata-def, right?



repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
Lines 139 (patched)


AtlasEntityDef.businessAttributeDefs is a read-only attribute i.e. it is 
derived from details in business-metadata-def. Hence there it is not necessary 
to look for differenence in this field. Instead, process delta in 
business-metadata-defs.


- Madhan Neethiraj


On Oct. 27, 2020, 8:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Oct. 27, 2020, 8:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-28 Thread Nikhil Bonte 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222136
---


Ship it!




Ship It!

- Nikhil Bonte


On Oct. 27, 2020, 8:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Oct. 27, 2020, 8:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-28 Thread Nikhil Bonte 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222135
---




repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
Lines 124 (patched)


suggestion: rename: 
addBusinessMetadataType -> addBusinessMetadataTypes


- Nikhil Bonte


On Oct. 27, 2020, 8:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Oct. 27, 2020, 8:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-27 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222134
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 27, 2020, 8:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Oct. 27, 2020, 8:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-27 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/
---

Review request for atlas, Nikhil Bonte and Sarath Subramanian.


Summary (updated)
-

Export/Import: Add Support for BusinessMetadata Attributes


Bugs: ATLAS-4006 and ATLAS-4007
https://issues.apache.org/jira/browse/ATLAS-4006
https://issues.apache.org/jira/browse/ATLAS-4007


Repository: atlas


Description (updated)
---

**Background**
Existing implementation does not support export and import of _Business 
Metadata_ (BM) attributes. 

**Implementation**
- Export: Updated existing flow to include detecting BM attributes and adding 
the types to the exported payload.
- Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
and update.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
0491a853a 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
 664af9166 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
 b65807742 
  
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
 0d78dbe57 
  
repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
 f9b7cd11f 


Diff: https://reviews.apache.org/r/72991/diff/1/


Testing (updated)
---

**Unit tests**
New tests added.

**Functional testing**
End-to-end tests. (Export-import-export).

**Pre-commit Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/153/console


Thanks,

Ashutosh Mestry