Re: Review Request 73797: ATLAS - 4527 : Upgrade underscore.js to 1.12.1+

2022-01-12 Thread Jayendra Parab

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73797/#review223954
---


Ship it!




Ship It!

- Jayendra Parab


On Jan. 12, 2022, 6:57 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73797/
> ---
> 
> (Updated Jan. 12, 2022, 6:57 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4527
> https://issues.apache.org/jira/browse/ATLAS-4527
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas is using underscore 1.8.3. This needs to be upgraded to 1.12.1+
> 
> 
> Diffs
> -
> 
>   dashboardv2/package-lock.json 61fd944c6 
>   dashboardv2/package.json 2cc1d4b08 
>   dashboardv2/public/js/utils/Globals.js 8fe8ebc4c 
>   dashboardv3/package-lock.json 2b00b159e 
>   dashboardv3/package.json 49fd9dfac 
>   dashboardv3/public/js/utils/Globals.js df17a683b 
> 
> 
> Diff: https://reviews.apache.org/r/73797/diff/1/
> 
> 
> Testing
> ---
> 
> Functional testing has been done for all UI pages.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>



Re: Review Request 73797: ATLAS - 4527 : Upgrade underscore.js to 1.12.1+

2022-01-12 Thread Prasad Pawar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73797/#review223953
---


Ship it!




Ship It!

- Prasad Pawar


On Jan. 12, 2022, 6:57 a.m., Farhan Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73797/
> ---
> 
> (Updated Jan. 12, 2022, 6:57 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4527
> https://issues.apache.org/jira/browse/ATLAS-4527
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Atlas is using underscore 1.8.3. This needs to be upgraded to 1.12.1+
> 
> 
> Diffs
> -
> 
>   dashboardv2/package-lock.json 61fd944c6 
>   dashboardv2/package.json 2cc1d4b08 
>   dashboardv2/public/js/utils/Globals.js 8fe8ebc4c 
>   dashboardv3/package-lock.json 2b00b159e 
>   dashboardv3/package.json 49fd9dfac 
>   dashboardv3/public/js/utils/Globals.js df17a683b 
> 
> 
> Diff: https://reviews.apache.org/r/73797/diff/1/
> 
> 
> Testing
> ---
> 
> Functional testing has been done for all UI pages.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>



Review Request 73797: ATLAS - 4527 : Upgrade underscore.js to 1.12.1+

2022-01-11 Thread Farhan Khan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73797/
---

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4527
https://issues.apache.org/jira/browse/ATLAS-4527


Repository: atlas


Description
---

Atlas is using underscore 1.8.3. This needs to be upgraded to 1.12.1+


Diffs
-

  dashboardv2/package-lock.json 61fd944c6 
  dashboardv2/package.json 2cc1d4b08 
  dashboardv2/public/js/utils/Globals.js 8fe8ebc4c 
  dashboardv3/package-lock.json 2b00b159e 
  dashboardv3/package.json 49fd9dfac 
  dashboardv3/public/js/utils/Globals.js df17a683b 


Diff: https://reviews.apache.org/r/73797/diff/1/


Testing
---

Functional testing has been done for all UI pages.


Thanks,

Farhan Khan