Re: Review Request 58333: TypesREST to support creation in an update call

--- mvn clean package executes successfully Thanks, Apoorv Naik

Review Request 58333: TypesREST to support creation in an update call

/atlas/web/rest/TypesREST.java 5d846cf317ae46fa88ef7877baad129638e38e03 Diff: https://reviews.apache.org/r/58333/diff/1/ Testing --- mvn clean package executes successfully Thanks, Apoorv Naik

Re: Review Request 58234: ATLAS-1697 : import-hive.sh script logs debug/info logs on console instead of import-hive.log log file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58234/#review171216 --- Ship it! Ship It! - Apoorv Naik On April 6, 2017, 2:21 p.m

Re: Review Request 58159: Unit test: Import & Export APIs

/#comment243817> Use Assert.fail("") repository/src/test/java/org/apache/atlas/repository/impexp/ZipSourceTest.java Lines 73 (patched) <https://reviews.apache.org/r/58159/#comment243818> Rename to verifyGuidRemovalOnImportComplete - Apoorv Na

Re: Review Request 58163: [ATLAS-1710] : Implement entity-lookup API for entity create/update UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58163/#review170977 --- Ship it! Ship It! - Apoorv Naik On April 3, 2017, 10:26 p.m

Re: Review Request 56724: ATLAS-1390: Add IBM Graph Support

che/atlas/ibmgraph/IBMGraphElement.java Lines 246 (patched) <https://reviews.apache.org/r/56724/#comment243651> Same here. graphdb/ibm-graph/src/main/java/org/apache/atlas/ibmgraph/IBMGraphElement.java Lines 250 (patched) <https://reviews.apache.org/r/56724/#comment243652> And here. - Apoo

[jira] [Commented] (ATLAS-1700) Add constraints to JAVA API

[ https://issues.apache.org/jira/browse/ATLAS-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953024#comment-15953024 ] Apoorv Naik commented on ATLAS-1700: Hey David, can you add an elaborate description here ? >

[jira] [Created] (ATLAS-1706) Investigate HATEOAS for Atlas

Apoorv Naik created ATLAS-1706: -- Summary: Investigate HATEOAS for Atlas Key: ATLAS-1706 URL: https://issues.apache.org/jira/browse/ATLAS-1706 Project: Atlas Issue Type: Wish

Re: Review Request 57786: ATLAS-1673: Type deletion bug

/AtlasStructDefStoreV1.java 2bc36da6 Diff: https://reviews.apache.org/r/57786/diff/4/ Changes: https://reviews.apache.org/r/57786/diff/3-4/ Testing (updated) --- mvn clean package and mvn clean install executes successfully now. Thanks, Apoorv Naik

Re: Review Request 57786: ATLAS-1673: Type deletion bug

/ Testing (updated) --- Testing show NPE issues in resolveReferencePhase2. Need to investigate more. Thanks, Apoorv Naik

Re: Review Request 57786: ATLAS-1673: Type deletion bug

/AtlasStructDefStoreV1.java 2bc36da6 Diff: https://reviews.apache.org/r/57786/diff/3/ Changes: https://reviews.apache.org/r/57786/diff/2-3/ Testing (updated) --- mvn clean install in progress Thanks, Apoorv Naik

Re: Review Request 57786: ATLAS-1673: Type deletion bug

install executes successfully with same failures as seen on builds.apache.org Thanks, Apoorv Naik

[jira] [Resolved] (ATLAS-1681) Atlas went into inconsistent state after creating a type with faulty definition

[ https://issues.apache.org/jira/browse/ATLAS-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1681. Resolution: Fixed > Atlas went into inconsistent state after creating a type with fau

[jira] [Commented] (ATLAS-1681) Atlas went into inconsistent state after creating a type with faulty definition

[ https://issues.apache.org/jira/browse/ATLAS-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942034#comment-15942034 ] Apoorv Naik commented on ATLAS-1681: Committed (SHAs) master -> 41839141 0.8-incubating -> 82

Re: Review Request 57919: ATLAS-1681: Typedef validations while create/update

executes successfully mvn clean install also executes successfully with failure consistent with the apache jenins build. Thanks, Apoorv Naik

Re: Review Request 57919: ATLAS-1681: Typedef validations while create/update

: https://reviews.apache.org/r/57919/diff/1-2/ Testing --- testing in progress. Thanks, Apoorv Naik

Review Request 57919: ATLAS-1681: Typedef validations while create/update

/graph/v1/AtlasEnumDefStoreV1.java 88325076 repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java 6803f1a3 Diff: https://reviews.apache.org/r/57919/diff/1/ Testing --- testing in progress. Thanks, Apoorv Naik

[jira] [Assigned] (ATLAS-1681) Atlas went into inconsistent state after creating a type with faulty definition

[ https://issues.apache.org/jira/browse/ATLAS-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1681: -- Assignee: Apoorv Naik > Atlas went into inconsistent state after creating a type with fau

[jira] [Resolved] (ATLAS-1674) Values are not getting set while updating node attribute of storm_topology entity.

[ https://issues.apache.org/jira/browse/ATLAS-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1674. Resolution: Not A Problem > Values are not getting set while updating node attrib

[jira] [Commented] (ATLAS-1198) Move from Guice + Spring to only Spring

[ https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935810#comment-15935810 ] Apoorv Naik commented on ATLAS-1198: WIP. Have an interim patch ready with few IT failures to look

Re: Review Request 57655: Javadocs and comment changes for Enunciate/Swagger

--------- On March 15, 2017, 5:36 p.m., Apoorv Naik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57655/ >

[jira] [Assigned] (ATLAS-1674) Values are not getting set while updating node attribute of storm_topology entity.

[ https://issues.apache.org/jira/browse/ATLAS-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reassigned ATLAS-1674: -- Assignee: Apoorv Naik (was: Madhan Neethiraj) > Values are not getting set while updat

[jira] [Created] (ATLAS-1679) Basic search should surface active entities before deleted ones

Apoorv Naik created ATLAS-1679: -- Summary: Basic search should surface active entities before deleted ones Key: ATLAS-1679 URL: https://issues.apache.org/jira/browse/ATLAS-1679 Project: Atlas

[jira] [Updated] (ATLAS-1673) Type deletion not working as expected

[ https://issues.apache.org/jira/browse/ATLAS-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1673: --- Attachment: ATLAS-1673.patch > Type deletion not working as expec

Review Request 57786: ATLAS-1673: Type deletion bug

Diff: https://reviews.apache.org/r/57786/diff/1/ Testing --- mvn clean install executes successfully with same failures as seen on builds.apache.org Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1673) Type deletion not working as expected

Apoorv Naik created ATLAS-1673: -- Summary: Type deletion not working as expected Key: ATLAS-1673 URL: https://issues.apache.org/jira/browse/ATLAS-1673 Project: Atlas Issue Type: Bug Affects

Re: Review Request 57649: Export API: ZIP File Size Optimization

-UTs #1](http://osboxes:8080/job/atlas-UTs/1/). - Apoorv Naik On March 17, 2017, 5:09 a.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 57649: Export API: ZIP File Size Optimization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57649/#review169383 --- Jenkins is going to check this review request... - Apoorv Naik

Re: Review Request 57735: [ATLAS-1664] : Able to add already added tag to an entity through REST API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57735/#review169338 --- Ship it! Ship It! - Apoorv Naik On March 17, 2017, 8:58 p.m

Re: Review Request 57720: ATLAS-1630: basic search performance improvement (#3)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57720/#review169293 --- Ship it! Ship It! - Apoorv Naik On March 17, 2017, 7:20 a.m

Re: New PPMC member to Apache Atlas: Madhan Neethiraj

Congratulations Madhan!!! Sent from Nine From: Nixon Rodrigues Sent: Mar 16, 2017 10:07 PM To: dev@atlas.incubator.apache.org Subject: Re: New PPMC member to Apache Atlas: Madhan Neethiraj

Re: Review Request 57434: ATLAS-1659: Full text changes when tags are added/removed

://reviews.apache.org/r/57434/diff/1-2/ Testing --- mvn clean install works Was able to see the updated fullText field using gremlin after performing add/delete tags from UI Thanks, Apoorv Naik

Review Request 57655: Javadocs and comment changes for Enunciate/Swagger

-DskipTests -DskipSite=false -DskipEnunciate=false generates required docs correctly mvn clean install also runs fine Thanks, Apoorv Naik

[jira] [Resolved] (ATLAS-328) UI: Swagger API Documentation support

[ https://issues.apache.org/jira/browse/ATLAS-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-328. --- Resolution: Duplicate Fix Version/s: 0.8-incubating trunk Duplicate of ATLAS

[jira] [Commented] (ATLAS-1370) Generate API document with enunciate/swagger

[ https://issues.apache.org/jira/browse/ATLAS-1370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926434#comment-15926434 ] Apoorv Naik commented on ATLAS-1370: [~davidrad] Hey David, you can actually generate the docs using

Re: New committer to Apache Atlas: Apoorv Naik

MC) for Apache Atlas >has invited Apoorv Naik to become a committer and we are pleased >to announce that he has accepted. > >Congratulations, Apoorv! > >thanks, >Hemanth >

[jira] [Reopened] (ATLAS-1659) FullText V2 mapping after adding/removing traits

[ https://issues.apache.org/jira/browse/ATLAS-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik reopened ATLAS-1659: Looks like the commit didn't go in yet. > FullText V2 mapping after adding/removing tra

[jira] [Updated] (ATLAS-1659) FullText V2 mapping after adding/removing traits

[ https://issues.apache.org/jira/browse/ATLAS-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1659: --- Attachment: ATLAS-1659.patch > FullText V2 mapping after adding/removing tra

Review Request 57434: ATLAS-1659: Full text changes when tags are added/removed

the updated fullText field using gremlin after performing add/delete tags from UI Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1659) FullText V2 mapping after adding/removing traits

Apoorv Naik created ATLAS-1659: -- Summary: FullText V2 mapping after adding/removing traits Key: ATLAS-1659 URL: https://issues.apache.org/jira/browse/ATLAS-1659 Project: Atlas Issue Type: Bug

Re: [VOTE] Release Apache Atlas 0.8 (incubating) - release candidate 1 (dev group vote)

+1 (non-binding) for the release 1. Tag exists 2. Build goes through fine 3. No rat failures 4. Was able to run quick start and use UI to test out basic operations like tag association etc. On 3/8/17, 10:24 AM, "Ashutosh Mestry" wrote: > +1 (non-binding vote) for

[jira] [Updated] (ATLAS-1655) Metrics query enhancement

[ https://issues.apache.org/jira/browse/ATLAS-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1655: --- Attachment: ATLAS-1655.patch > Metrics query enhancem

Review Request 57398: ATLAS-1655: Metrics query tuneup

://reviews.apache.org/r/57398/diff/1/ Testing --- GET on /api/atlas/admin/metrics is faster now Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1655) Metrics query enhancement

Apoorv Naik created ATLAS-1655: -- Summary: Metrics query enhancement Key: ATLAS-1655 URL: https://issues.apache.org/jira/browse/ATLAS-1655 Project: Atlas Issue Type: Improvement Affects

[jira] [Updated] (ATLAS-1198) Move from Guice + Spring to only Spring

[ https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1198: --- Affects Version/s: (was: 0.8-incubating) (was: 0.7-incubating

Review Request 57359: ATLAS-1649: Config property fix for DeleteHandlerV1

/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java ee37e57c Diff: https://reviews.apache.org/r/57359/diff/1/ Testing --- Atlas starts up fine with the custom delete handler property for SoftDeleteHandler and HardDeleteHandler Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1649) Startup failure because of Config property overload

Apoorv Naik created ATLAS-1649: -- Summary: Startup failure because of Config property overload Key: ATLAS-1649 URL: https://issues.apache.org/jira/browse/ATLAS-1649 Project: Atlas Issue Type

Review Request 57327: ATLAS-1637: Deprecate V1 APIs and classes

/MetadataDiscoveryResource.java 33379742 webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java db282d87 Diff: https://reviews.apache.org/r/57327/diff/1/ Testing --- Not needed Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1637) Deprecate V1 APIs

Apoorv Naik created ATLAS-1637: -- Summary: Deprecate V1 APIs Key: ATLAS-1637 URL: https://issues.apache.org/jira/browse/ATLAS-1637 Project: Atlas Issue Type: Improvement Reporter

[jira] [Commented] (ATLAS-1621) Fix webapp integration tests failures

[ https://issues.apache.org/jira/browse/ATLAS-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896089#comment-15896089 ] Apoorv Naik commented on ATLAS-1621: +1 on the second patch > Fix webapp integration tests failu

Re: Review Request 57318: ATALS-1634: added perf trace logs to REST APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57318/#review167937 --- Ship it! Ship It! - Apoorv Naik On March 4, 2017, 11:49 p.m

Re: Review Request 57277: ATLAS-1627: fix for missed update to full-text index attribute on entity-update

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57277/#review167843 --- Ship it! Ship It! - Apoorv Naik On March 3, 2017, 10:47 a.m

Re: Review Request 57273: ATLAS-1626: updated Atlas type-load to be resilient to incorrect constraints in the store (from earlier version env)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57273/#review167842 --- Ship it! Ship It! - Apoorv Naik On March 3, 2017, 10:26 a.m

[jira] [Resolved] (ATLAS-1606) Gremlin changes for compatibility with TP3

[ https://issues.apache.org/jira/browse/ATLAS-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1606. Resolution: Fixed > Gremlin changes for compatibility with

Re: Review Request 57048: ATLAS-1622: Full text mapper V2

/repository/store/graph/v1/AtlasEntityChangeNotifier.java feada348 server-api/src/main/java/org/apache/atlas/RequestContext.java bb11d671 Diff: https://reviews.apache.org/r/57048/diff/1/ Testing --- mvn clean package was successfully executed. Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1622) FullTexMapper enhancement

Apoorv Naik created ATLAS-1622: -- Summary: FullTexMapper enhancement Key: ATLAS-1622 URL: https://issues.apache.org/jira/browse/ATLAS-1622 Project: Atlas Issue Type: Improvement Affects

[jira] [Created] (ATLAS-1624) Search speedup when using FullText

Apoorv Naik created ATLAS-1624: -- Summary: Search speedup when using FullText Key: ATLAS-1624 URL: https://issues.apache.org/jira/browse/ATLAS-1624 Project: Atlas Issue Type: Sub-task

[jira] [Created] (ATLAS-1623) V2 FullTextMapper

Apoorv Naik created ATLAS-1623: -- Summary: V2 FullTextMapper Key: ATLAS-1623 URL: https://issues.apache.org/jira/browse/ATLAS-1623 Project: Atlas Issue Type: Sub-task Affects Versions: 0.8

[jira] [Resolved] (ATLAS-1563) Entity change listener hookup in entity store

[ https://issues.apache.org/jira/browse/ATLAS-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1563. Resolution: Fixed > Entity change listener hookup in entity st

[jira] [Resolved] (ATLAS-1617) Improve readability of Error codes

[ https://issues.apache.org/jira/browse/ATLAS-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1617. Resolution: Fixed > Improve readability of Error co

[jira] [Resolved] (ATLAS-1359) Move new client classes to atlas-intg

[ https://issues.apache.org/jira/browse/ATLAS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1359. Resolution: Won't Fix > Move new client classes to atlas-i

[jira] [Resolved] (ATLAS-1304) Code cleanup and simplification

[ https://issues.apache.org/jira/browse/ATLAS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1304. Resolution: Fixed > Code cleanup and simplificat

Review Request 57048: Full text mapper V2

clean package was successfully executed. Thanks, Apoorv Naik

Re: Review Request 57241: [ATLAS-1621] : Fix webapp integration tests failures

not rely on the data provider. webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java Lines 659 (patched) <https://reviews.apache.org/r/57241/#comment239598> Is this the correct fix for partial update scenario ? Looks like a full-update is being called here. Pleas

[jira] [Updated] (ATLAS-1616) Single V2 client instead of resource level clients

[ https://issues.apache.org/jira/browse/ATLAS-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1616: --- Request participants: (was: ) Issue Type: Improvement (was: Bug) > Single V2 cli

[jira] [Resolved] (ATLAS-1616) Single V2 client instead of resource level clients

[ https://issues.apache.org/jira/browse/ATLAS-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik resolved ATLAS-1616. Resolution: Fixed > Single V2 client instead of resource level clie

Re: Review Request 57216: ATLAS-1617: Improve error code readability

163 (original) <https://reviews.apache.org/r/57216/#comment239463> Harmless change, accidentally got checked in. - Apoorv Naik On March 1, 2017, 8:55 p.m., Apoorv Naik wrote: > > --- > This is an automatically g

Review Request 57216: ATLAS-1617: Improve error code readability

s Diffs - client/src/main/java/org/apache/atlas/AtlasBaseClient.java 38bf2338 intg/src/main/java/org/apache/atlas/AtlasErrorCode.java edcef4b4 Diff: https://reviews.apache.org/r/57216/diff/1/ Testing --- Not needed Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1617) Improve readability of Error codes

[ https://issues.apache.org/jira/browse/ATLAS-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1617: --- Request participants: (was: ) Description: Currently the Error code format

[jira] [Created] (ATLAS-1617) Improve readability of Error codes

Apoorv Naik created ATLAS-1617: -- Summary: Improve readability of Error codes Key: ATLAS-1617 URL: https://issues.apache.org/jira/browse/ATLAS-1617 Project: Atlas Issue Type: Improvement

Re: Review Request 57212: ATLAS-1616: Atlas V2 client consolidation

successfully with some constant failures as seen on Jenkins Thanks, Apoorv Naik

Review Request 57212: ATLAS-1616: Atlas V2 client consolidation

/resources/EntityV2JerseyResourceIT.java ae5cd462 webapp/src/test/java/org/apache/atlas/web/resources/TypedefsJerseyResourceIT.java 243d0999 Diff: https://reviews.apache.org/r/57212/diff/1/ Testing --- mvn clean install in progress (will update shortly) Thanks, Apoorv Naik

Re: Review Request 57210: ATLAS-1587: updated AtlasEntityHeader retrieval to read name/description/owner attributes defined in the type (instead of Asset)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57210/#review167412 --- Ship it! Ship It! - Apoorv Naik On March 1, 2017, 6:09 p.m

[jira] [Created] (ATLAS-1616) Single V2 client instead of resource level clients

Apoorv Naik created ATLAS-1616: -- Summary: Single V2 client instead of resource level clients Key: ATLAS-1616 URL: https://issues.apache.org/jira/browse/ATLAS-1616 Project: Atlas Issue Type: Bug

Review Request 57173: ATLAS-1606: Atlas query provider instead of hardcoded queries

://reviews.apache.org/r/57173/diff/ Testing --- mvn clean package executes successfully. Thanks, Apoorv Naik

[jira] [Created] (ATLAS-1606) Gremlin changes for compatibility with TP3

Apoorv Naik created ATLAS-1606: -- Summary: Gremlin changes for compatibility with TP3 Key: ATLAS-1606 URL: https://issues.apache.org/jira/browse/ATLAS-1606 Project: Atlas Issue Type: Bug

Re: Review Request 57119: Fix QuickStart IT failures and coverity scan issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57119/#review166993 --- Ship it! Ship It! - Apoorv Naik On Feb. 28, 2017, 3:02 a.m

Re: Review Request 57103: Implementation for classification in V2 API

Shouldn't be consuming anything here, usually DELETEs don't accept any body. webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java (line 348) <https://reviews.apache.org/r/57103/#comment239091> "empty entity list" -> "empty

Re: Review Request 56953: ATLAS-1573: FullText mapper for EntityStore V2

entity. Text search from UI shows the entity in the result. Gremlin search using the entity GUID shows that the vertex has entityText property set. mvn clean package executes successfully. Thanks, Apoorv Naik

Review Request 56953: ATLAS-1573: FullText mapper for EntityStore V2

in the result. Gremlin search using the entity GUID shows that the vertex has entityText property set. mvn clean package executes successfully. Thanks, Apoorv Naik

Re: V2 REST Api documentation (first-cut)

Thank you Ernie and Keval for your review (forgot to mention in prior email) On 2/22/17, 11:10 AM, "Apoorv Naik" <an...@hortonworks.com> wrote: >Thanks for your detailed review David. > >1. I see that there’s some inconsistency in the Javadocs for EntityREST

Re: V2 REST Api documentation (first-cut)

t, David. > > > >From: Keval Bhatt <kevalbhat...@gmail.com> >To: dev@atlas.incubator.apache.org >Date: 20/02/2017 06:12 >Subject:Re: V2 REST Api documentation (first-cut) > > > >Hi Apoorv, > >API Doc is very simplified and UI is also loo

Re: Review Request 56917: ATLAS-1586: type search improvement by avoiding unnecessary instantiation of type objects

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56917/#review166324 --- Ship it! Ship It! - Apoorv Naik On Feb. 22, 2017, 6:33 a.m

Re: Review Request 56897: ATLAS-1577: audit event generated for an entity overwrites previous audit event for the entity

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56897/#review166214 --- Ship it! Ship It! - Apoorv Naik On Feb. 21, 2017, 7:35 p.m

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56818/#review166048 --- Ship it! Ship It! - Apoorv Naik On Feb. 19, 2017, 7:09 a.m

Review Request 56825: Taxonomy test failure fixes

/56825/diff/ Testing --- mvn clean install executes successfully with some regular IT failures Thanks, Apoorv Naik

[jira] [Updated] (ATLAS-1570) Fix for Taxonomy service test failures

[ https://issues.apache.org/jira/browse/ATLAS-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1570: --- Attachment: 0001-ATLAS-1570-Taxonomy-test-failure-fix.patch > Fix for Taxonomy service test failu

[jira] [Created] (ATLAS-1570) Fix for Taxonomy service test failures

Apoorv Naik created ATLAS-1570: -- Summary: Fix for Taxonomy service test failures Key: ATLAS-1570 URL: https://issues.apache.org/jira/browse/ATLAS-1570 Project: Atlas Issue Type: Bug Affects

V2 REST Api documentation (first-cut)

Hi Atlas community, The REST API docs (first-cut) for the new V2 endpoints and data models are now available at http://atlas.incubator.apache.org/api/v2/index.html. It’d be great if we can gather some feedback on the docs, the existing docs have been moved under Legacy API section now. Looking

Re: Review Request 56796: Hookup entity change listeners in the entity store

executes successfully. Thanks, Apoorv Naik

Re: Review Request 56796: Hookup entity change listeners in the entity store

/rest/EntityREST.java 2f7ba20c Diff: https://reviews.apache.org/r/56796/diff/ Testing (updated) --- Verified that Kafka topic receives the message and hbase table has an entry corresponding to the changes made to the entity. mvn clean install in progress Thanks, Apoorv Naik

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

tAttributeValue()); > > }}; > > > > AtlasVertex vertex = > > AtlasGraphUtilsV1.findByUniqueAttributes(entityType, uniqAttributes); > > String guid = vertex != null ? > > AtlasGraphUtilsV1.getIdFromVertex(vertex) :

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

teByUniqueAttribute method in the store, let's just use that for now. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56184/#review165905 -

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

pected:<1487308686000> but was:<1487279886000> HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService ``` Test failures due to recent naming restrictions, need to update IT code as well (out of scope) Thanks, Apoorv Naik

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56184/#review165885 ------- On Feb. 16, 2017, 11:43 p.m., Apoorv Naik wrote: > > --- > This is an automat

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

<1487279886000> HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService ``` Test failures due to recent naming restrictions, need to update IT code as well (out of scope) Thanks, Apoorv Naik

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

.testCreateTable:170->verifyTimestamps:189 expected:<1487308686000> but was:<1487279886000> HiveHookIT.testTraitsPreservedOnColumnRename:1255->createTrait:946 » AtlasService ``` Test failures due to recent naming restrictions, need to update IT code as well (out of scope) Thanks, Apoorv Naik

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

1255->createTrait:946 » AtlasService ``` Test failures due to recent naming restrictions, need to update IT code as well (out of scope) Thanks, Apoorv Naik

[jira] [Commented] (ATLAS-1499) Notification processing to use new instance API for create and full-update

[ https://issues.apache.org/jira/browse/ATLAS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870726#comment-15870726 ] Apoorv Naik commented on ATLAS-1499: {noformat} Tests run: 43, Failures: 3, Errors: 0, Skipped: 0

[jira] [Created] (ATLAS-1563) Entity change listener hookup in entity store

Apoorv Naik created ATLAS-1563: -- Summary: Entity change listener hookup in entity store Key: ATLAS-1563 URL: https://issues.apache.org/jira/browse/ATLAS-1563 Project: Atlas Issue Type: Bug

<    1   2   3   4   5   6   7   >