[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190449#comment-15190449
]
Hemanth Yamijala commented on ATLAS-474:
I verified this patch again after applying fix for
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186690#comment-15186690
]
ATLAS QA commented on ATLAS-474:
{color:red}-1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185388#comment-15185388
]
David Kantor commented on ATLAS-474:
[~yhemanth] Thanks very much for reviewing the latest changes. I
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184405#comment-15184405
]
Hemanth Yamijala commented on ATLAS-474:
I have reviewed the latest changes. Thanks for the effort
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15184158#comment-15184158
]
David Kantor commented on ATLAS-474:
[~yhemanth] I have addressed your comments and updated the review
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183107#comment-15183107
]
David Kantor commented on ATLAS-474:
[~yhemanth] Thanks very much for reviewing the changes. I will
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182687#comment-15182687
]
Hemanth Yamijala commented on ATLAS-474:
[~dkantor], the patch needs to be rebased given ATLAS-479
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179384#comment-15179384
]
Shwetha G S commented on ATLAS-474:
---
[~dkantor], [~yhemanth] will review
> Server does not start if the
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179368#comment-15179368
]
Shwetha G S commented on ATLAS-474:
---
Ah ok, I missed that in update. Thanks
> Server does not start if
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178797#comment-15178797
]
David Kantor commented on ATLAS-474:
[~shwethags] I have addressed your comment and uploaded the
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177910#comment-15177910
]
David Kantor commented on ATLAS-474:
[~shwethags] Agreed that super types should be a set in the type
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177463#comment-15177463
]
Shwetha G S commented on ATLAS-474:
---
It doesn't make sense for superTypes to be a list, it should be a
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174147#comment-15174147
]
ATLAS QA commented on ATLAS-474:
{color:red}-1 overall{color}. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173937#comment-15173937
]
Neeru Gupta commented on ATLAS-474:
---
+1 . Have reviewed the code and looks good to me.
> Server does not
[
https://issues.apache.org/jira/browse/ATLAS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168123#comment-15168123
]
David Kantor commented on ATLAS-474:
I have reproduced the issue in a test case and implemented a fix.
15 matches
Mail list logo