Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review151128 --- Ship it! Ship It! - Shwetha GS On Oct. 2, 2016, 5:55 a.m.,

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Oct. 2, 2016, 5:55 a.m.) Review request for atlas, Abhay Kulkarni and

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 30, 2016, 5:21 a.m., Shwetha GS wrote: > > Previously, the common module contained some common code required for atlas > > server. Since the new classes that are added are client side classes, can > > you move them to new module clientv2 so that we have clear dependencies for > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 30, 2016, 5:21 a.m., Shwetha GS wrote: > > Previously, the common module contained some common code required for atlas > > server. Since the new classes that are added are client side classes, can > > you move them to new module clientv2 so that we have clear dependencies for > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150984 --- Previously, the common module contained some common code required

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150982 --- Ship it! Ship It! - Suma Shivaprasad On Sept. 30, 2016,

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 30, 2016, 12:51 a.m., Suma Shivaprasad wrote: > > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, > > line 242 > > > > > > would prefer valuesMinCount and valuesMaxCount also to

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 30, 2016, 12:51 a.m., Suma Shivaprasad wrote: > > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, > > line 242 > > > > > > would prefer valuesMinCount and valuesMaxCount also to

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150973 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 30, 2016, 12:04 a.m.) Review request for atlas, Abhay Kulkarni

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 29, 2016, 9:12 p.m.) Review request for atlas, Abhay Kulkarni

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 8:41 p.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 31 > > > > > > I agree, such API could be useful. Once we have concrete usecases > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 6:55 p.m., Suma Shivaprasad wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 31 > > > > > > Current existing implementations of the Atlas entity CRUD apis had a

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 7:31 p.m., Suma Shivaprasad wrote: > > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, > > line 247 > > > > > > since we have split this, valuesMinCount and

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150913 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150910 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150905 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150904 --- common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150901 --- common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150900 --- common/src/main/java/org/apache/atlas/api/SearchFilter.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 4:48 a.m., Sarath Kumar Subramanian wrote: > > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, > > line 249 > > > > > > reverseAttributeName and isComposite attributes

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 5:06 a.m., Sarath Kumar Subramanian wrote: > > common/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java, > > line 243 > > > > > > In current design, Multiplicity attribute is

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 29, 2016, 6:11 p.m.) Review request for atlas, Abhay Kulkarni

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150858 --- common/src/main/java/org/apache/atlas/type/AtlasEnumType.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150812 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 2:38 a.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java, line 35 > > > > > > All type definitions, including AtlasEnumDef, have few common > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 3:46 a.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java, > > line 40 > > > > > > version would be part of the object and not the object-id.

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 29, 2016, 4:08 a.m.) Review request for atlas, Abhay Kulkarni

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150799 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 29, 2016, 2:38 a.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java, line 35 > > > > > > updateEntity() is for full-update of an entity. A new API would be > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150795 --- common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150786 --- common/src/main/java/org/apache/atlas/type/AtlasType.java (line

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150784 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150782 --- common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150780 --- common/src/main/java/org/apache/atlas/type/AtlasType.java (line

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150778 --- common/src/main/java/org/apache/atlas/api/PList.java (line 48)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150777 --- common/src/main/java/org/apache/atlas/api/AtlasApiEntities.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150775 --- common/src/main/java/org/apache/atlas/api/PList.java (line 45)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150774 --- common/src/main/java/org/apache/atlas/api/PList.java (line 49)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review150772 --- common/src/main/java/org/apache/atlas/api/AtlasApiTypes.java

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 28, 2016, 6:43 p.m.) Review request for atlas, Abhay Kulkarni

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 28, 2016, 7:20 a.m.) Review request for atlas. Changes

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 28, 2016, 2:17 a.m.) Review request for atlas. Changes

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 26, 2016, 9:21 a.m.) Review request for atlas. Changes

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 24, 2016, 6:45 p.m.) Review request for atlas. Changes

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 19, 2016, 11:13 p.m., Jeff Hagelberg wrote: > > common/src/main/java/org/apache/atlas/model/AtlasAttributeDef.java, line 61 > > > > > > Why is this needed? It seems like if 'valuesMaxCount' > 1, it is >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 20, 2016, 8:06 a.m.) Review request for atlas. Changes

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

> On Sept. 19, 2016, 11:13 p.m., Jeff Hagelberg wrote: > > common/src/main/java/org/apache/atlas/model/AtlasAttributeDef.java, line 58 > > > > > > This seems redundant. Isn't it automatically optional if > >

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review149121 ---

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 19, 2016, 6:51 p.m.) Review request for atlas. Changes

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review148935 --- common/pom.xml (line 38)

Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/#review149064 --- Some thoughts on this change. I notice AltasEntities is a new