Re: Review Request 39157: Configure Consumer Groups for Notifications

2015-10-13 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39157/#review102184 --- Ship it! Ship It! - Suma Shivaprasad On Oct. 9, 2015, 1:40

Re: Review Request 39157: Configure Consumer Groups for Notifications

2015-10-09 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39157/#review102064 ---

Re: Review Request 39157: Configure Consumer Groups for Notifications

2015-10-09 Thread Suma Shivaprasad
> On Oct. 9, 2015, 4 p.m., Suma Shivaprasad wrote: > > notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java, > > line 226 > > > > > > consumerConnector need to be shutdown This seems to be

Re: Review Request 39157: Configure Consumer Groups for Notifications

2015-10-09 Thread Tom Beerbower
> On Oct. 9, 2015, 4:23 p.m., Suma Shivaprasad wrote: > > Where is consumer group for entity notifications from ATLAS taken care of? Thanks for the review! For entity notification, some other application (i.e. Ranger) is the consumer. The usage would be something like this ... //