Re: Review Request 47135: Install Setup: SOLR

2016-05-13 Thread Tom Beerbower
> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 102 > > > > > > if this config is changed by a user through Ambari, we need to handle > > the case where we need to supp

Re: Review Request 47135: Install Setup: SOLR

2016-05-12 Thread Suma Shivaprasad
> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 102 > > > > > > if this config is changed by a user through Ambari, we need to handle > > the case where we need to supp

Re: Review Request 47135: Install Setup: SOLR

2016-05-12 Thread Suma Shivaprasad
> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 102 > > > > > > if this config is changed by a user through Ambari, we need to handle > > the case where we need to supp

Re: Review Request 47135: Install Setup: SOLR

2016-05-11 Thread Tom Beerbower
> On May 11, 2016, 4:26 a.m., Hemanth Yamijala wrote: > > distro/src/bin/atlas_start.py, line 124 > > > > > > Is running this multiple times OK? When I run a create index multiple > > times locally on my Solr instan

Re: Review Request 47135: Install Setup: SOLR

2016-05-11 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/ --- (Updated May 12, 2016, 1:19 a.m.) Review request for atlas. Changes ---

Re: Review Request 47135: Install Setup: SOLR

2016-05-11 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132618 --- distro/src/conf/hbase/hbase-site.xml.template (line 22)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Hemanth Yamijala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132599 --- distro/src/bin/atlas_start.py (line 124)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:07 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 103 > > > > > > will these env vars be set by AMBARI configs? It can be set by Ambari. I'll deal with it in the related

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:06 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 452 > > > > > > pls rename to create_solr_collection ok - Tom --

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:07 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 391 > > > > > > what is the use of this config? By default, the scripts will start and stop embedded hbase and solr with

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:11 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 102 > > > > > > if this config is changed by a user through Ambari, we need to handle > > the case where we need to supp

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:13 p.m., Suma Shivaprasad wrote: > > distro/src/conf/atlas-application.properties, line 33 > > > > > > we should comment the elastic search entries to avoid confusion ok, makes sense. Do we want

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:14 p.m., Suma Shivaprasad wrote: > > distro/src/bin/atlas_config.py, line 64 > > > > > > shouldnt this be solr5 It works for solr5. I just left it open in case we support solr6, ... - Tom --

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:05 p.m., Suma Shivaprasad wrote: > > distro/pom.xml, line 34 > > > > > > can we take hbase verion from pom instead of hardcoding pls I think so. - Tom

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6 p.m., Suma Shivaprasad wrote: > > distro/pom.xml, line 38 > > > > > > can we take solr version from pom instead You mean from the parent pom? Sure, I think so. - Tom

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Tom Beerbower
> On May 10, 2016, 6:01 p.m., Suma Shivaprasad wrote: > > distro/pom.xml, line 126 > > > > > > will this take care of a similiar fix that Shwetha did to not download > > if it already exists. If not, can we add that

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132508 --- distro/src/bin/atlas_config.py (line 102)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132510 --- distro/src/bin/atlas_config.py (line 64)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132509 --- distro/src/conf/atlas-application.properties (line 33)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132506 --- distro/src/bin/atlas_config.py (line 103)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132507 --- distro/src/bin/atlas_config.py (line 391)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132505 --- distro/src/bin/atlas_config.py (line 452)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132504 --- distro/pom.xml (line 34)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132502 --- distro/pom.xml (line 126)

Re: Review Request 47135: Install Setup: SOLR

2016-05-10 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/#review132500 --- distro/pom.xml (line 38)

Re: Review Request 47135: Install Setup: SOLR

2016-05-09 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/ --- (Updated May 9, 2016, 9:32 p.m.) Review request for atlas. Bugs: ATLAS-663 an

Re: Review Request 47135: Install Setup: SOLR

2016-05-09 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/ --- (Updated May 9, 2016, 9:31 p.m.) Review request for atlas. Bugs: ATLAS-663 an

Review Request 47135: Install Setup: SOLR

2016-05-09 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47135/ --- Review request for atlas. Bugs: ATLAS-673 https://issues.apache.org/jira/br