Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Apoorv Naik
> On Oct. 31, 2016, 10:12 p.m., Suma Shivaprasad wrote: > > Deferred to next patch as discussed. - Apoorv --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154328

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154328 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 31, 2016, 10:09 p.m.) Review request for atlas, Madhan

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 31, 2016, 9:59 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154326 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154299 --- Fix it, then Ship it!

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154316 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-31 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154314 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-28 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 29, 2016, 12:09 a.m.) Review request for atlas, Madhan

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-28 Thread Apoorv Naik
> On Oct. 28, 2016, 6:18 p.m., Suma Shivaprasad wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java, > > line 288 > > > > > > Do checks by TypeCategory rather another

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-28 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154157 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-28 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154155 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-28 Thread Apoorv Naik
> On Oct. 28, 2016, 6:41 p.m., Suma Shivaprasad wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java, line 77 > > > > > > TypeCategory is already added as part of respective AtlasType. Why is > >

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-28 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154153 --- intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-28 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154149 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-27 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/#review154088 ---

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-27 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 28, 2016, 2:18 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-27 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 28, 2016, 2:13 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-27 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 27, 2016, 7:35 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-26 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 26, 2016, 10:36 p.m.) Review request for atlas, Madhan

Re: Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-26 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- (Updated Oct. 26, 2016, 10:09 p.m.) Review request for atlas, Madhan

Review Request 53207: Adding Change listeners to react on changes in TypesDef

2016-10-26 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53207/ --- Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and