Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/ --- (Updated Nov. 24, 2016, 1:32 a.m.) Review request for atlas. Changes ---

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/#review156804 --- Ship it! Looks good to me. - Apoorv Naik On Nov. 23, 2016,

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
> On Nov. 23, 2016, 10:09 p.m., Apoorv Naik wrote: > > webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java, > > line 49 > > > > > > I think dynamic selection of the converter is better

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/ --- (Updated Nov. 23, 2016, 11:55 p.m.) Review request for atlas. Changes

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/#review156786 ---

Re: Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/ --- (Updated Nov. 23, 2016, 11:17 a.m.) Review request for atlas. Changes

Review Request 54023: ATLAS-1319: fix converters between v1 and v2 to handle struct type attributes

2016-11-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54023/ --- Review request for atlas. Bugs: ATLAS-1319