Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-23 Thread David Radley
> On Dec. 22, 2016, 2:47 p.m., David Radley wrote: > > I run the testng tests for atlas-intg in Eclipse and get 6 failures with > > null pointer exceptions and 106 successful tests. > > Apoorv Naik wrote: > Hey David, the apache build is successful. Maybe some environment issue? > Can

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-20 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Dec. 21, 2016, 2:25 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-20 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review159764 --- Fix it, then Ship it!

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-19 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Dec. 19, 2016, 8:21 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-13 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Dec. 13, 2016, 11:30 p.m.) Review request for atlas, Madhan

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-13 Thread Apoorv Naik
> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197 > > > > > > add validations to have typename or supertype in the request to be >

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Dec. 13, 2016, 6:47 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
> On Dec. 6, 2016, 2:42 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java, > > line 486 > > > > > > would be good to add columns attribute since its a

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
> On Dec. 6, 2016, 2:22 a.m., Suma Shivaprasad wrote: > > webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java, line 197 > > > > > > add validations to have typename or supertype in the request to be >

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-12 Thread Apoorv Naik
> On Dec. 6, 2016, 2:48 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, > > line 288 > > > > > > is this not available for test already in the

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-07 Thread Apoorv Naik
> On Dec. 6, 2016, 2:25 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerIT.java, > > line 104 > > > > > > Use constants for qualifiedName, clusterName in

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-07 Thread Apoorv Naik
> On Dec. 6, 2016, 2:45 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, > > line 123 > > > > > > will cause timing issues if we dont wait and

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-07 Thread Apoorv Naik
> On Dec. 6, 2016, 2:48 a.m., Suma Shivaprasad wrote: > > webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java, > > line 288 > > > > > > is this not available for test already in the

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-05 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158113 ---

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-05 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158111 ---

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-05 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158110 ---

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-05 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158108 --- webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-05 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158107 ---

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-12-05 Thread Suma Shivaprasad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review158102 --- webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-30 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Nov. 30, 2016, 11:22 p.m.) Review request for atlas, Madhan

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Nov. 29, 2016, 10:17 p.m.) Review request for atlas, Madhan

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review157336 --- Needs update after the FormatAdapter changes. - Apoorv Naik On

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Nov. 29, 2016, 7:49 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/#review157292 --- Need to revert import only changes in several files.

Re: Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-29 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- (Updated Nov. 29, 2016, 6:20 p.m.) Review request for atlas, Madhan Neethiraj,

Review Request 54058: ATLAS-1311: Integration tests for the V2 Entity APIs

2016-11-24 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54058/ --- Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and