Re: Review Request 51896: ATLAS-1171: structured, high-level APIs

2016-09-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51896/ --- (Updated Sept. 26, 2016, 9:21 a.m.) Review request for atlas. Changes

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Sarath Kumar Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 25, 2016, 11:13 p.m.) Review request for atlas, Madhan

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Sarath Kumar Subramanian
On Sept. 21, 2016, 7:46 a.m., Sarath Kumar Subramanian wrote: > > Add tests > > > > 1. Currently, the model files(like hive_model.json) are auto generated from > > model definitions defined in java(like HiveDataModelGenerator). The patch > > files in this case has to be hand coded which is

[jira] [Updated] (ATLAS-1198) Move from Guice + Spring to only Spring

2016-09-26 Thread Apoorv Naik (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Naik updated ATLAS-1198: --- Description: Right now we're using both Guice and Spring and dependency injection which is not a

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review150489 ---

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/#review150510 --- Ship it! Ship It! - Madhan Neethiraj On Sept. 27, 2016,

Re: Review Request 52077: Column level lineage in Hive

2016-09-26 Thread Vimal Sharma
> On Sept. 21, 2016, 8:58 p.m., Suma Shivaprasad wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java, > > line 97 > > > > > > why is column qualifiedName different from

Re: Rename trait to classification

2016-09-26 Thread David Radley
Hi Hermanth and Mandy , Thanks for your feedback. It does seem like these are de-facto industry terms in the governance industry; the reason I say this is that looking around the web I see quite a few uses of the words governance classification in different domains (including in the Atlas

[jira] [Updated] (ATLAS-916) Return system attributes in get entity definition

2016-09-26 Thread Vimal Sharma (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vimal Sharma updated ATLAS-916: --- Attachment: ATLAS-916.patch > Return system attributes in get entity definition >

Re: Review Request 52077: Column level lineage in Hive

2016-09-26 Thread Shwetha GS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52077/#review150383 --- 1. Can you add a test with lineage query on column? 2.

Re: Rename trait to classification

2016-09-26 Thread David Radley
Hi Hermanth, I appreciate your feedback and openness. It was an interesting point you made about which roles were authoring traits and terms. I guess this is not something Atlas would police. The current traits could be : 1) locked down so only the governance team could update them; in that

Re: Review Request 52077: Column level lineage in Hive

2016-09-26 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52077/ --- (Updated Sept. 26, 2016, 1:06 p.m.) Review request for atlas. Changes

Re: Rename trait to classification

2016-09-26 Thread Hemanth Yamijala
Hi David, Reg. the point I made about sharing traits - I don't want to give an impression that this as an agreed upon point. Apologize if I conveyed that sense. It is a fact that Atlas today has two concepts that are slightly related: Traits (aka Tags) and Business Terms. The latter was new in

Re: Rename trait to classification

2016-09-26 Thread Mandy Chessell
Hello Hemanth, David, This is a great discussion. These concepts are all related, in that they are linked to data descriptions (such as schemas) to characterise data. However, I think your probing is right, the governance classifications are slightly different from traits and glossary terms.

[jira] [Comment Edited] (ATLAS-247) Hive Column level lineage

2016-09-26 Thread Vimal Sharma (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522941#comment-15522941 ] Vimal Sharma edited comment on ATLAS-247 at 9/26/16 12:43 PM: -- Updation of

[jira] [Commented] (ATLAS-247) Hive Column level lineage

2016-09-26 Thread Vimal Sharma (JIRA)
[ https://issues.apache.org/jira/browse/ATLAS-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522941#comment-15522941 ] Vimal Sharma commented on ATLAS-247: Updation of Hive Type system should be supported before this patch

[jira] [Created] (ATLAS-1196) Support circular lineage with Gremlin 3

2016-09-26 Thread Jeffrey Hagelberg (JIRA)
Jeffrey Hagelberg created ATLAS-1196: Summary: Support circular lineage with Gremlin 3 Key: ATLAS-1196 URL: https://issues.apache.org/jira/browse/ATLAS-1196 Project: Atlas Issue Type:

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-26 Thread Jeff Hagelberg
> On Sept. 23, 2016, 7:58 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 341 > > > > > > Can you pls raise a jira for this? I have created

[jira] [Created] (ATLAS-1197) When Atlas is configured with atlas.notification.hook.numthreads > 1, CTAS tables are created twice .

2016-09-26 Thread Sharmadha Sainath (JIRA)
Sharmadha Sainath created ATLAS-1197: Summary: When Atlas is configured with atlas.notification.hook.numthreads > 1, CTAS tables are created twice . Key: ATLAS-1197 URL:

Review Request 52257: Return system attributes in get entity definition

2016-09-26 Thread Vimal Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52257/ --- Review request for atlas. Bugs: ATLAS-916

Fw: Rename trait to classification

2016-09-26 Thread David Radley
Hi, I referred to Business term and Business category - business is a bit generic and not well defined. It would be more accurate to say Glossary term and Glossary category, all the best, David. - Forwarded by David Radley/UK/IBM on 26/09/2016 11:13 - From: David

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Sarath Kumar Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 26, 2016, 3:27 p.m.) Review request for atlas, Madhan

[jira] [Created] (ATLAS-1198) Move from Guice + Spring to only Spring

2016-09-26 Thread Apoorv Naik (JIRA)
Apoorv Naik created ATLAS-1198: -- Summary: Move from Guice + Spring to only Spring Key: ATLAS-1198 URL: https://issues.apache.org/jira/browse/ATLAS-1198 Project: Atlas Issue Type: Improvement

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Sarath Kumar Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51939/ --- (Updated Sept. 26, 2016, 5:25 p.m.) Review request for atlas, Madhan

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Sarath Kumar Subramanian
> On Sept. 26, 2016, 4:43 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/services/AtlasTypePatch.java, > > line 78 > > > > > > Consider using type Map for parames. fixed

Re: Review Request 51939: Framework to apply updates to types in the type-system

2016-09-26 Thread Sarath Kumar Subramanian
> On Sept. 20, 2016, 1:28 p.m., Suma Shivaprasad wrote: > > typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java, > > line 314 > > > > > > We would need to audit types as well to > > know

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

2016-09-26 Thread Jeff Hagelberg
> On Sept. 23, 2016, 8:13 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 575 > > > > > > Is this change, fixing a bug in current code? if so, can