[jira] [Commented] (ATLAS-1175) Type updates should allow removal of optional attributes
[ https://issues.apache.org/jira/browse/ATLAS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15535980#comment-15535980 ] Nigel Jones commented on ATLAS-1175: To avoid resurfacing old values doing the "cleanup" of any entities (ie removing the relevant attribute value) needs to be done with care. Doing it synchronously could be a performance impact for a system with many entities. I think it would be need to be done asynchronously, or potentially could be self-corrected during a future read or update of the entity (this is where integrating such a change in with versioning as david mentioned in ATLAS-1174 may help?) > Type updates should allow removal of optional attributes > > > Key: ATLAS-1175 > URL: https://issues.apache.org/jira/browse/ATLAS-1175 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating, 0.8-incubating >Reporter: Suma Shivaprasad >Assignee: Sarath Subramanian > > Currently optional attributes are not allowed to be removed from a given > type. This should be allowed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1175) Type updates should allow removal of optional attributes
[ https://issues.apache.org/jira/browse/ATLAS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514065#comment-15514065 ] Sarath Subramanian commented on ATLAS-1175: --- It is a corner case - this needs to be addressed and we should not be surfacing values for deleted attributes when you re-add the same attribute. We may need to include a flag when removing attribute to check for all entities of the type to safely remove attribute value from titan. This work requires a separate jiira to handle safe removal of optional attributes and clean entity in titan. > Type updates should allow removal of optional attributes > > > Key: ATLAS-1175 > URL: https://issues.apache.org/jira/browse/ATLAS-1175 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating, 0.8-incubating >Reporter: Suma Shivaprasad >Assignee: Sarath Subramanian > > Currently optional attributes are not allowed to be removed from a given > type. This should be allowed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1175) Type updates should allow removal of optional attributes
[ https://issues.apache.org/jira/browse/ATLAS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509085#comment-15509085 ] Shwetha G S commented on ATLAS-1175: Removing the optional attribute is not an issue as it doesn't surface in entity definition. The issue is if the user adds the removed attribute again - in this case, the entities which had the values for old attribute will re-surface again, which is not right. > Type updates should allow removal of optional attributes > > > Key: ATLAS-1175 > URL: https://issues.apache.org/jira/browse/ATLAS-1175 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating, 0.8-incubating >Reporter: Suma Shivaprasad >Assignee: Sarath Subramanian > > Currently optional attributes are not allowed to be removed from a given > type. This should be allowed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ATLAS-1175) Type updates should allow removal of optional attributes
[ https://issues.apache.org/jira/browse/ATLAS-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495806#comment-15495806 ] David Radley commented on ATLAS-1175: - If you allow the removal of optional attributes, then you effect instances based on the old type that contain the attribute. I know this is a json so maybe we tolerate extra attributes in the json object that do not match the type, but I think this would be misleading. I think that this use case should be considered in ATLAS-1174. > Type updates should allow removal of optional attributes > > > Key: ATLAS-1175 > URL: https://issues.apache.org/jira/browse/ATLAS-1175 > Project: Atlas > Issue Type: Bug >Affects Versions: 0.7-incubating, 0.8-incubating >Reporter: Suma Shivaprasad >Assignee: Vimal Sharma > > Currently optional attributes are not allowed to be removed from a given > type. This should be allowed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
