Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Oct. 4, 2016, 9 p.m., Suma Shivaprasad wrote: > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java, > > line 130 > > > > > > Does the index here refer to the

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review152059 --- Ship it! Ship It! - Suma Shivaprasad On Oct. 7, 2016, 9:28

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Oct. 7, 2016, 9:28 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Oct. 7, 2016, 9:23 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review151486 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review151403 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review151399 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Oct. 4, 2016, 9 p.m., Suma Shivaprasad wrote: > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java, > > line 130 > > > > > > Does the index here refer to the

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review151396 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 23, 2016, 8:36 p.m., Suma Shivaprasad wrote: > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java, > > line 188 > > > > > > can rename this to clear instead of

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review151393 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 23, 2016, 8:36 p.m., Suma Shivaprasad wrote: > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java, > > line 188 > > > > > > can rename this to clear instead of

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 23, 2016, 8:36 p.m., Suma Shivaprasad wrote: > > graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0Database.java, > > line 188 > > > > > > can rename this to clear instead of

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Oct. 4, 2016, 1:28 a.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Oct. 4, 2016, 1:22 a.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150691 --- repository/src/test/resources/hive-instances.json (line 2)

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 23, 2016, 8:13 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 575 > > > > > > Is this change, fixing a bug in current code? if so, can

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 23, 2016, 7:58 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 341 > > > > > > Can you pls raise a jira for this? I have created

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

On Sept. 22, 2016, 11:12 a.m., Jeff Hagelberg wrote: > > Enable checkstyle on new modules with this property in pom.xml - > > true > > > > With patch: > > Running org.apache.atlas.repository.graph.GraphRepoMapperScaleTest > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150230 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150229 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150227 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review150218 ---

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 22, 2016, 11:12 a.m., Shwetha GS wrote: > > catalog/pom.xml, line 67 > > > > > > for now, catalog can only be used with Titan 0.5.4 - why? > > Jeff Hagelberg wrote: > A good portion of the catalog

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 21, 2016, 11:47 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 279 > > > > > > Instead of having multiple checks its better to abstract

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

On Sept. 22, 2016, 11:12 a.m., Jeff Hagelberg wrote: > > Enable checkstyle on new modules with this property in pom.xml - > > true > > > > With patch: > > Running org.apache.atlas.repository.graph.GraphRepoMapperScaleTest > > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Sept. 23, 2016, 3:29 a.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 22, 2016, 11:12 a.m., Shwetha GS wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java, > > line 422 > > > > > > Isn't this also in Titan0Vertex? Yes, I'll move this

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Sept. 23, 2016, 3:21 a.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 22, 2016, 11:12 a.m., Shwetha GS wrote: > > catalog/pom.xml, line 67 > > > > > > for now, catalog can only be used with Titan 0.5.4 - why? A good portion of the catalog project, especially the ones in

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review149947 --- catalog/pom.xml (line 67)

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 21, 2016, 11:47 p.m., Suma Shivaprasad wrote: > > repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala, line > > 279 > > > > > > Instead of having multiple checks its better to abstract

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 21, 2016, 1:54 p.m., David Radley wrote: > > I have just did git checkout master and applied the latest diff. I get > > compile errors. I my workspace it errors in the pom files as it is not > > recognising the new dependancy > > > > org.apache.atlas > >

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On Sept. 21, 2016, 1:54 p.m., David Radley wrote: > > I have just did git checkout master and applied the latest diff. I get > > compile errors. I my workspace it errors in the pom files as it is not > > recognising the new dependancy > > > > org.apache.atlas > >

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/#review149815 --- I have just did git checkout master and applied the latest diff.

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Sept. 21, 2016, 1:49 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated Sept. 21, 2016, 12:28 p.m.) Review request for atlas, David Kantor

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated June 8, 2016, 2:17 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated June 7, 2016, 2:44 a.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated June 6, 2016, 8:44 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated June 6, 2016, 8:35 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated June 6, 2016, 7:19 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated May 27, 2016, 6:20 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated May 27, 2016, 4:07 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated May 27, 2016, 4:04 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated May 27, 2016, 4:01 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated May 27, 2016, 3:48 p.m.) Review request for atlas, David Kantor and

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

> On May 25, 2016, 5:03 p.m., David Kantor wrote: > > distro/src/bin/atlas_config.py, line 162 > > > > > > Perhaps add comments here explaining the need/motivation for > > ATLAS_JAVA_HOME. I added an

Re: Review Request 47810: ATLAS-694: Update Atlas to use Graph DB abstraction layer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47810/ --- (Updated May 27, 2016, 3:30 p.m.) Review request for atlas, David Kantor and