[ 
https://issues.apache.org/jira/browse/ATLAS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272209#comment-15272209
 ] 

ATLAS QA commented on ATLAS-585:
--------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment
  http://issues.apache.org/jira/secure/attachment/12802381/ATLAS-585-v2.patch
  against master revision feff0cf.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 12 new 
or modified test files.

      {color:red}-1 javac{color}.  The applied patch generated 119 javac 
compiler warnings (more than the master's current 113 warnings).

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    +1 checkstyle.  The patch generated 0 code style errors.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 364 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in :
 
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.RexsterGraphJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.AdminJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.EntityJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.MetadataDiscoveryJerseyResourceIT
./webapp/test-output/junitreports/TEST-org.apache.atlas.web.resources.TypesJerseyResourceIT

Test results: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningswebapp.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningscommon.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningssqoop-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningshdfs-model.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningsstorm-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningshive-bridge.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningsrepository.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningstypesystem.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningsclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningsnotification.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/newPatchFindbugsWarningstitan.html
Javac warnings: 
https://builds.apache.org/job/PreCommit-ATLAS-Build/203//artifact/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-ATLAS-Build/203//console

This message is automatically generated.

> NotificationHookConsumer creates new AtlasClient for every message
> ------------------------------------------------------------------
>
>                 Key: ATLAS-585
>                 URL: https://issues.apache.org/jira/browse/ATLAS-585
>             Project: Atlas
>          Issue Type: Bug
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>             Fix For: 0.7-incubating
>
>         Attachments: ATLAS-585-v2.patch, ATLAS-585-v3.patch, ATLAS-585.patch
>
>
> Every AtlasClient instance creates com.sun.jersey.api.client.Client which is 
> expensive. As part of ATLAS-577, NotificationHookConsumer creates new atlas 
> client for every message. This is done to pass the user information(the user 
> who created the message/entities) through the APIs. This wouldn't work in 
> kerberos environment where the credentials are not available on the atlas 
> server. We should probably make the API call as atlas user and pass in the 
> actual user information in another query param(like doas user)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to