Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-15 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/#review156010 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 11, 2016, 3:07

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-11 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/ --- (Updated Nov. 11, 2016, 3:07 p.m.) Review request for atlas, Ankita Sinha,

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-11 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/ --- (Updated Nov. 11, 2016, 2:39 p.m.) Review request for atlas, Ankita Sinha,

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-10 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/#review155686 ---

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-09 Thread Nixon Rodrigues
> On Nov. 3, 2016, 5:33 p.m., Apoorv Naik wrote: > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java, > > line 404 > > > > > > Why not use standard library to read the key from

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-09 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/ --- (Updated Nov. 9, 2016, 1:02 p.m.) Review request for atlas, Ankita Sinha,

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-09 Thread Nixon Rodrigues
> On Nov. 7, 2016, 6:44 p.m., Madhan Neethiraj wrote: > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java, > > line 352 > > > > > > getJwtProperties() - the method seems to be

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/#review155171 ---

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-07 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/ --- (Updated Nov. 7, 2016, 12:59 p.m.) Review request for atlas, Ankita Sinha,

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-03 Thread Apoorv Naik
> On Nov. 3, 2016, 5:33 p.m., Apoorv Naik wrote: > > webapp/src/main/java/org/apache/atlas/web/filters/AtlasSSOAuthenticationFilter.java, > > line 125 > > > > > > Parameterized string instead of concatenation. > >

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-03 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/#review154772 ---

Re: Review Request 53426: ATLAS-1244 - Atlas to Support KnoxSSO Authentication

2016-11-03 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53426/ --- (Updated Nov. 3, 2016, 1:09 p.m.) Review request for atlas, Ankita Sinha,