Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-12-02 Thread Jeff Hagelberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review157862
---


Ship it!




Ship It!

- Jeff Hagelberg


On Dec. 2, 2016, 4:52 p.m., Neeru Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53653/
> ---
> 
> (Updated Dec. 2, 2016, 4:52 p.m.)
> 
> 
> Review request for atlas and Jeff Hagelberg.
> 
> 
> Bugs: Atlas-1284 and Atlas-737
> https://issues.apache.org/jira/browse/Atlas-1284
> https://issues.apache.org/jira/browse/Atlas-737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Aggregate methods and order by fixes.
> 
> 
> Diffs
> -
> 
>   docs/src/site/twiki/Search.twiki 5b9431a4912315e6114cfe5333a6a6d89e87d4d1 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
>  a901b5127b3dcd2939fec2c642475d7aad869d8e 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  32189bc6dab4cc25748e7b6136dc0a89476012c7 
>   
> repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java
>  9a36e780850d0c349343d6a751c5e7f181c86198 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
> 297aa2b8f917d5ae25da6a69901af60542082642 
>   repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
> 6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
> 7074d74770a5098ca82852919f236fd66c6d4a84 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> cff92afe98a6215499a70a9ef00a937804abe73e 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
> 8851b793b0ca032efb57bd76ec9198822e1520c2 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 
> 88edf8f03e356dc4850c16d99f3deb3370d8546d 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  4ac001e7fab7bdea744ec275de39ea1fced77903 
> 
> Diff: https://reviews.apache.org/r/53653/diff/
> 
> 
> Testing
> ---
> 
> Order by fixes to add ability to orderby on supertypes attributes and with 
> alias. 
> 
> Added new aggregate methods support like group by and count, max, min and sum 
> methods.
> 
> Executed all existing order by tests successfully. Added new tests to order 
> by with alias
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-12-02 Thread David Kantor 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review157795
---


Ship it!




- David Kantor


On Dec. 2, 2016, 4:52 p.m., Neeru Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53653/
> ---
> 
> (Updated Dec. 2, 2016, 4:52 p.m.)
> 
> 
> Review request for atlas and Jeff Hagelberg.
> 
> 
> Bugs: Atlas-1284 and Atlas-737
> https://issues.apache.org/jira/browse/Atlas-1284
> https://issues.apache.org/jira/browse/Atlas-737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Aggregate methods and order by fixes.
> 
> 
> Diffs
> -
> 
>   docs/src/site/twiki/Search.twiki 5b9431a4912315e6114cfe5333a6a6d89e87d4d1 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
>  a901b5127b3dcd2939fec2c642475d7aad869d8e 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  32189bc6dab4cc25748e7b6136dc0a89476012c7 
>   
> repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java
>  9a36e780850d0c349343d6a751c5e7f181c86198 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
> 297aa2b8f917d5ae25da6a69901af60542082642 
>   repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
> 6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
> 7074d74770a5098ca82852919f236fd66c6d4a84 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> cff92afe98a6215499a70a9ef00a937804abe73e 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
> 8851b793b0ca032efb57bd76ec9198822e1520c2 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 
> 88edf8f03e356dc4850c16d99f3deb3370d8546d 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  4ac001e7fab7bdea744ec275de39ea1fced77903 
> 
> Diff: https://reviews.apache.org/r/53653/diff/
> 
> 
> Testing
> ---
> 
> Order by fixes to add ability to orderby on supertypes attributes and with 
> alias. 
> 
> Added new aggregate methods support like group by and count, max, min and sum 
> methods.
> 
> Executed all existing order by tests successfully. Added new tests to order 
> by with alias
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-12-02 Thread Neeru Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/
---

(Updated Dec. 2, 2016, 4:52 p.m.)


Review request for atlas and Jeff Hagelberg.


Changes
---

Added more test for groupby and order by+limit working together. Updated 
search.twiki with latest updates.


Bugs: Atlas-1284 and Atlas-737
https://issues.apache.org/jira/browse/Atlas-1284
https://issues.apache.org/jira/browse/Atlas-737


Repository: atlas


Description
---

Aggregate methods and order by fixes.


Diffs (updated)
-

  docs/src/site/twiki/Search.twiki 5b9431a4912315e6114cfe5333a6a6d89e87d4d1 
  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
 a901b5127b3dcd2939fec2c642475d7aad869d8e 
  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
 32189bc6dab4cc25748e7b6136dc0a89476012c7 
  
repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java 
9a36e780850d0c349343d6a751c5e7f181c86198 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
297aa2b8f917d5ae25da6a69901af60542082642 
  repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
7074d74770a5098ca82852919f236fd66c6d4a84 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
cff92afe98a6215499a70a9ef00a937804abe73e 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
8851b793b0ca032efb57bd76ec9198822e1520c2 
  repository/src/test/java/org/apache/atlas/TestUtils.java 
88edf8f03e356dc4850c16d99f3deb3370d8546d 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 4ac001e7fab7bdea744ec275de39ea1fced77903 

Diff: https://reviews.apache.org/r/53653/diff/


Testing
---

Order by fixes to add ability to orderby on supertypes attributes and with 
alias. 

Added new aggregate methods support like group by and count, max, min and sum 
methods.

Executed all existing order by tests successfully. Added new tests to order by 
with alias


Thanks,

Neeru Gupta

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-29 Thread Jeff Hagelberg 


> On Nov. 11, 2016, 3:01 p.m., Jeff Hagelberg wrote:
> > repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java,
> >  line 278
> > 
> >
> > General comment: There are a few other bug fixes that were made to 
> > Gremlin3ExpressionFactory in our fork since that file was contributed that 
> > have not been contributed back yet.  It may make sense to include those in 
> > this patch.  It's up to you.  Sooner or later we'll need to get those 
> > contributed.
> 
> Neeru Gupta wrote:
> I have added included relevant changes from fork to this requests. 
> Additional changes will be included as part of separate request.

Sure, that's fine.


- Jeff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review155716
---


On Nov. 29, 2016, 4:05 p.m., Neeru Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53653/
> ---
> 
> (Updated Nov. 29, 2016, 4:05 p.m.)
> 
> 
> Review request for atlas and Jeff Hagelberg.
> 
> 
> Bugs: Atlas-1284 and Atlas-737
> https://issues.apache.org/jira/browse/Atlas-1284
> https://issues.apache.org/jira/browse/Atlas-737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Aggregate methods and order by fixes.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
>  a901b5127b3dcd2939fec2c642475d7aad869d8e 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  32189bc6dab4cc25748e7b6136dc0a89476012c7 
>   
> repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java
>  9a36e780850d0c349343d6a751c5e7f181c86198 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
> 297aa2b8f917d5ae25da6a69901af60542082642 
>   repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
> 6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
> 7074d74770a5098ca82852919f236fd66c6d4a84 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> cff92afe98a6215499a70a9ef00a937804abe73e 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
> 8851b793b0ca032efb57bd76ec9198822e1520c2 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 
> 88edf8f03e356dc4850c16d99f3deb3370d8546d 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  4ac001e7fab7bdea744ec275de39ea1fced77903 
> 
> Diff: https://reviews.apache.org/r/53653/diff/
> 
> 
> Testing
> ---
> 
> Order by fixes to add ability to orderby on supertypes attributes and with 
> alias. 
> 
> Added new aggregate methods support like group by and count, max, min and sum 
> methods.
> 
> Executed all existing order by tests successfully. Added new tests to order 
> by with alias
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-29 Thread Neeru Gupta 


> On Nov. 11, 2016, 3:01 p.m., Jeff Hagelberg wrote:
> > repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java,
> >  line 278
> > 
> >
> > General comment: There are a few other bug fixes that were made to 
> > Gremlin3ExpressionFactory in our fork since that file was contributed that 
> > have not been contributed back yet.  It may make sense to include those in 
> > this patch.  It's up to you.  Sooner or later we'll need to get those 
> > contributed.

I have added included relevant changes from fork to this requests. Additional 
changes will be included as part of separate request.


- Neeru


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review155716
---


On Nov. 29, 2016, 4:05 p.m., Neeru Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53653/
> ---
> 
> (Updated Nov. 29, 2016, 4:05 p.m.)
> 
> 
> Review request for atlas and Jeff Hagelberg.
> 
> 
> Bugs: Atlas-1284 and Atlas-737
> https://issues.apache.org/jira/browse/Atlas-1284
> https://issues.apache.org/jira/browse/Atlas-737
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Aggregate methods and order by fixes.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
>  a901b5127b3dcd2939fec2c642475d7aad869d8e 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  32189bc6dab4cc25748e7b6136dc0a89476012c7 
>   
> repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java
>  9a36e780850d0c349343d6a751c5e7f181c86198 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
> 297aa2b8f917d5ae25da6a69901af60542082642 
>   repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
> 6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
> 7074d74770a5098ca82852919f236fd66c6d4a84 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> cff92afe98a6215499a70a9ef00a937804abe73e 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
> 8851b793b0ca032efb57bd76ec9198822e1520c2 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 
> 88edf8f03e356dc4850c16d99f3deb3370d8546d 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  4ac001e7fab7bdea744ec275de39ea1fced77903 
> 
> Diff: https://reviews.apache.org/r/53653/diff/
> 
> 
> Testing
> ---
> 
> Order by fixes to add ability to orderby on supertypes attributes and with 
> alias. 
> 
> Added new aggregate methods support like group by and count, max, min and sum 
> methods.
> 
> Executed all existing order by tests successfully. Added new tests to order 
> by with alias
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-29 Thread Neeru Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/
---

(Updated Nov. 29, 2016, 4:05 p.m.)


Review request for atlas and Jeff Hagelberg.


Bugs: Atlas-1284 and Atlas-737
https://issues.apache.org/jira/browse/Atlas-1284
https://issues.apache.org/jira/browse/Atlas-737


Repository: atlas


Description
---

Aggregate methods and order by fixes.


Diffs
-

  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
 a901b5127b3dcd2939fec2c642475d7aad869d8e 
  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
 32189bc6dab4cc25748e7b6136dc0a89476012c7 
  
repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java 
9a36e780850d0c349343d6a751c5e7f181c86198 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
297aa2b8f917d5ae25da6a69901af60542082642 
  repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
7074d74770a5098ca82852919f236fd66c6d4a84 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
cff92afe98a6215499a70a9ef00a937804abe73e 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
8851b793b0ca032efb57bd76ec9198822e1520c2 
  repository/src/test/java/org/apache/atlas/TestUtils.java 
88edf8f03e356dc4850c16d99f3deb3370d8546d 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 4ac001e7fab7bdea744ec275de39ea1fced77903 

Diff: https://reviews.apache.org/r/53653/diff/


Testing
---

Order by fixes to add ability to orderby on supertypes attributes and with 
alias. 

Added new aggregate methods support like group by and count, max, min and sum 
methods.

Executed all existing order by tests successfully. Added new tests to order by 
with alias


Thanks,

Neeru Gupta

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-29 Thread Neeru Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/
---

(Updated Nov. 29, 2016, 3:38 p.m.)


Review request for atlas and Jeff Hagelberg.


Repository: atlas


Description
---

Aggregate methods and order by fixes.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
 a901b5127b3dcd2939fec2c642475d7aad869d8e 
  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
 32189bc6dab4cc25748e7b6136dc0a89476012c7 
  
repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java 
9a36e780850d0c349343d6a751c5e7f181c86198 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
297aa2b8f917d5ae25da6a69901af60542082642 
  repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
7074d74770a5098ca82852919f236fd66c6d4a84 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
cff92afe98a6215499a70a9ef00a937804abe73e 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
8851b793b0ca032efb57bd76ec9198822e1520c2 
  repository/src/test/java/org/apache/atlas/TestUtils.java 
88edf8f03e356dc4850c16d99f3deb3370d8546d 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 4ac001e7fab7bdea744ec275de39ea1fced77903 

Diff: https://reviews.apache.org/r/53653/diff/


Testing
---

Order by fixes to add ability to orderby on supertypes attributes and with 
alias. 

Added new aggregate methods support like group by and count, max, min and sum 
methods.

Executed all existing order by tests successfully. Added new tests to order by 
with alias


Thanks,

Neeru Gupta

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-28 Thread Neeru Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/
---

(Updated Nov. 28, 2016, 8:41 p.m.)


Review request for atlas and Jeff Hagelberg.


Repository: atlas


Description (updated)
---

Aggregate methods and order by fixes.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
 a901b5127b3dcd2939fec2c642475d7aad869d8e 
  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
 32189bc6dab4cc25748e7b6136dc0a89476012c7 
  
repository/src/main/java/org/apache/atlas/gremlin/GremlinExpressionFactory.java 
9a36e780850d0c349343d6a751c5e7f181c86198 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 9ef31601fd379cd97f68bef56ac80598324e4f59 
  repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
297aa2b8f917d5ae25da6a69901af60542082642 
  repository/src/main/scala/org/apache/atlas/query/GremlinEvaluator.scala 
6803036df7ef7b7c7c08579f1f7cbd4c731aec46 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
  repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
7074d74770a5098ca82852919f236fd66c6d4a84 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
cff92afe98a6215499a70a9ef00a937804abe73e 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
8851b793b0ca032efb57bd76ec9198822e1520c2 
  repository/src/test/java/org/apache/atlas/TestUtils.java 
88edf8f03e356dc4850c16d99f3deb3370d8546d 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 4ac001e7fab7bdea744ec275de39ea1fced77903 

Diff: https://reviews.apache.org/r/53653/diff/


Testing (updated)
---

Order by fixes to add ability to orderby on supertypes attributes and with 
alias. 

Added new aggregate methods support like group by and count, max, min and sum 
methods.

Executed all existing order by tests successfully. Added new tests to order by 
with alias


Thanks,

Neeru Gupta

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-14 Thread Shwetha GS 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review155887
---



Will query 'hive_table select owner as o orderby o' work as well?

- Shwetha GS


On Nov. 11, 2016, 2:34 p.m., Neeru Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53653/
> ---
> 
> (Updated Nov. 11, 2016, 2:34 p.m.)
> 
> 
> Review request for atlas and Jeff Hagelberg.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Merge branch 'master' into oms-750
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
>  a901b5127b3dcd2939fec2c642475d7aad869d8e 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  32189bc6dab4cc25748e7b6136dc0a89476012c7 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> cff92afe98a6215499a70a9ef00a937804abe73e 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
> 8851b793b0ca032efb57bd76ec9198822e1520c2 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  645fef1fb3abf8cd2d4abf4429b00c32837ef0c0 
> 
> Diff: https://reviews.apache.org/r/53653/diff/
> 
> 
> Testing
> ---
> 
> Executed all existing order by tests successfully. Added new tests to order 
> by with alias
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-11 Thread Jeff Hagelberg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/#review155716
---



Just a few minor comments.  Please set the JIRA number in this review and 
upload the patch once you have addressed the review comments.


repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
 (line 70)


Remove tab characters (here and other places)



repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
 (line 278)


General comment: There are a few other bug fixes that were made to 
Gremlin3ExpressionFactory in our fork since that file was contributed that have 
not been contributed back yet.  It may make sense to include those in this 
patch.  It's up to you.  Sooner or later we'll need to get those contributed.



repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
 (line 285)


Please remove the added whitespace.



repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 


Please explain why this test case is being removed.


- Jeff Hagelberg


On Nov. 11, 2016, 2:34 p.m., Neeru Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53653/
> ---
> 
> (Updated Nov. 11, 2016, 2:34 p.m.)
> 
> 
> Review request for atlas and Jeff Hagelberg.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Merge branch 'master' into oms-750
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
>  a901b5127b3dcd2939fec2c642475d7aad869d8e 
>   
> repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
>  32189bc6dab4cc25748e7b6136dc0a89476012c7 
>   repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
> ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> cff92afe98a6215499a70a9ef00a937804abe73e 
>   repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
> 8851b793b0ca032efb57bd76ec9198822e1520c2 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  645fef1fb3abf8cd2d4abf4429b00c32837ef0c0 
> 
> Diff: https://reviews.apache.org/r/53653/diff/
> 
> 
> Testing
> ---
> 
> Executed all existing order by tests successfully. Added new tests to order 
> by with alias
> 
> 
> Thanks,
> 
> Neeru Gupta
> 
>

Re: Review Request 53653: ATLAS-1284 Fixed issues with order by clause while sorting with alias and on super type attributes

2016-11-11 Thread Neeru Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53653/
---

(Updated Nov. 11, 2016, 2:34 p.m.)


Review request for atlas and Jeff Hagelberg.


Repository: atlas


Description
---

Merge branch 'master' into oms-750


Diffs
-

  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin2ExpressionFactory.java
 a901b5127b3dcd2939fec2c642475d7aad869d8e 
  
repository/src/main/java/org/apache/atlas/gremlin/Gremlin3ExpressionFactory.java
 32189bc6dab4cc25748e7b6136dc0a89476012c7 
  repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 
ee58eee7b4b2c41cc8f6dc1e4952b83ed0c833df 
  repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
cff92afe98a6215499a70a9ef00a937804abe73e 
  repository/src/test/java/org/apache/atlas/BaseRepositoryTest.java 
8851b793b0ca032efb57bd76ec9198822e1520c2 
  
repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
 645fef1fb3abf8cd2d4abf4429b00c32837ef0c0 

Diff: https://reviews.apache.org/r/53653/diff/


Testing
---

Executed all existing order by tests successfully. Added new tests to order by 
with alias


Thanks,

Neeru Gupta