Re: Fix for avro compiler error

2017-01-13 Thread Ben McCann
Thanks so much for taking a look. You are correct. I assumed the code wasn't on the 1.8 branch yet given that someone opened a PR for it. I've reported to the author that the code is already present and he has closed that PR. I would like to backport it to the 1.7 branch as well, so I've opened a

[jira] [Commented] (AVRO-1901) creating a record called "Exception" leads to generated code not compiling

2017-01-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822612#comment-15822612 ] ASF GitHub Bot commented on AVRO-1901: -- Github user radai-rosenblatt closed the pull request at:

[GitHub] avro pull request #140: AVRO-1901: Record named Exception generated bad code

2017-01-13 Thread radai-rosenblatt
Github user radai-rosenblatt closed the pull request at: https://github.com/apache/avro/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (AVRO-1901) creating a record called "Exception" leads to generated code not compiling

2017-01-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822514#comment-15822514 ] ASF GitHub Bot commented on AVRO-1901: -- GitHub user benmccann opened a pull request:

[GitHub] avro pull request #188: AVRO-1901: Record named Exception generated bad code

2017-01-13 Thread benmccann
GitHub user benmccann opened a pull request: https://github.com/apache/avro/pull/188 AVRO-1901: Record named Exception generated bad code You can merge this pull request into a Git repository by running: $ git pull https://github.com/benmccann/avro backport Alternatively you

Invalid default values

2017-01-13 Thread Gabriel Commeau
Hi all, I’ve been looking into invalid default values when parsing Avro schemas using the maven plugin. I’ve followed the change AVRO-1652, and it makes sense to me to drop the print statement. However, I don’t understand the logic behind allowing invalid default values by default (in

Re: [REPORT] January 2017 board report

2017-01-13 Thread Niels Basjes
LGTM On 13 Jan 2017 19:53, "Ryan Blue" wrote: > Everyone, > > Here's the January 2017 board report. Please reply if you'd like to make a > correction. Notably, my summary of recent threads on community engagement > may need to be updated. My intent was a neutral

[REPORT] January 2017 board report

2017-01-13 Thread Ryan Blue
Everyone, Here's the January 2017 board report. Please reply if you'd like to make a correction. Notably, my summary of recent threads on community engagement may need to be updated. My intent was a neutral summary. Thanks, rb ## Description: - Avro is a cross-language data serialization

[jira] [Commented] (AVRO-1983) Unreleased resources

2017-01-13 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821939#comment-15821939 ] Gabor Szadovszky commented on AVRO-1983: This one is created during we've had problems with JIRA.

[jira] [Commented] (AVRO-1984) Unreleased resources

2017-01-13 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821938#comment-15821938 ] Gabor Szadovszky commented on AVRO-1984: This one is created during we've had problems with JIRA.

[jira] [Updated] (AVRO-1983) Unreleased resources

2017-01-13 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky updated AVRO-1983: --- Affects Version/s: 1.8.1 Component/s: java > Unreleased resources >

[jira] [Assigned] (AVRO-1983) Unreleased resources

2017-01-13 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky reassigned AVRO-1983: -- Assignee: (was: Gabor Szadovszky) > Unreleased resources > > >

[jira] [Assigned] (AVRO-1983) Unreleased resources

2017-01-13 Thread Gabor Szadovszky (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky reassigned AVRO-1983: -- Assignee: Gabor Szadovszky > Unreleased resources > > >

Re: Fix for avro compiler error

2017-01-13 Thread Niels Basjes
Hi, I had a quick look. As far as I can see this issue has already been fixed. https://issues.apache.org/jira/browse/AVRO-1901 So why another pull request? Niels Basjes On Fri, Jan 13, 2017 at 12:57 PM, Ben McCann wrote: > Just a friendly reminder to please

Re: Fix for avro compiler error

2017-01-13 Thread Ben McCann
Just a friendly reminder to please take a look at this PR. Thanks, Ben On Wed, Jan 11, 2017 at 11:47 AM, Ben McCann wrote: > Hi, > > Would someone be able to merge this pending PR? > > https://github.com/apache/avro/pull/140 > > Thanks, > Ben > >

[jira] [Commented] (AVRO-1799) java: GenericData.toString() mutates underlying ByteBuffer backed data

2017-01-13 Thread Ryan Skraba (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15821653#comment-15821653 ] Ryan Skraba commented on AVRO-1799: --- Just for reference, it looks like this has been fixed in 1.8.1 as