[jira] [Comment Edited] (AVRO-1335) C++ should support field default values

2017-08-27 Thread Thiruvalluvan M. G. (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143358#comment-16143358 ] Thiruvalluvan M. G. edited comment on AVRO-1335 at 8/28/17 4:30 AM: The

[jira] [Comment Edited] (AVRO-1335) C++ should support field default values

2017-08-27 Thread Thiruvalluvan M. G. (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143358#comment-16143358 ] Thiruvalluvan M. G. edited comment on AVRO-1335 at 8/28/17 4:29 AM: The

[jira] [Commented] (AVRO-1335) C++ should support field default values

2017-08-27 Thread Thiruvalluvan M. G. (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143358#comment-16143358 ] Thiruvalluvan M. G. commented on AVRO-1335: --- The pull request looks good. However a couple of

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143208#comment-16143208 ] Zoltan Farkas commented on AVRO-1340: - Removing a value would only be possible if a fallback exists.

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Felix GV (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143200#comment-16143200 ] Felix GV commented on AVRO-1340: I think we're on the same page... Going from no fallback to a fallback is

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143186#comment-16143186 ] Zoltan Farkas commented on AVRO-1340: - In you example if v2 symbols are identical with v1 symbols,

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Felix GV (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143160#comment-16143160 ] Felix GV commented on AVRO-1340: I am not convinced that it should be compatible to change

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143153#comment-16143153 ] Zoltan Farkas commented on AVRO-1340: - FELIX> Can v1 have no "fallbackSymbol", v2 define

[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-08-27 Thread Felix GV (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143120#comment-16143120 ] Felix GV commented on AVRO-1340: Can you please describe the compatibility rules for changing not just