[
https://issues.apache.org/jira/browse/AVRO-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated AVRO-2385:
--
Description:
Steps to reproduce:
Create an Avro schema with an uppercase field:
{code}
{
"type":
[
https://issues.apache.org/jira/browse/AVRO-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated AVRO-2385:
--
Description:
Steps to reproduce:
Create an Avro schema with an uppercase field:
{code}
{
"type":
[
https://issues.apache.org/jira/browse/AVRO-2385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Busbey updated AVRO-2385:
--
Environment: Using Maven plugin with Java 8 (was: Using Maven plugin with
Java 8:
{{ }}
{{
I created a PR now where I simply made the methods public, which fixes the
regression but is not an ideal solution.
https://github.com/apache/avro/pull/511
//Katrin
On 2019-05-03, 12:36, "Nandor Kollar (JIRA)" wrote:
[
Great, thanks Ryan and Zoltan for your feedback! As the next step, I go
ahead and open a PR for review with option #3 soon.
On Thu, May 2, 2019 at 3:30 PM Zoltan Ivanfi
wrote:
> Hi,
>
> I also vote for the 3rd option (two new logical types:
> ‘local-timestamp-millis’ and
Nandor Kollar created AVRO-2386:
---
Summary: Generated code doesn't compile
Key: AVRO-2386
URL: https://issues.apache.org/jira/browse/AVRO-2386
Project: Apache Avro
Issue Type: Bug
[
https://issues.apache.org/jira/browse/AVRO-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Kollar updated AVRO-2386:
Summary: Generated code doesn't compile, because customDecode and (was:
Generated code doesn't
[
https://issues.apache.org/jira/browse/AVRO-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Kollar updated AVRO-2386:
Description:
The generated code for
{code}
{"namespace": "org.apache.avro.codegentest.some",
Okay, I created a Jira: https://issues.apache.org/jira/browse/AVRO-2386
Thanks Katrin, nice catch! You can open a PR for
https://github.com/apache/avro.
Because this is a regression, I vote -1 (non-binding) on RC3
On Fri, May 3, 2019 at 12:20 PM Katrin Skoglund
wrote:
> I realized I don't
[
https://issues.apache.org/jira/browse/AVRO-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Kollar updated AVRO-2386:
Summary: Generated code doesn't compile, because customDecode and
customEncode are protected (was:
[
https://issues.apache.org/jira/browse/AVRO-2386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Kollar updated AVRO-2386:
Summary: Generated code doesn't compile, because (was: Generated code
doesn't compile)
>
I realized I don't have a Jira account, should I sign up for one?
On 2019-05-03, 12:09, "Nandor Kollar" wrote:
Ah, okay, I see. Well, in this case it is a release blocker then, since it
is indeed a regression. If you've an account to Apache Jira, please file a
Jira here:
Ah, okay, I see. Well, in this case it is a release blocker then, since it
is indeed a regression. If you've an account to Apache Jira, please file a
Jira here: https://issues.apache.org/jira/projects/AVRO/issues
On Fri, May 3, 2019 at 11:38 AM Katrin Skoglund
wrote:
> Hi Nandor!
>
> Ah, I
Hi Nandor!
Ah, I wasn't aware that the method is new. What I actually meant was that code
generation that previously worked now generates code that no longer compiles,
which I would say is a regression. The implementation of customEncode() in the
class representing the outer record calls the
Hi Katrin,
It appears to me, that these methods didn't exist in previous Avro
versions, they were added in https://github.com/apache/avro/pull/350 and
were renamed and reduced their visibility in
https://github.com/apache/avro/pull/350/commits/d320b6b536c49b485be45286dbdb73226eef4b35.
Actually it
Hi all,
I just managed to test the new RC, specifically the Java code generation, with
one of the libraries we use. I then noticed that their generated java code no
longer compiles because of a change in access level of two methods.
The generated methods customEncode and customDecode are
16 matches
Mail list logo
