[jira] [Commented] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2016-04-12 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237545#comment-15237545 ] peter liu commented on AVRO-1701: - looks good to me > warning: comparison between 'const enum

[jira] [Commented] (AVRO-523) records with the same name as a member generate bad c++ code

2015-08-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721681#comment-14721681 ] peter liu commented on AVRO-523: LiuYanbos-MacBook:build liuyanbo$ cat test.hh {code:cpp}

[jira] [Commented] (AVRO-523) records with the same name as a member generate bad c++ code

2015-08-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721679#comment-14721679 ] peter liu commented on AVRO-523: I am able to generate code based on the given schema. It

[jira] [Assigned] (AVRO-523) records with the same name as a member generate bad c++ code

2015-08-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu reassigned AVRO-523: -- Assignee: peter liu records with the same name as a member generate bad c++ code

[jira] [Resolved] (AVRO-523) records with the same name as a member generate bad c++ code

2015-08-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu resolved AVRO-523. Resolution: Cannot Reproduce records with the same name as a member generate bad c++ code

[jira] [Commented] (AVRO-522) the rule on unions containing identical types are not enforced

2015-08-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721696#comment-14721696 ] peter liu commented on AVRO-522: seems the issue has been fixed {noformat}

[jira] [Resolved] (AVRO-522) the rule on unions containing identical types are not enforced

2015-08-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu resolved AVRO-522. Resolution: Cannot Reproduce Assignee: peter liu the rule on unions containing identical types are not

[jira] [Commented] (AVRO-1635) C++ schema aware encoders throw tr1::bad_weak_ptr exception for recursive schema

2015-08-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14721910#comment-14721910 ] peter liu commented on AVRO-1635: - I can reproduce this, but does Avro support recursive

[jira] [Commented] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2015-08-26 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14716025#comment-14716025 ] peter liu commented on AVRO-1701: - I think the schemas are different, one is the writer

[jira] [Commented] (AVRO-1593) C++ json encoder assumes C locale and generates invalid UTF-8 sequence

2015-08-25 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712480#comment-14712480 ] peter liu commented on AVRO-1593: - this patch looks good to me and pretty straight forward,

[jira] [Commented] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning

2015-08-25 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712485#comment-14712485 ] peter liu commented on AVRO-1700: - this is just one line change to fix a typo, can we

[jira] [Commented] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2015-08-25 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712488#comment-14712488 ] peter liu commented on AVRO-1701: - this is also a simple change to fix the warnings which

[jira] [Commented] (AVRO-1670) Biicode integretion

2015-08-25 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14712474#comment-14712474 ] peter liu commented on AVRO-1670: - do we know if there is any apache project using biicode?

[jira] [Resolved] (AVRO-1674) Optional field does not work in avro-cpp

2015-08-23 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu resolved AVRO-1674. - Resolution: Duplicate Optional field does not work in avro-cpp

[jira] [Commented] (AVRO-1335) C++ should support field default values

2015-08-22 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14708299#comment-14708299 ] peter liu commented on AVRO-1335: - just did a quick test with the patch, but it didn't

[jira] [Updated] (AVRO-1335) C++ should support field default values

2015-08-22 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1335: Status: Open (was: Patch Available) C++ should support field default values

[jira] [Commented] (AVRO-1702) Add LogicalType support to c++ library

2015-08-17 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14699752#comment-14699752 ] peter liu commented on AVRO-1702: - Sure, [~rdblue]. I will review some of high priority

[jira] [Updated] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning

2015-07-28 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1700: Status: Patch Available (was: Open) avro_BufferStreambuf_hh__ header guard warning

[jira] [Updated] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning

2015-07-28 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1700: Attachment: AVRO-1700.1.patch avro_BufferStreambuf_hh__ header guard warning

[jira] [Updated] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2015-07-28 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1701: Status: Patch Available (was: Open) warning: comparison between 'const enum testgen_r::ExampleEnum' and

[jira] [Assigned] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2015-07-28 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu reassigned AVRO-1701: --- Assignee: peter liu warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const

[jira] [Assigned] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning

2015-07-28 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu reassigned AVRO-1700: --- Assignee: peter liu avro_BufferStreambuf_hh__ header guard warning

[jira] [Updated] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2015-07-28 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1701: Attachment: AVRO-1701.1.patch warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const

[jira] [Commented] (AVRO-1702) Add LogicalType support to c++ library

2015-07-28 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14645442#comment-14645442 ] peter liu commented on AVRO-1702: - [~rdblue] could you please kindly review? Add

[jira] [Commented] (AVRO-1702) Add LogicalType support to c++ library

2015-07-12 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14624117#comment-14624117 ] peter liu commented on AVRO-1702: - thanks, [~b...@cloudera.com]. can you please add me to

[jira] [Updated] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning

2015-07-11 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1700: Description: saw below warning while compiling with g++ 4.2.1 on mac os 10.10.3 {quote}

[jira] [Created] (AVRO-1700) avro_BufferStreambuf_hh__ header guard warning

2015-07-11 Thread peter liu (JIRA)
peter liu created AVRO-1700: --- Summary: avro_BufferStreambuf_hh__ header guard warning Key: AVRO-1700 URL: https://issues.apache.org/jira/browse/AVRO-1700 Project: Avro Issue Type: Bug

[jira] [Updated] (AVRO-1702) Add LogicalType support to c++ library

2015-07-11 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1702: Component/s: (was: java) c++ Add LogicalType support to c++ library

[jira] [Updated] (AVRO-1702) Add LogicalType support to c++ library

2015-07-11 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1702: Fix Version/s: (was: 1.7.8) Add LogicalType support to c++ library

[jira] [Updated] (AVRO-1702) Add LogicalType support to c++ library

2015-07-11 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1702: Description: I'd like to port the logicaltype support to c++ library (was: AVRO-1402 updates the Avro spec

[jira] [Created] (AVRO-1702) Add LogicalType support to c++ library

2015-07-11 Thread peter liu (JIRA)
peter liu created AVRO-1702: --- Summary: Add LogicalType support to c++ library Key: AVRO-1702 URL: https://issues.apache.org/jira/browse/AVRO-1702 Project: Avro Issue Type: New Feature

[jira] [Created] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2015-07-11 Thread peter liu (JIRA)
peter liu created AVRO-1701: --- Summary: warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum' Key: AVRO-1701 URL: https://issues.apache.org/jira/browse/AVRO-1701

[jira] [Updated] (AVRO-1701) warning: comparison between 'const enum testgen_r::ExampleEnum' and 'const enum testgen::ExampleEnum'

2015-07-11 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peter liu updated AVRO-1701: Description: saw below warning while compiling with g++ 4.2 and g++ 4.8 on mac os and linux {quote} [ 85%]

[jira] [Commented] (AVRO-1256) C++ API compileJsonSchema ignores doc and custom attributes on a field/record

2015-06-30 Thread peter liu (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608639#comment-14608639 ] peter liu commented on AVRO-1256: - thanks for the patch, [~pidefrem]. This is exactly what