[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860700#comment-15860700
]
ASF GitHub Bot commented on AVRO-1667:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199528#comment-15199528
]
Zoltan Farkas commented on AVRO-1667:
-
Ryan I just reviewed the commit, can we change:
{code}
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199918#comment-15199918
]
Zoltan Farkas commented on AVRO-1667:
-
You're right... I was still visualizing the initial
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199881#comment-15199881
]
Ryan Blue commented on AVRO-1667:
-
Is there a semantic difference between the two?
> Parser symbol tree
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199891#comment-15199891
]
Zoltan Farkas commented on AVRO-1667:
-
Yes,
for (int i = 0, n = fixups.size(); i < n; i += 1)
will
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199896#comment-15199896
]
Ryan Blue commented on AVRO-1667:
-
I don't think that's correct. The call to fixups.size() is in
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196094#comment-15196094
]
Zoltan Farkas commented on AVRO-1667:
-
that's great!
> Parser symbol tree flattening is broken for
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196059#comment-15196059
]
Ryan Blue commented on AVRO-1667:
-
I committed the test that caught the original bug, just not the binary
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196036#comment-15196036
]
Zoltan Farkas commented on AVRO-1667:
-
The unit test did catch the original issue though, so it is
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195523#comment-15195523
]
ASF subversion and git services commented on AVRO-1667:
---
Commit
Ryan, your fix implementation looks ok, except that copyFixups I would change
to:
private static void copyFixups(List fixups, Symbol[] out, int outPos,
Symbol[] toCopy) {
final int nrFixups = fixups.size();
for (int i = 0; i < nrFixups; i++) {
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183736#comment-15183736
]
Zoltan Farkas commented on AVRO-1667:
-
Ryan,
So far I think your code is logically correct and an
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183646#comment-15183646
]
Zoltan Farkas commented on AVRO-1667:
-
I extended, the unit test to complicate the recursiveness, an I
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183556#comment-15183556
]
Zoltan Farkas commented on AVRO-1667:
-
will improve the unit test.
> Parser symbol tree flattening is
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183246#comment-15183246
]
Ryan Blue commented on AVRO-1667:
-
We just need a fixup that applies to a production that gets copied
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174106#comment-15174106
]
ASF GitHub Bot commented on AVRO-1667:
--
GitHub user zolyfarkas opened a pull request:
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15145970#comment-15145970
]
Zoltan Farkas commented on AVRO-1667:
-
A feature branch based on latest official trunk is also
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14723423#comment-14723423
]
Zoltan Farkas commented on AVRO-1667:
-
you're welcome
The whitespace changes are for whatever reason
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616501#comment-14616501
]
Tom White commented on AVRO-1667:
-
[~zolyfarkas] thanks for the patch. I think that thethe
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611725#comment-14611725
]
Zoltan Farkas commented on AVRO-1667:
-
yup, that is correct.
Parser symbol tree
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610764#comment-14610764
]
Zoltan Farkas commented on AVRO-1667:
-
A tough one, it was tuff to fix this more than a
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610769#comment-14610769
]
Ryan Blue commented on AVRO-1667:
-
I think I see what you're saying: when flattening a
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610705#comment-14610705
]
Ryan Blue commented on AVRO-1667:
-
What I'm trying to understand is why the null
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609296#comment-14609296
]
Zoltan Farkas commented on AVRO-1667:
-
HI Ryan,
The issue is actually highlighted in
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608973#comment-14608973
]
Zoltan Farkas commented on AVRO-1667:
-
Any interest in somebody integrating this?
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609227#comment-14609227
]
Ryan Blue commented on AVRO-1667:
-
[~zolyfarkas], I can take a look. Can you describe the
[
https://issues.apache.org/jira/browse/AVRO-1667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14529144#comment-14529144
]
Zoltan Farkas commented on AVRO-1667:
-
I have a fix that seem to work at:
27 matches
Mail list logo
