[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033078#comment-16033078
]
Sean Busbey commented on AVRO-1704:
---
I think that's because the fix version wasn't properly set when it
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033068#comment-16033068
]
Jacob Rideout commented on AVRO-1704:
-
Hmmm ... It looks like it is in the branch-1.8. I am confused
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033065#comment-16033065
]
Sean Busbey commented on AVRO-1704:
---
Looks like it's in 1.8.2 to me:
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033060#comment-16033060
]
Sean Busbey commented on AVRO-1704:
---
The JIRA is resolved and it was listed as a blocker for 1.8.2. Is it
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033034#comment-16033034
]
Jacob Rideout commented on AVRO-1704:
-
What needs to be done to land this in 1.8.3?
> Standardized
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712516#comment-15712516
]
Ryan Blue commented on AVRO-1704:
-
You mean erring on the side of caution and using a larger hash? I don't
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712508#comment-15712508
]
Ryan Blue commented on AVRO-1704:
-
With a spec like this, we want to be careful about having too many
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572449#comment-15572449
]
radai rosenblatt commented on AVRO-1704:
Also, since this is somewhat Kafka related, i would like
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572398#comment-15572398
]
radai rosenblatt commented on AVRO-1704:
At LinkedIn we use a similar scheme for our avro payloads
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463478#comment-15463478
]
Ryan Blue commented on AVRO-1704:
-
Thanks for reviewing!
> Standardized format for encoding messages with
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463379#comment-15463379
]
Sean Busbey commented on AVRO-1704:
---
+1 on AVRO-1704.4.patch
> Standardized format for encoding messages
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15461949#comment-15461949
]
Ryan Blue commented on AVRO-1704:
-
I'm marking this as a blocker for the 1.8.2 release because the code is
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15461947#comment-15461947
]
Ryan Blue commented on AVRO-1704:
-
[~busbey], could you have a look at the last patch I posted with the
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391974#comment-15391974
]
Sean Busbey commented on AVRO-1704:
---
FWIW, I belatedly agree with Doug's statement.
Do we have our
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391193#comment-15391193
]
Ryan Blue commented on AVRO-1704:
-
I just committed the Java implementation, with additional Javadoc. This
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391117#comment-15391117
]
Ryan Blue commented on AVRO-1704:
-
Sounds good to me! I'll fix the missing Javadoc and remove that change.
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391091#comment-15391091
]
Doug Cutting commented on AVRO-1704:
We don't promise source-compatibility for minor Avro releases, but
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390333#comment-15390333
]
Ryan Blue commented on AVRO-1704:
-
For the createDatumReader/Writer change: it is [binary compatible
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389787#comment-15389787
]
Doug Cutting commented on AVRO-1704:
+1 overall.
Two minor questions:
- Is the change to the
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387031#comment-15387031
]
Ryan Blue commented on AVRO-1704:
-
I agree with your reasoning on naming, so lets go with MessageEncoder. I
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382696#comment-15382696
]
Doug Cutting commented on AVRO-1704:
I doubt we'll ever need this abstracted, and having it so might
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381561#comment-15381561
]
Ryan Blue commented on AVRO-1704:
-
I think this should be abstract. The format that we're adding solves one
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371389#comment-15371389
]
Doug Cutting commented on AVRO-1704:
I don't see why anyone would prefer the interface to the abstract
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369379#comment-15369379
]
Ryan Blue commented on AVRO-1704:
-
Forgot to add: I've kept the new commits separate so you can see what
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369378#comment-15369378
]
Ryan Blue commented on AVRO-1704:
-
[~cutting], I've pushed a couple new commits to the pull request. The
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353906#comment-15353906
]
Doug Cutting commented on AVRO-1704:
I think all the methods are useful but some of them (e.g.,
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353737#comment-15353737
]
Ryan Blue commented on AVRO-1704:
-
I agree that the current interface is wide. I think we should have the
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353614#comment-15353614
]
Doug Cutting commented on AVRO-1704:
That decoder interface seems particularly wide. Might these be
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352355#comment-15352355
]
Ryan Blue commented on AVRO-1704:
-
[~nielsbasjes], sorry it's taken so long for me to get back to you on
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352338#comment-15352338
]
ASF GitHub Bot commented on AVRO-1704:
--
GitHub user rdblue opened a pull request:
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273205#comment-15273205
]
Niels Basjes commented on AVRO-1704:
Thanks for the great feedback.
I'm going to work on these points.
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271360#comment-15271360
]
Doug Cutting commented on AVRO-1704:
A few more comments:
- I think we can move all of the
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271178#comment-15271178
]
Doug Cutting commented on AVRO-1704:
A few quick comments:
- A prefix with non-printing characters has
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268928#comment-15268928
]
Ryan Blue commented on AVRO-1704:
-
Yeah, sorry about not replying yet. I haven't gotten a great chance for
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254092#comment-15254092
]
Niels Basjes commented on AVRO-1704:
Question: What would be the preferred way of handling error
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15247442#comment-15247442
]
Niels Basjes commented on AVRO-1704:
I agree with what you are saying. So the header should be shorter,
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244991#comment-15244991
]
Ryan Blue commented on AVRO-1704:
-
Sorry if what I said wasn't clear. I'm not proposing that we get rid of
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244947#comment-15244947
]
Niels Basjes commented on AVRO-1704:
A few of the thoughts I had when creating the current patch:
#
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15244347#comment-15244347
]
Ryan Blue commented on AVRO-1704:
-
Looks like I was a little too optimistic about time to review things
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238996#comment-15238996
]
Niels Basjes commented on AVRO-1704:
I have a first addition: Think about supporting encrytion.
>
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235438#comment-15235438
]
Ryan Blue commented on AVRO-1704:
-
Thanks for working on this, Niels. I'll make some comments later today
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210535#comment-15210535
]
Niels Basjes commented on AVRO-1704:
I did some experimenting over the last week and I posted my
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190866#comment-15190866
]
Niels Basjes commented on AVRO-1704:
Thanks for pointing this out.
My updated proposal for this:
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189594#comment-15189594
]
Doug Cutting commented on AVRO-1704:
bq. remove the things that do not impact the binary form of the
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189473#comment-15189473
]
Niels Basjes commented on AVRO-1704:
Note that having the "AVRO" prefix will also limit the number of
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189402#comment-15189402
]
Niels Basjes commented on AVRO-1704:
I've been looking into what kind of solution would work here since
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133238#comment-15133238
]
ASF GitHub Bot commented on AVRO-1704:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906640#comment-14906640
]
Ryan Blue commented on AVRO-1704:
-
[~dasch], I think the most common one is CRC-64-AVRO. That's exactly why
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14900357#comment-14900357
]
Daniel Schierbeck commented on AVRO-1704:
-
[~rdblue] If there's already widespread usage of `` then
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740476#comment-14740476
]
Daniel Schierbeck commented on AVRO-1704:
-
I think it's fine to standardize on a single fingerprint
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14740477#comment-14740477
]
Daniel Schierbeck commented on AVRO-1704:
-
If we can agree on a format I can do the Ruby
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739165#comment-14739165
]
Ryan Blue commented on AVRO-1704:
-
I think this is a good idea. Quite a few people are doing this already,
[
https://issues.apache.org/jira/browse/AVRO-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14629488#comment-14629488
]
ASF GitHub Bot commented on AVRO-1704:
--
GitHub user dasch opened a pull request:
53 matches
Mail list logo
