[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17163100#comment-17163100
]
Dan Lipofsky commented on AVRO-1891:
This says it was fixes in 1.9.1, but I have the same problem (or
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956389#comment-16956389
]
Randi Thomas commented on AVRO-1891:
with 1.9.1 I am getting
{{}}
{code:java}
Not in union
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946031#comment-16946031
]
Ryan Skraba commented on AVRO-1891:
---
My apologies: joda-time was removed in 1.10.0, not 1.9.1. I
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946022#comment-16946022
]
Ryan Skraba commented on AVRO-1891:
---
Hello! A quick test using the code from the description -- *this
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945492#comment-16945492
]
Sean Busbey commented on AVRO-1891:
---
I don't think folks know. The changes in PR #329 claimed to address
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942955#comment-16942955
]
Ryan Stull commented on AVRO-1891:
--
Does anyone know if this is fixed in the latest `1.9.1` version?
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896472#comment-16896472
]
Dylan Patterson commented on AVRO-1891:
---
+1 on what the status of this issue is please.
> Generated
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787433#comment-16787433
]
Ivan Greene commented on AVRO-1891:
---
Also curious; what are the remaining unresolved parts of this
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753788#comment-16753788
]
Dawid Wysakowicz commented on AVRO-1891:
Hi,
Just wanted to clarify status of this issue. Was it
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719939#comment-16719939
]
ASF subversion and git services commented on AVRO-1891:
---
Commit
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1671#comment-1671
]
ASF GitHub Bot commented on AVRO-1891:
--
dkulp commented on issue #118: AVRO-1891: Fix specific nested
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717769#comment-16717769
]
ASF GitHub Bot commented on AVRO-1891:
--
dkulp closed pull request #329: Improved conversions handling
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711160#comment-16711160
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #118: AVRO-1891: Fix specific
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711162#comment-16711162
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin edited a comment on issue #118: AVRO-1891: Fix
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16711161#comment-16711161
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin edited a comment on issue #118: AVRO-1891: Fix
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708795#comment-16708795
]
ASF GitHub Bot commented on AVRO-1891:
--
lazyval commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708774#comment-16708774
]
ASF GitHub Bot commented on AVRO-1891:
--
lazyval edited a comment on issue #118: AVRO-1891: Fix
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708767#comment-16708767
]
ASF GitHub Bot commented on AVRO-1891:
--
lazyval commented on issue #118: AVRO-1891: Fix specific
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708769#comment-16708769
]
ASF GitHub Bot commented on AVRO-1891:
--
lazyval edited a comment on issue #118: AVRO-1891: Fix
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695345#comment-16695345
]
ASF GitHub Bot commented on AVRO-1891:
--
lagweasel commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695057#comment-16695057
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694918#comment-16694918
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690946#comment-16690946
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686939#comment-16686939
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686731#comment-16686731
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685896#comment-16685896
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685807#comment-16685807
]
ASF GitHub Bot commented on AVRO-1891:
--
malcolmrobbins commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681216#comment-16681216
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671368#comment-16671368
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16670170#comment-16670170
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663559#comment-16663559
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640695#comment-16640695
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638278#comment-16638278
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva edited a comment on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638277#comment-16638277
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637884#comment-16637884
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637056#comment-16637056
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva edited a comment on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636982#comment-16636982
]
ASF GitHub Bot commented on AVRO-1891:
--
ivangreene commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636742#comment-16636742
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591290#comment-16591290
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590622#comment-16590622
]
ASF GitHub Bot commented on AVRO-1891:
--
ivangreene commented on issue #329: Improved conversions
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588490#comment-16588490
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #118: AVRO-1891: Fix specific
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587834#comment-16587834
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #118: AVRO-1891: Fix specific
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577424#comment-16577424
]
ASF GitHub Bot commented on AVRO-1891:
--
lewisdawson commented on issue #118: AVRO-1891: Fix specific
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527372#comment-16527372
]
Sangram commented on AVRO-1891:
---
Hi [~rdblue],
Do we have an estimate on when this JIRA is going to be
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422543#comment-16422543
]
dongyan li commented on AVRO-1891:
--
If union with logical type is not well supported, please *add a note
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410747#comment-16410747
]
ASF GitHub Bot commented on AVRO-1891:
--
wheelerlaw commented on issue #118: AVRO-1891: Fix specific
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336033#comment-16336033
]
Jess commented on AVRO-1891:
There has been no activity on this ticket for 14 months. Is this PR abandoned?
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189877#comment-16189877
]
Ben Williams commented on AVRO-1891:
Agreed this is a very annoying issue when we cant have "null" for
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150510#comment-16150510
]
Sean Busbey commented on AVRO-1891:
---
Can someone give me a synopsis of current status? do we believe this
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467900#comment-15467900
]
Ryan Blue commented on AVRO-1891:
-
Much the same way, by keeping track of the conversions for the record
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467798#comment-15467798
]
Tom White commented on AVRO-1891:
-
Thanks for posting a patch Ryan. How would it work for the write side?
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466040#comment-15466040
]
Yibing Shi commented on AVRO-1891:
--
The patch looks great, [~rdblue]!
I add a few comments to it.
>
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465679#comment-15465679
]
Ryan Blue commented on AVRO-1891:
-
I've posted a PR with the proposed changes. It still needs tests to
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465673#comment-15465673
]
ASF GitHub Bot commented on AVRO-1891:
--
GitHub user rdblue opened a pull request:
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465252#comment-15465252
]
Tom White commented on AVRO-1891:
-
+1 to determining the conversions for specific at compile time.
>
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463713#comment-15463713
]
Yibing Shi commented on AVRO-1891:
--
[~rdblue], you idea looks good to me!
{quote}
Maintain a thread-local
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15463687#comment-15463687
]
Ryan Blue commented on AVRO-1891:
-
I think all this requires is keeping a set of conversions that should be
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460908#comment-15460908
]
Yibing Shi commented on AVRO-1891:
--
Just found the {{defaultValue}} method I added has a bug. I guess you
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460903#comment-15460903
]
Yibing Shi commented on AVRO-1891:
--
I have another look into the code, and find that we might have to
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460722#comment-15460722
]
Yibing Shi commented on AVRO-1891:
--
{quote}
I don't see the advantage of adding ConversionResolver. We'll
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15460708#comment-15460708
]
Yibing Shi commented on AVRO-1891:
--
{quote}
although this has the effect of creating another class that
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459572#comment-15459572
]
Doug Cutting commented on AVRO-1891:
I don't see the advantage of adding ConversionResolver. We'll be
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15457575#comment-15457575
]
Yibing Shi commented on AVRO-1891:
--
{quote}
When resolveUnion is called there is no SpecificRecordBase
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453755#comment-15453755
]
Yibing Shi commented on AVRO-1891:
--
{quote}
We could do this by adding a constructor to
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15452830#comment-15452830
]
Tom White commented on AVRO-1891:
-
Might it not be simpler to take advantage of the conversion code that's
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411921#comment-15411921
]
Yibing Shi commented on AVRO-1891:
--
[~rdblue], [~busbey], could you please help confirm whether we need
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15411928#comment-15411928
]
Sean Busbey commented on AVRO-1891:
---
yes, we should expect those to work.
> Generated Java code fails
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410947#comment-15410947
]
Yibing Shi commented on AVRO-1891:
--
Things can become even more complicated. AVRO supports
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406302#comment-15406302
]
Ryan Blue commented on AVRO-1891:
-
I'm not sure that is entirely correct. GenericData methods handle most
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405931#comment-15405931
]
Yibing Shi commented on AVRO-1891:
--
Had a quick look at this. The scope of this problem is bigger than I
70 matches
Mail list logo
