Re: Patches requiring review for submission

2015-02-16 Thread S G
Hey Ryan, I would appreciate your help on getting these patches in. Thanks Sachin On Wed, Feb 4, 2015 at 11:25 AM, S G sg.online.em...@gmail.com wrote: I have submitted a modified patch for #3 as well. Please help me review and get these committed. Thanks Sachin On Tue, Feb 3, 2015

Re: Patches requiring review for submission

2015-02-04 Thread S G
I have submitted a modified patch for #3 as well. Please help me review and get these committed. Thanks Sachin On Tue, Feb 3, 2015 at 12:42 PM, S G sg.online.em...@gmail.com wrote: Thanks a lot for the useful comments Ryan. 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical

Re: Patches requiring review for submission

2015-02-03 Thread S G
Thanks a lot for the useful comments Ryan. 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical references) is just ready to be patched in. It has all the suggestions from Doug Cutting and an exhaustive testcase. Doug Cutting, if you can respond to this JIRA ticket, your help would be much

Re: Patches requiring review for submission

2015-02-02 Thread Ryan Blue
On 01/26/2015 11:03 AM, S G wrote: Hi, I have submitted a couple of patches that need some review. 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical references) This looks complicated and has a long history, so I'll try to help out on the other two. 2)

Patches requiring review for submission

2015-01-26 Thread S G
Hi, I have submitted a couple of patches that need some review. 1) https://issues.apache.org/jira/browse/AVRO-695 (Cyclical references) 2) https://issues.apache.org/jira/browse/AVRO-680 (Non-string map keys) 3) https://issues.apache.org/jira/browse/AVRO-1554 (Supporting UUID in Avro) Would