Re: Ruby gem fork - contribute back?

2014-07-02 Thread Sean Busbey
On Wed, Jul 2, 2014 at 4:36 AM, Martin Kleppmann mar...@kleppmann.com wrote: FWIW, Ruby isn't the only language with a tricky setup. I spent ages trying to get the Avro tests for PHP to work, for example. As discussed on another thread [1], I think a Docker container might be a good way of

Re: Ruby gem fork - contribute back?

2014-06-30 Thread Willem van Bergen
I have attached another patch to AVRO-1499 that solves a big unicode encoding problem. Because we are using string.size instead of string.bytesize, we end up writing the number of characters instead of the number of bytes in Ruby 1.9+. I also took the liberty of removing the collect_hash mixin.

Re: Ruby gem fork - contribute back?

2014-06-26 Thread Martin Kleppmann
IMHO it's not a big problem to support many versions of Ruby in a single gem. I would much rather have one gem that works in all widespread versions of Ruby (1.8.7, 1.9.3, 2.0, 2.1) than the complexity of multiple branches or forks. On the whole, Avro should work in modern versions of Ruby; if

Ruby gem fork - contribute back?

2014-06-25 Thread Willem van Bergen
Hi, For a Ruby project, I am using AVRO schemas to validate Ruby objects. Because I ran into some issues with the official avro gem, so I forked it: https://github.com/wvanbergen/tros. (The name probably only makes sense to Dutch people :) ### Changes - Fixed a round trip encoding issue for

Re: Ruby gem fork - contribute back?

2014-06-25 Thread Sean Busbey
how far back did you fork? could we have a Ruby 1.8 gem and a Ruby 1.9+ gem? we have python and python 3 support broken out, for example. On Wed, Jun 25, 2014 at 3:51 AM, Willem van Bergen wil...@vanbergen.org wrote: Hi, For a Ruby project, I am using AVRO schemas to validate Ruby objects.

Re: Ruby gem fork - contribute back?

2014-06-25 Thread Willem van Bergen
I forked off trunk 2 days ago. It's possible to have 2 different gems, but this is not very common in the Ruby world. Because Ruby 1.8 is not maintained anymore, not even for security issues, most people have moved on to newer versions. This is in contrast with Python 2, which is still

Re: Ruby gem fork - contribute back?

2014-06-25 Thread Sean Busbey
IIRC, the multijson issue is fixed in the current snapshot. I dunno, I certainly stopped using Ruby 1.8 several years ago. The issue is that Avro has a strong history of favoring compatibility. It would be surprising for us to drop Ruby 1.8 support while still in the Avro 1.7 line. We could plan

Re: Ruby gem fork - contribute back?

2014-06-25 Thread Willem van Bergen
Dropping support for Ruby 1.8 in the Avro 1.8.x series sounds like a plan. Is there already a branch for the 1.8 series? Until that time happens, I can maintain my fork for people requiring unicode UTF support on Ruby 1.9+. I know the multi_json issue is fixed in trunk. However, due to the

Re: Ruby gem fork - contribute back?

2014-06-25 Thread Sean Busbey
There isn't a branch for 1.8. Patches that target that version just get generated based on trunk and attached to tickets with a fix version of 1.8.0. Generally, they also get hte incompatible flag. Sure, I agree that using the unreleased versions isn't tenable. Doug made a call for a 1.7.7

Re: Ruby gem fork - contribute back?

2014-06-25 Thread Doug Cutting
On Wed, Jun 25, 2014 at 2:16 AM, Willem van Bergen wil...@vanbergen.org wrote: It's possible to have 2 different gems, but this is not very common in the Ruby world. Because Ruby 1.8 is not maintained anymore, not even for security issues, most people have moved on to newer versions. I can

Re: Ruby gem fork - contribute back?

2014-06-25 Thread Sean Busbey
Personally, I'd rather see #2. I think it's very hard to know what the current use of Ruby 1.8 is. Support from the MRI community only ended ~1 year ago[1]. JRuby still supports running in 1.8 mode. They'll be dropping it in their next major release, but there isn't a schedule for that yet and