[GitHub] avro pull request #99: Avro 1856 concat tool append to input

2016-06-01 Thread MikeHurleySurescripts
GitHub user MikeHurleySurescripts opened a pull request: https://github.com/apache/avro/pull/99 Avro 1856 concat tool append to input Let me know if this pull request should be pointed to a different branch. You can merge this pull request into a Git repository by running: $ gi

[jira] [Commented] (AVRO-1461) Distribute Perl API on CPAN

2016-06-01 Thread Burak Gursoy (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310584#comment-15310584 ] Burak Gursoy commented on AVRO-1461: I second that. Building from repos or archives i

[jira] [Commented] (AVRO-1461) Distribute Perl API on CPAN

2016-06-01 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310592#comment-15310592 ] Ryan Blue commented on AVRO-1461: - Sounds good to me. Would someone like to find out what i

[jira] [Commented] (AVRO-1461) Distribute Perl API on CPAN

2016-06-01 Thread Burak Gursoy (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310597#comment-15310597 ] Burak Gursoy commented on AVRO-1461: In addition to the above: you are also missing the

[jira] [Commented] (AVRO-1847) IDL compiler uses ByteBuffer for decimal type even if logical type is supported

2016-06-01 Thread Ryan Blue (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310618#comment-15310618 ] Ryan Blue commented on AVRO-1847: - Sorry, I haven't had time for an in-depth review of this

Re: Need review/merges for couple of pull requests

2016-06-01 Thread S G
Hey RB, I was trying out the circular refs with latest 1.8.1 version of Avro and it doesn't seem to be working out of the box for me. Perhaps I am missing something and would appreciate your help. Thanks, SG Here is my test code: public class CircularRefsTest { @Test public void testSe

Re: Need review/merges for couple of pull requests

2016-06-01 Thread Ryan Blue
SG, The example/test I built uses logical types to remove the circular reference when writing and restore it when reading. It doesn't look like your test adds logical types, so that's probably the issue. rb On Wed, Jun 1, 2016 at 1:51 PM, S G wrote: > Hey RB, > > I was trying out the circular

[jira] [Commented] (AVRO-1847) IDL compiler uses ByteBuffer for decimal type even if logical type is supported

2016-06-01 Thread Yibing Shi (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311336#comment-15311336 ] Yibing Shi commented on AVRO-1847: -- Understood! Thanks for the response! > IDL compiler u

Re: Need review/merges for couple of pull requests

2016-06-01 Thread S G
RB, The test TestCircularReferences shows that the classes having circular reference need to extend LogicalType. If every circular reference class has to do this, then I think this would be a big limitation for actual classes used in production code because they would be already extending other cl

Re: Need review/merges for couple of pull requests

2016-06-01 Thread Ryan Blue
Those aren't the datum classes, those are logical types that are added to the schema for your datum classes. The "referenceable" logical type is applied to the class that gets replaced with an ID reference and points to the field to use for that ID. The "reference" logical type is applied to the cl

Re: Need review/merges for couple of pull requests

2016-06-01 Thread S G
Thanks RB, But I am not sure I follow that example (Probably because there is no actual datum class there?). Consider a complex code running in production with lots of circular references. Something like: class Home { String address; Integer zipCode; List residents; } class Person {