[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329494#comment-15329494
]
Yibing Shi commented on AVRO-1847:
--
The {{conver}} method is newly added by this patch. It didn't exist in
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329495#comment-15329495
]
Yibing Shi commented on AVRO-1847:
--
I have removed the passthrough behaviour in convert to/from methods.
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328665#comment-15328665
]
Yibing Shi edited comment on AVRO-1847 at 6/14/16 1:18 PM:
---
Agree. Since these 2
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329501#comment-15329501
]
Yibing Shi commented on AVRO-1847:
--
Since we always try to use Joda or Java classes for date/time types, I
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329515#comment-15329515
]
Yibing Shi commented on AVRO-1847:
--
Oops! Have corrected it.
> IDL compiler uses ByteBuffer for decimal
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329521#comment-15329521
]
Yibing Shi commented on AVRO-1847:
--
As mentioned above, I don't think we need a separate flag for
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329511#comment-15329511
]
Yibing Shi commented on AVRO-1847:
--
I didn't think of childrens of this class may need to check its return
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329522#comment-15329522
]
Yibing Shi commented on AVRO-1847:
--
Same as above
> IDL compiler uses ByteBuffer for decimal type even if
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329647#comment-15329647
]
Sean Busbey commented on AVRO-1847:
---
{code}
+ public static Object convertToLogicalType(Object datum,
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yibing Shi updated AVRO-1847:
-
Attachment: AVRO-1847.5.patch
Upload the new patch that contains all the changes based on code review.
>
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329708#comment-15329708
]
Ryan Blue commented on AVRO-1847:
-
I think there should also be a test for this to make sure logical types
Matthieu,
Thanks for the example.
First, is this really an alias, or is it something else? In other
words, would a reader ever map a written Vehicle to a Bus? If the use
cases are exclusive, perhaps we should call it something different
rather than overload the alias concept?
Second, would
[
https://issues.apache.org/jira/browse/AVRO-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330700#comment-15330700
]
Ryan Blue commented on AVRO-1847:
-
I think this logic should just apply the conversions if they are
13 matches
Mail list logo
