[jira] [Commented] (AVRO-2106) Revisit dependencies on Jetty, servlet-api, and Netty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257233#comment-16257233
 ] 

ASF GitHub Bot commented on AVRO-2106:
--

GitHub user dkulp opened a pull request:

https://github.com/apache/avro/pull/259

[AVRO-2106] Start splitting jetty/netty out of avro-ipc

This is not ready to be merged, but wanted to prototype this to start a 
discussion to see if this is the right track.

Basically, I pulled the jetty/netty stuff out of avro-ipc into 
implementation specific avro-ipc-jetty and avro-ipc-netty modules.   Thus, the 
stuff remaining in avro-ipc is more "generic" and doesn't rely on either of the 
implementations.

To avoid the "split package" issue, I had to move them to separate 
packages.   That's an incompatibility, but hopefully not major.However, I 
updated the Ipc.java to (reflectively) create the appropriate server that it 
can find.   I'm slowly updating the rest of the projects to use 
Ipc.createServer instead of "new HttpServer" or "new NettyServer" which then 
allows selection of the impl based on which dependency is found.   

Anyway almost all the tests are duplicated in all three modules now (that 
needs to be cleaned up) and I'm still working on downstream modules to flip to 
using the Ipc.createServer stuff, but I wanted to start a discussion before 
going too far with it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dkulp/avro AVRO-2106

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #259


commit 6123bc0242a831af1d8fe878592b6e97eb9c2b39
Author: Daniel Kulp 
Date:   2017-11-17T16:59:25Z

[AVRO-2106] Start splitting jetty/netty out of avro-ipc




> Revisit dependencies on Jetty, servlet-api, and Netty
> -
>
> Key: AVRO-2106
> URL: https://issues.apache.org/jira/browse/AVRO-2106
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2, 1.8.0
>Reporter: Nandor Kollar
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] avro pull request #259: [AVRO-2106] Start splitting jetty/netty out of avro-...

[dkulp]

GitHub user dkulp opened a pull request:

https://github.com/apache/avro/pull/259

[AVRO-2106] Start splitting jetty/netty out of avro-ipc

This is not ready to be merged, but wanted to prototype this to start a 
discussion to see if this is the right track.

Basically, I pulled the jetty/netty stuff out of avro-ipc into 
implementation specific avro-ipc-jetty and avro-ipc-netty modules.   Thus, the 
stuff remaining in avro-ipc is more "generic" and doesn't rely on either of the 
implementations.

To avoid the "split package" issue, I had to move them to separate 
packages.   That's an incompatibility, but hopefully not major.However, I 
updated the Ipc.java to (reflectively) create the appropriate server that it 
can find.   I'm slowly updating the rest of the projects to use 
Ipc.createServer instead of "new HttpServer" or "new NettyServer" which then 
allows selection of the impl based on which dependency is found.   

Anyway almost all the tests are duplicated in all three modules now (that 
needs to be cleaned up) and I'm still working on downstream modules to flip to 
using the Ipc.createServer stuff, but I wanted to start a discussion before 
going too far with it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dkulp/avro AVRO-2106

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #259


commit 6123bc0242a831af1d8fe878592b6e97eb9c2b39
Author: Daniel Kulp 
Date:   2017-11-17T16:59:25Z

[AVRO-2106] Start splitting jetty/netty out of avro-ipc




---

[jira] [Commented] (AVRO-1213) Update to latest release of Jetty

[Nandor Kollar (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256740#comment-16256740
 ] 

Nandor Kollar commented on AVRO-1213:
-

Actually the PR just updates the Jetty version, doesn't address the other 
(breaking up IPC module into Jetty and Netty sub-modules). Created AVRO-2106 
for this.

> Update to latest release of Jetty
> -
>
> Key: AVRO-1213
> URL: https://issues.apache.org/jira/browse/AVRO-1213
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2
>Reporter: Sharmarke Aden
>Assignee: Daniel Kulp
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (AVRO-2106) Revisit dependencies on Jetty, servlet-api, and Netty

[Nandor Kollar (JIRA)]

Nandor Kollar created AVRO-2106:
---

 Summary: Revisit dependencies on Jetty, servlet-api, and Netty
 Key: AVRO-2106
 URL: https://issues.apache.org/jira/browse/AVRO-2106
 Project: Avro
  Issue Type: Improvement
  Components: java
Affects Versions: 1.8.0, 1.7.2
Reporter: Nandor Kollar


The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
problematic if using Avro in a webapp environment. Would it be possible to make 
this dependency either optional or provided? Or maybe Avro modularize into 
sub-modules in such a way that desired features can be assembled piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-1213) Update to latest release of Jetty

[Nandor Kollar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nandor Kollar updated AVRO-1213:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Update to latest release of Jetty
> -
>
> Key: AVRO-1213
> URL: https://issues.apache.org/jira/browse/AVRO-1213
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2
>Reporter: Sharmarke Aden
>Assignee: Daniel Kulp
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1213) Update to latest release of Jetty

[Nandor Kollar (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256724#comment-16256724
 ] 

Nandor Kollar commented on AVRO-1213:
-

Committed to trunk, thanks Daniel for fixing this!

> Update to latest release of Jetty
> -
>
> Key: AVRO-1213
> URL: https://issues.apache.org/jira/browse/AVRO-1213
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2
>Reporter: Sharmarke Aden
>Assignee: Daniel Kulp
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (AVRO-1213) Update to latest release of Jetty

[Nandor Kollar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nandor Kollar updated AVRO-1213:

Hadoop Flags: Incompatible change
Release Note: Jetty version was updated from 2.5-20081211 to 
9.4.6.v20170531. This is a breaking change due to package name change in Jetty, 
which leads to interface change in Avro. The type of constructor parameters in 
HttpServer.java changed.

> Update to latest release of Jetty
> -
>
> Key: AVRO-1213
> URL: https://issues.apache.org/jira/browse/AVRO-1213
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2
>Reporter: Sharmarke Aden
>Assignee: Daniel Kulp
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] avro pull request #244: [AVRO-1213] Update to latest release of Jetty

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/244


---

[jira] [Commented] (AVRO-1213) Update to latest release of Jetty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256696#comment-16256696
 ] 

ASF GitHub Bot commented on AVRO-1213:
--

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/244


> Update to latest release of Jetty
> -
>
> Key: AVRO-1213
> URL: https://issues.apache.org/jira/browse/AVRO-1213
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2
>Reporter: Sharmarke Aden
>Assignee: Daniel Kulp
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (AVRO-1213) Update to latest release of Jetty

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256695#comment-16256695
 ] 

ASF subversion and git services commented on AVRO-1213:
---

Commit 3af404efb31a1dc2fd720384ef9a3f7326c2d303 in avro's branch 
refs/heads/master from [~dkulp]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=3af404e ]

AVRO-1213 Update to latest release of Jetty

Closes #244

Signed-off-by: sacharya 
Signed-off-by: Nandor Kollar 
Signed-off-by: Anna Szonyi 


> Update to latest release of Jetty
> -
>
> Key: AVRO-1213
> URL: https://issues.apache.org/jira/browse/AVRO-1213
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2
>Reporter: Sharmarke Aden
>Assignee: Daniel Kulp
>Priority: Blocker
> Fix For: 1.9.0
>
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)