[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16628173#comment-16628173
]
ASF GitHub Bot commented on AVRO-2145:
--
Fokko opened a new pull request #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334
From Java 8 on the JavaDoc is being linted and it will fail early if there
are issues with the JavaDoc: http://openjdk.java.net/jeps/172
This patch will add the missing Javadoc with some stubs. Additionally I
updated the docs of some of the public API by hand to make the Javadoc more
verbose.
The JavaDoc needs to be updated in the future, but this commit will let the
compiler pass the javadoc check step.
Tested locally and it passes the tests. This patch only changes the Javadoc
and does not change the logic of the code.
Cheers, Fokko
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test and release using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627680#comment-16627680 ] Doug Cutting commented on AVRO-2229: Note that the code for this already exists in share/docker/Dockerfile, driven from the top-level build.sh script using its 'docker' command. However the list of dependencies in the Dockerfile may be out date, and some of the builds may be broken. Related, we should probably alter the top-level BUILD to, instead of listing dependencies, refer to the dependencies in the Dockerfile, so that we maintain these in a single place. > Ability to test and release using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Revive Avro?
Sure makes sense, I'll pick this up. Created a Jira: https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2229 Op ma 24 sep. 2018 om 14:38 schreef Doug Cutting : > Getting pre-commit builds working would be very welcome. Updating the > docker-based build to do this would be doubly good, as it would mean that > any developer could then easily make a release. Right now one has to > install all the requirements for every language to make a release. These > dependencies are supposedly documented in the BUILD.txt file, but that file > is now out of date. Having the build dependencies tested with each PR > should help us keep them up to date so that we can release more easily and > often. > > Thanks, > > Doug > > On Mon, Sep 24, 2018 at 10:14 AM Driesprong, Fokko > wrote: > > > Hi all, > > > > Let me cut right to the chase, the lack of activity on the Apache Avro > > master makes me a bit sad. I believe Avro is a format that many people > > happly use, and will be used in the future (at least I hope). > > > > Therefore we need: > > > >- *Continue the development of features:* For example, I'd like to see > >the following PR merged, and since Joda has been deprecated a long > while > >ago: https://github.com/apache/avro/pull/309 > >- *Update the dependencies:* Within the codebase there are quite some > >known CVE's. It is aways a race to keep up to date, but we should in > > order > >to stay secure. For example, The Apache Velocity template engine is > old, > >and pulls in an old version of apache-commons which has known security > >problems, eg. CVE-2015-6420, CVE-2017-15708. I've created a PR for > this: > >https://github.com/apache/avro/pull/332 > >- *Automate stuff: *I'm happy to set up a Travis to run some CI tasks > >for each PR. This relieves on the committers since they don't have to > > run > >the testsuite every time a small change is introduced. Let me know if > > this > >sounds interesting, and I'm happy to set it up. > > > > Looking at the PR's and tickets, a lot of people are putting effort in > > making PR's and adding features to Avro. It is a pity that the Avro > project > > seems to stall. I'm happy to help if that is necessary to start the > > development cycle again. > > > > Cheers, Fokko > > >
[jira] [Commented] (AVRO-2079) Add ability to use Java 8 date/time types instead of Joda time.
[
https://issues.apache.org/jira/browse/AVRO-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627475#comment-16627475
]
ASF GitHub Bot commented on AVRO-2079:
--
pvorb commented on issue #309: AVRO-2079: Add ability to generate Java8 native
date/time classes (new)
URL: https://github.com/apache/avro/pull/309#issuecomment-424380475
@nandorKollar I changed the code according to your requests. Good spot about
overriding the `getRecommendedSchema()` methods in each conversion!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add ability to use Java 8 date/time types instead of Joda time.
> ---
>
> Key: AVRO-2079
> URL: https://issues.apache.org/jira/browse/AVRO-2079
> Project: Avro
> Issue Type: Improvement
> Components: java, logical types
>Affects Versions: 1.8.2
>Reporter: Auke van Leeuwen
>Priority: Major
> Labels: patch-available
>
> Currently, for the date/time related logical types, we are generating Joda
> date/time objects. Since we've moved to Java-8 (AVRO-2043) it seems logical
> to also provide the possibility to generate {{java.time.*}} date/time objects
> instead of the Joda time variants.
> I propose to make this is a switch in {{SpecificCompiler.java}} which will
> default to Joda (I think), but can be set to generate the Java 8 versions.
> (I'm currently trying to run through the code to see if I can make it work.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2079) Add ability to use Java 8 date/time types instead of Joda time.
[
https://issues.apache.org/jira/browse/AVRO-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627424#comment-16627424
]
ASF GitHub Bot commented on AVRO-2079:
--
nandorKollar commented on a change in pull request #309: AVRO-2079: Add ability
to generate Java8 native date/time classes (new)
URL: https://github.com/apache/avro/pull/309#discussion_r220208975
##
File path:
lang/java/compiler/src/main/java/org/apache/avro/compiler/specific/SpecificCompiler.java
##
@@ -153,16 +174,38 @@ public SpecificCompiler(Protocol protocol) {
}
public SpecificCompiler(Schema schema) {
-this();
+this(schema, DateTimeLogicalTypeImplementation.JODA);
+ }
+
+ public SpecificCompiler(Schema schema, DateTimeLogicalTypeImplementation
dateTimeLogicalTypeImplementation) {
+this(dateTimeLogicalTypeImplementation);
enqueue(schema);
this.protocol = null;
}
+ /**
+ * Creates a specific compler with the default (Joda) type for date/time
related logical types.
Review comment:
nit: compler -> compiler
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add ability to use Java 8 date/time types instead of Joda time.
> ---
>
> Key: AVRO-2079
> URL: https://issues.apache.org/jira/browse/AVRO-2079
> Project: Avro
> Issue Type: Improvement
> Components: java, logical types
>Affects Versions: 1.8.2
>Reporter: Auke van Leeuwen
>Priority: Major
> Labels: patch-available
>
> Currently, for the date/time related logical types, we are generating Joda
> date/time objects. Since we've moved to Java-8 (AVRO-2043) it seems logical
> to also provide the possibility to generate {{java.time.*}} date/time objects
> instead of the Joda time variants.
> I propose to make this is a switch in {{SpecificCompiler.java}} which will
> default to Joda (I think), but can be set to generate the Java 8 versions.
> (I'm currently trying to run through the code to see if I can make it work.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2079) Add ability to use Java 8 date/time types instead of Joda time.
[
https://issues.apache.org/jira/browse/AVRO-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16627422#comment-16627422
]
ASF GitHub Bot commented on AVRO-2079:
--
nandorKollar commented on a change in pull request #309: AVRO-2079: Add ability
to generate Java8 native date/time classes (new)
URL: https://github.com/apache/avro/pull/309#discussion_r220208860
##
File path:
lang/java/avro/src/main/java/org/apache/avro/data/Jsr310TimeConversions.java
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.avro.data;
+
+import org.apache.avro.Conversion;
+import org.apache.avro.LogicalType;
+import org.apache.avro.Schema;
+
+import java.time.Instant;
+import java.time.LocalDate;
+import java.time.LocalTime;
+import java.util.concurrent.TimeUnit;
+
+public class Jsr310TimeConversions {
Review comment:
It would be nice to override getRecommendedSchema methods for each
conversion similar as in the Joda time conversion class (TimeConversions)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add ability to use Java 8 date/time types instead of Joda time.
> ---
>
> Key: AVRO-2079
> URL: https://issues.apache.org/jira/browse/AVRO-2079
> Project: Avro
> Issue Type: Improvement
> Components: java, logical types
>Affects Versions: 1.8.2
>Reporter: Auke van Leeuwen
>Priority: Major
> Labels: patch-available
>
> Currently, for the date/time related logical types, we are generating Joda
> date/time objects. Since we've moved to Java-8 (AVRO-2043) it seems logical
> to also provide the possibility to generate {{java.time.*}} date/time objects
> instead of the Joda time variants.
> I propose to make this is a switch in {{SpecificCompiler.java}} which will
> default to Joda (I think), but can be set to generate the Java 8 versions.
> (I'm currently trying to run through the code to see if I can make it work.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (AVRO-2229) Ability to test and release using a Docker image
Fokko Driesprong created AVRO-2229: -- Summary: Ability to test and release using a Docker image Key: AVRO-2229 URL: https://issues.apache.org/jira/browse/AVRO-2229 Project: Avro Issue Type: Improvement Affects Versions: 1.8.2 Reporter: Fokko Driesprong -- This message was sent by Atlassian JIRA (v7.6.3#76005)
