[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640538#comment-16640538
]
ASF GitHub Bot commented on AVRO-2145:
--
Fokko commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427543093
Ok, I'll create a new PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640343#comment-16640343 ] ASF GitHub Bot commented on AVRO-2229: -- cutting commented on issue #343: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/343#issuecomment-427498739 We can merge this in under AVRO-2229, but it might also be a separate issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640296#comment-16640296
]
ASF GitHub Bot commented on AVRO-2229:
--
kojiromike commented on a change in pull request #343: [AVRO-2229] Test using a
Docker image
URL: https://github.com/apache/avro/pull/343#discussion_r223125939
##
File path: lang/java/avro/build.sh
##
@@ -15,24 +15,30 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-headline(){
- echo -e
"\e[1;34m#"
- echo -e "# $1 \e[1;37m"
- echo -e
"\e[1;34m#\e[0m"
+set -e # exit on error
+
+function usage {
+ echo "Usage: $0 {test|clean|interop-data-generate|interop-data-test}"
+ exit 1
}
-set -e
+case "$target" in
+ test)
+mvn -B test
+;;
+
+ clean)
+mvn clean
+;;
-for lang in /avro/lang/*/
-do
- headline "Run tests: $lang"
- cd "$lang"
+ interop-data-test)
+mvn clean
+;;
+
+ *)
+usage
+esac
- if [[ "$lang" = *"c++"* ]]; then
-# The current cpp tests are failing:
-# https://issues.apache.org/jira/projects/AVRO/issues/AVRO-2230
-./build.sh test || true
- else
-./build.sh test
- fi
done
+
+exit 0
Review comment:
This exit statement isn't necessary.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ability to test using a Docker image
>
>
> Key: AVRO-2229
> URL: https://issues.apache.org/jira/browse/AVRO-2229
> Project: Avro
> Issue Type: Improvement
>Affects Versions: 1.8.2
>Reporter: Fokko Driesprong
>Assignee: Fokko Driesprong
>Priority: Major
> Fix For: 1.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640052#comment-16640052
]
ASF GitHub Bot commented on AVRO-2145:
--
nandorKollar edited a comment on issue #334: [AVRO-2145] Cannot create Javadoc
on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427423523
I think in some cases it would make sense to fix the Javadoc, but adding
obvious comments only for DocLint doesn't give too much value. For example (at
least in my opinion) we should keep changes like
[this](https://github.com/apache/avro/pull/334/files#diff-8c641f2365208209cae8dd63a6d186f7R35),
but changes only related to the comment style like
[this](https://github.com/apache/avro/pull/334/files#diff-6e7994042bf667704678c9395ace00bcL103)
don't give too much value.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640050#comment-16640050
]
ASF GitHub Bot commented on AVRO-2145:
--
nandorKollar commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427423523
I think in some cases it would make sense to fix the Javadoc, but adding
obvious comments only for DocLint doesn't give too much value. For example (at
least in my opinion) we should keep changes like
[this](https://github.com/apache/avro/pull/334/files#diff-8c641f2365208209cae8dd63a6d186f7L35),
but changes only related to the comment style like
[this](https://github.com/apache/avro/pull/334/files#diff-6e7994042bf667704678c9395ace00bcL103)
don't give too much value.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640036#comment-16640036
]
ASF GitHub Bot commented on AVRO-2145:
--
Fokko commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427421219
Currently it breaks the `dist` step.
Personally I would prefer to add the JavaDoc. But if the majority prefers to
turn it off, I'm fine with it as well. Beside the missing JavaDoc, I've also
corrected a lot of the invalid JavaDoc in this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640028#comment-16640028 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427420247 Thanks for merging @cutting. I was still working on the PR, should have put a `[WIP]` in the title. I have a follow up PR here: https://github.com/apache/avro/pull/343 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640025#comment-16640025 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko opened a new pull request #343: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/343 Follow up PR of https://github.com/apache/avro/pull/336 Integrate the testing with the Docker image with the existing build.sh. @cutting @kojiromike This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640026#comment-16640026
]
ASF GitHub Bot commented on AVRO-2145:
--
nandorKollar commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427420122
In this case I'd recommend simply turning off DocLint. I remember we did
similar things on Parquet,
[here's](https://github.com/apache/parquet-format/commit/28ead3fd157842247ac71c5ec1fac94f1ff83ec4)
how it was turned off there.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Doug Cutting resolved AVRO-2229. Resolution: Fixed Assignee: Fokko Driesprong I committed this. Thanks, Fokko! > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2145) Can't generate Javadoc on master
[
https://issues.apache.org/jira/browse/AVRO-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1664#comment-1664
]
ASF GitHub Bot commented on AVRO-2145:
--
cutting commented on issue #334: [AVRO-2145] Cannot create Javadoc on JDK8+
URL: https://github.com/apache/avro/pull/334#issuecomment-427416331
I'm not fond of whitespace changes. Are all of these really required to
pass JavaDoc lint? In particular, a lot of existing Javadoc comments have
content on the first line. When these are moved to a new line it causes the
rest of the comment to be re-indented. I'd prefer we don't make that style
change here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Can't generate Javadoc on master
>
>
> Key: AVRO-2145
> URL: https://issues.apache.org/jira/browse/AVRO-2145
> Project: Avro
> Issue Type: Bug
>Affects Versions: 1.9.0
>Reporter: Nandor Kollar
>Priority: Major
>
> {{mvn javadoc:aggregate}} fails with a bunch of Javadoc warnings on master
> when building with JDK8.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639980#comment-16639980 ] ASF subversion and git services commented on AVRO-2229: --- Commit a11bd49e86d50f5a840ab2cdfe4f6927bedb4f93 in avro's branch refs/heads/master from [~Fokko] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=a11bd49 ] [AVRO-2229] Test using a Docker image (#336) * [AVRO-2229] Fix the docker-based build/test. > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639979#comment-16639979 ] ASF subversion and git services commented on AVRO-2229: --- Commit a11bd49e86d50f5a840ab2cdfe4f6927bedb4f93 in avro's branch refs/heads/master from [~Fokko] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=a11bd49 ] [AVRO-2229] Test using a Docker image (#336) * [AVRO-2229] Fix the docker-based build/test. > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[
https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639978#comment-16639978
]
ASF GitHub Bot commented on AVRO-2229:
--
cutting closed pull request #336: [AVRO-2229] Test using a Docker image
URL: https://github.com/apache/avro/pull/336
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/BUILD.txt b/BUILD.md
similarity index 67%
rename from BUILD.txt
rename to BUILD.md
index 223bc4d04..882338aee 100644
--- a/BUILD.txt
+++ b/BUILD.md
@@ -1,6 +1,6 @@
-Apache Avro Build Instructions
+# Apache Avro Build Instructions
-REQUIREMENTS
+## Requirements
The following packages must be installed before Avro can be built:
@@ -18,13 +18,18 @@ The following packages must be installed before Avro can be
built:
IO::String, Object::Tiny, Compress::ZLib, Test::More,
Test::Exception, Test::Pod
- Apache Ant 1.7
- - Apache Forrest 0.8 (for documentation)
+ - Apache Forrest 0.9 (for documentation)
- md5sum, sha1sum, used by top-level dist target
To simplify this, you can run a Docker container with all the above
-dependencies installed by installing docker.io and typing:
+dependencies installed by installing Docker and run:
- ./build.sh docker
+```bash
+./build.sh docker
+docker@539f6535c9db:~/avro$ cd lang/java/
+docker@539f6535c9db:~/avro/lang/java$ ./build.sh test
+[INFO] Scanning for projects...
+```
When this completes you will be in a shell running in the
container. Building the image the first time may take a while (20
@@ -36,11 +41,22 @@ The working directory in the container is mounted from your
host. This
allows you to access the files in your Avro development tree from the
Docker container.
-BUILDING
+## Building
Once the requirements are installed (or from the Docker container),
build.sh can be used as follows:
- './build.sh test' runs tests for all languages
- './build.sh dist' creates all release distribution files in dist/
- './build.sh clean' removes all generated artifacts
+```
+./build.sh test # runs tests for all languages
+./build.sh dist # creates all release distribution files in dist/
+./build.sh clean # removes all generated artifacts
+```
+
+## Testing
+
+Testing is done with the same Docker container as mentioned in the building
+step. The difference is that it will do clean run of the full test suite:
+
+```bash
+./build.sh docker-test
+```
diff --git a/build.sh b/build.sh
index 255e46af7..8810d6bfa 100755
--- a/build.sh
+++ b/build.sh
@@ -22,7 +22,7 @@ cd `dirname "$0"` # connect to root
VERSION=`cat share/VERSION.txt`
function usage {
- echo "Usage: $0 {test|dist|sign|clean|docker|rat|githooks}"
+ echo "Usage: $0 {test|dist|sign|clean|docker|rat|githooks|docker-test}"
exit 1
}
@@ -197,7 +197,7 @@ do
;;
docker)
- docker build -t avro-build share/docker
+ docker build -t avro-build -f share/docker/Dockerfile .
if [ "$(uname -s)" == "Linux" ]; then
USER_NAME=${SUDO_USER:=$USER}
USER_ID=$(id -u $USER_NAME)
@@ -217,13 +217,13 @@ UserSpecificDocker
# within the container and use the result on your normal
# system. And this also is a significant speedup in subsequent
# builds because the dependencies are downloaded only once.
- docker run --rm=true -t -i \
+ docker run --rm -t -i \
-v ${PWD}:/home/${USER_NAME}/avro \
-w /home/${USER_NAME}/avro \
-v ${HOME}/.m2:/home/${USER_NAME}/.m2 \
-v ${HOME}/.gnupg:/home/${USER_NAME}/.gnupg \
-u ${USER_NAME} \
-avro-build-${USER_NAME}
+avro-build-${USER_NAME} bash
;;
rat)
@@ -236,6 +236,11 @@ UserSpecificDocker
find .git/hooks/ -type f | fgrep -v sample | xargs chmod 755
;;
+docker-test)
+ docker build -t avro-test -f share/docker/Dockerfile .
+ docker run --rm -v ${PWD}:/avro/ avro-test
+ ;;
+
*)
usage
;;
diff --git a/lang/csharp/src/apache/codegen/app.config
b/lang/csharp/src/apache/codegen/app.config
index ae2479060..e8a42543c 100755
--- a/lang/csharp/src/apache/codegen/app.config
+++ b/lang/csharp/src/apache/codegen/app.config
@@ -15,5 +15,8 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-
-
+
+
+
+
+
diff --git a/lang/csharp/src/apache/perf/app.config
b/lang/csharp/src/apache/perf/app.config
index ae2479060..e8a42543c 100755
--- a/lang/csharp/src/apache/perf/app.config
+++ b/lang/csharp/src/apache/perf/app.config
@@ -15,5 +15,8 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
-
-
+
+
+
+
+
diff --git
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639967#comment-16639967 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427409728 I've created a ticket for fixing the interop tests: https://issues.apache.org/jira/browse/AVRO-2239 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AVRO-2239) Fix interop tests
Fokko Driesprong created AVRO-2239: -- Summary: Fix interop tests Key: AVRO-2239 URL: https://issues.apache.org/jira/browse/AVRO-2239 Project: Avro Issue Type: Improvement Reporter: Fokko Driesprong Currently the interop tests are failing: /avro/lang/ruby/lib/avro/schema_validator.rb:127:in `validate_map': undefined method `keys' for nil:NilClass (NoMethodError) from /avro/lang/ruby/lib/avro/schema_validator.rb:103:in `validate_recursive' from /avro/lang/ruby/lib/avro/schema_validator.rb:156:in `block in validate_possible_types' from /avro/lang/ruby/lib/avro/schema_validator.rb:154:in `map' from /avro/lang/ruby/lib/avro/schema_validator.rb:154:in `validate_possible_types' from /avro/lang/ruby/lib/avro/schema_validator.rb:141:in `validate_union' from /avro/lang/ruby/lib/avro/schema_validator.rb:105:in `validate_recursive' from /avro/lang/ruby/lib/avro/schema_validator.rb:110:in `block in validate_recursive' from /avro/lang/ruby/lib/avro/schema_validator.rb:108:in `each' from /avro/lang/ruby/lib/avro/schema_validator.rb:108:in `validate_recursive' from /avro/lang/ruby/lib/avro/schema_validator.rb:67:in `validate!' from /avro/lang/ruby/lib/avro/schema.rb:97:in `validate' from /avro/lang/ruby/lib/avro/io.rb:503:in `write_data' from /avro/lang/ruby/lib/avro/io.rb:499:in `write' from /avro/lang/ruby/lib/avro/ipc.rb:136:in `write_handshake_request' from /avro/lang/ruby/lib/avro/ipc.rb:105:in `request' from lang/ruby/test/tool.rb:69:in `send_message' from lang/ruby/test/tool.rb:137:in `main' from lang/ruby/test/tool.rb:143:in `' -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2186) avro::Exception string gives the incorrect message
[
https://issues.apache.org/jira/browse/AVRO-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639704#comment-16639704
]
ASF subversion and git services commented on AVRO-2186:
---
Commit 6b6ddfeb920f901d851ca12c6be3476ca00a58a9 in avro's branch
refs/heads/master from Thiruvalluvan M G
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=6b6ddfe ]
Merge pull request #340 from apache/AVRO-2186-wrong-error-message
Fixed error message in validating encoder/decoder and resolving decoder
> avro::Exception string gives the incorrect message
> --
>
> Key: AVRO-2186
> URL: https://issues.apache.org/jira/browse/AVRO-2186
> Project: Avro
> Issue Type: Bug
> Components: c++
>Affects Versions: 1.8.2
> Environment: {code:java}
> Linux bream 2.6.39-200.24.1.el6uek.x86_64 #1 SMP Sat Jun 23 02:39:07 EDT 2012
> x86_64 x86_64 x86_64 GNU/Linux
> {code}
>
>Reporter: Anubhav Siddharth
>Assignee: Thiruvalluvan M. G.
>Priority: Critical
>
> When a field specified in schema is missing and we call avro::encode on the
> data. It throws an exception, which is as expected. But the issue is with the
> error message. It comes the other way round.
> Schema:
> {code:java}
> {
> "type" : "record",
> "name" : "userInfo",
> "fields" : [
> { "name" : "id", "type" : "int"},
> { "name" : "fullName", "type" : "string" }
> ]
> }
> {code}
> The generic datum to be encoded has no "id" provided. There is an empty
> GenericDatum for that field. Here is the excetion that is thrown:
> {code:java}
> avro::Exception caught: Invalid operation. Expected: Null got Int{code}
> The exception message should have been
> avro::Exception caught: Invalid operation. Expected: {color:#FF}*Int got
> Null*{color}
>
> {color:#33}Please let us know if you need more information on this.{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AVRO-2186) avro::Exception string gives the incorrect message
[
https://issues.apache.org/jira/browse/AVRO-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. updated AVRO-2186:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Merged the pull request
> avro::Exception string gives the incorrect message
> --
>
> Key: AVRO-2186
> URL: https://issues.apache.org/jira/browse/AVRO-2186
> Project: Avro
> Issue Type: Bug
> Components: c++
>Affects Versions: 1.8.2
> Environment: {code:java}
> Linux bream 2.6.39-200.24.1.el6uek.x86_64 #1 SMP Sat Jun 23 02:39:07 EDT 2012
> x86_64 x86_64 x86_64 GNU/Linux
> {code}
>
>Reporter: Anubhav Siddharth
>Assignee: Thiruvalluvan M. G.
>Priority: Critical
>
> When a field specified in schema is missing and we call avro::encode on the
> data. It throws an exception, which is as expected. But the issue is with the
> error message. It comes the other way round.
> Schema:
> {code:java}
> {
> "type" : "record",
> "name" : "userInfo",
> "fields" : [
> { "name" : "id", "type" : "int"},
> { "name" : "fullName", "type" : "string" }
> ]
> }
> {code}
> The generic datum to be encoded has no "id" provided. There is an empty
> GenericDatum for that field. Here is the excetion that is thrown:
> {code:java}
> avro::Exception caught: Invalid operation. Expected: Null got Int{code}
> The exception message should have been
> avro::Exception caught: Invalid operation. Expected: {color:#FF}*Int got
> Null*{color}
>
> {color:#33}Please let us know if you need more information on this.{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
