[jira] [Commented] (AVRO-1340) use default to allow old readers to specify default enum value when encountering new enum symbols

2017-09-01 Thread Zoltan Farkas (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151176#comment-16151176 ] Zoltan Farkas commented on AVRO-1340: - [~cutting] There is

Re: Avro schema resolution

2017-09-01 Thread Doug Cutting
This seems like a bug in the Java implementation, not a mistake in the spec. Int->float promotion is supported elsewhere and, while lossy, has always been in the spec. There are other lossy promotions (e.g., long->float) and dropping missing record fields is lossy, so lossiness alone doesn't

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Nandor Kollar (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150660#comment-16150660 ] Nandor Kollar commented on AVRO-2069: - Perfect, looks good, tests are green again, thanks! > Use

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Daniil Gitelson (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150652#comment-16150652 ] Daniil Gitelson commented on AVRO-2069: --- [~nkollar], fixed. > Use primitive fields in generated

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Nandor Kollar (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150636#comment-16150636 ] Nandor Kollar commented on AVRO-2069: - Ahhh, yes you're right, my bad, sorry for that! :) > Use

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Daniil Gitelson (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150594#comment-16150594 ] Daniil Gitelson commented on AVRO-2069: --- [~nkollar], it is because recently you updated from legacy

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Nandor Kollar (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150565#comment-16150565 ] Nandor Kollar commented on AVRO-2069: - [~dguitelson] looks like we still have test failures,

[jira] [Commented] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-09-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150549#comment-16150549 ] Sean Busbey commented on AVRO-2066: --- thanks for the contribution! In the future, please generate your

[jira] [Updated] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-09-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated AVRO-2066: -- Resolution: Fixed Fix Version/s: 1.8.3 1.9.0 Status: Resolved (was:

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150545#comment-16150545 ] Sean Busbey commented on AVRO-2069: --- excellent find Anna! I'll go read back through those discussions. >

[jira] [Commented] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-09-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150547#comment-16150547 ] ASF subversion and git services commented on AVRO-2066: --- Commit

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Anna Szonyi (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150536#comment-16150536 ] Anna Szonyi commented on AVRO-2069: --- I looked at the git blame/history and it seems that it hasn't been

[jira] [Commented] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-09-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150533#comment-16150533 ] ASF subversion and git services commented on AVRO-2066: --- Commit

Re: Avro schema resolution

2017-09-01 Thread Sean Busbey
What's the rationale for not allowing it at all? Given that it's been in the spec so long I'm hesitant to remove it. I can't think of a time that we did a breaking change to the spec. Even if we check all of our implementations, there's no way to know if someone else has already created an

[jira] [Commented] (AVRO-2066) Wrong schema file used in one TestSpecificCompiler test case

2017-09-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150514#comment-16150514 ] Sean Busbey commented on AVRO-2066: --- +1 pushing shortly. > Wrong schema file used in one

[jira] [Commented] (AVRO-1891) Generated Java code fails with union containing logical type

2017-09-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150510#comment-16150510 ] Sean Busbey commented on AVRO-1891: --- Can someone give me a synopsis of current status? do we believe this

[jira] [Commented] (AVRO-2069) Use primitive fields in generated getters & setters in Java code

2017-09-01 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16150481#comment-16150481 ] Sean Busbey commented on AVRO-2069: --- we'll need to flag this as an incompatible change, but I agree that