[jira] [Commented] (AVRO-2230) ./build.sh test fails in c++
[
https://issues.apache.org/jira/browse/AVRO-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639151#comment-16639151
]
ASF GitHub Bot commented on AVRO-2230:
--
kojiromike closed pull request #335: AVRO-2230 Assignable line_ in Entity
URL: https://github.com/apache/avro/pull/335
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lang/c++/impl/json/JsonDom.hh b/lang/c++/impl/json/JsonDom.hh
index bde3b8f2c..b6b1430e5 100644
--- a/lang/c++/impl/json/JsonDom.hh
+++ b/lang/c++/impl/json/JsonDom.hh
@@ -64,7 +64,7 @@ const char* typeToString(EntityType t);
class AVRO_DECL Entity {
EntityType type_;
boost::any value_;
-const size_t line_;
+size_t line_;
void ensureType(EntityType) const;
public:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ./build.sh test fails in c++
>
>
> Key: AVRO-2230
> URL: https://issues.apache.org/jira/browse/AVRO-2230
> Project: Avro
> Issue Type: Bug
>Reporter: Michael A. Smith
>Priority: Major
>
> In a clean docker build, the c++ build fails with the following error.
> {noformat}
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> [ 1%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o
> In file included from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:0:
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh: In instantiation of ‘void
> std::__cxx1998::vector<_Tp,
> _Alloc>::_M_insert_aux(std::__cxx1998::vector<_Tp, _Alloc>::iterator, const
> _Tp&) [with _Tp = avro::json::Entity; _Alloc =
> std::allocator; std::__cxx1998::vector<_Tp,
> _Alloc>::iterator = __gnu_cxx::__normal_iterator std::__cxx1998::vector
> > >; typename std::__cxx1998::_Vector_base<_Tp, _Alloc>::pointer =
> avro::json::Entity*]’:
> /usr/include/c++/4.9/bits/stl_vector.h:925:28: required from ‘void
> std::__cxx1998::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp =
> avro::json::Entity; _Alloc = std::allocator;
> std::__cxx1998::vector<_Tp, _Alloc>::value_type = avro::json::Entity]’
> /usr/include/c++/4.9/debug/vector:407:22: required from ‘void
> std::__debug::vector<_Tp, _Allocator>::push_back(const _Tp&) [with _Tp =
> avro::json::Entity; _Allocator = std::allocator]’
> /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:72:43: required from here
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:64:17: error: non-static
> const member ‘const size_t avro::json::Entity::line_’, can’t use default
> assignment operator
> class AVRO_DECL Entity {
> ^
> In file included from /usr/include/c++/4.9/vector:69:0,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:26,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:
> /usr/include/c++/4.9/bits/vector.tcc:343:16: note: synthesized method
> ‘avro::json::Entity& avro::json::Entity::operator=(const
> avro::json::Entity&)’ first required here
> *__position = __x_copy;
> ^
> CMakeFiles/avrocpp_s.dir/build.make:514: recipe for target
> 'CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o' failed
> make[2]: *** [CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o] Error 1
> CMakeFiles/Makefile2:425: recipe for target 'CMakeFiles/avrocpp_s.dir/all'
> failed
> make[1]: *** [CMakeFiles/avrocpp_s.dir/all] Error 2
> Makefile:147: recipe for target 'all' failed
> make: *** [all] Error 2
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639156#comment-16639156 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427222300 (For your notes in the description, #335 is closed, duplicates work done in #326, which is now merged.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AVRO-2230) ./build.sh test fails in c++ due to assignment to const
[
https://issues.apache.org/jira/browse/AVRO-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael A. Smith resolved AVRO-2230.
Resolution: Fixed
Fixed in a patch intended for AVRO-2209
> ./build.sh test fails in c++ due to assignment to const
> ---
>
> Key: AVRO-2230
> URL: https://issues.apache.org/jira/browse/AVRO-2230
> Project: Avro
> Issue Type: Bug
>Reporter: Michael A. Smith
>Priority: Major
>
> In a clean docker build, the c++ build fails with the following error.
> {noformat}
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> [ 1%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o
> In file included from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:0:
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh: In instantiation of ‘void
> std::__cxx1998::vector<_Tp,
> _Alloc>::_M_insert_aux(std::__cxx1998::vector<_Tp, _Alloc>::iterator, const
> _Tp&) [with _Tp = avro::json::Entity; _Alloc =
> std::allocator; std::__cxx1998::vector<_Tp,
> _Alloc>::iterator = __gnu_cxx::__normal_iterator std::__cxx1998::vector
> > >; typename std::__cxx1998::_Vector_base<_Tp, _Alloc>::pointer =
> avro::json::Entity*]’:
> /usr/include/c++/4.9/bits/stl_vector.h:925:28: required from ‘void
> std::__cxx1998::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp =
> avro::json::Entity; _Alloc = std::allocator;
> std::__cxx1998::vector<_Tp, _Alloc>::value_type = avro::json::Entity]’
> /usr/include/c++/4.9/debug/vector:407:22: required from ‘void
> std::__debug::vector<_Tp, _Allocator>::push_back(const _Tp&) [with _Tp =
> avro::json::Entity; _Allocator = std::allocator]’
> /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:72:43: required from here
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:64:17: error: non-static
> const member ‘const size_t avro::json::Entity::line_’, can’t use default
> assignment operator
> class AVRO_DECL Entity {
> ^
> In file included from /usr/include/c++/4.9/vector:69:0,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:26,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:
> /usr/include/c++/4.9/bits/vector.tcc:343:16: note: synthesized method
> ‘avro::json::Entity& avro::json::Entity::operator=(const
> avro::json::Entity&)’ first required here
> *__position = __x_copy;
> ^
> CMakeFiles/avrocpp_s.dir/build.make:514: recipe for target
> 'CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o' failed
> make[2]: *** [CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o] Error 1
> CMakeFiles/Makefile2:425: recipe for target 'CMakeFiles/avrocpp_s.dir/all'
> failed
> make[1]: *** [CMakeFiles/avrocpp_s.dir/all] Error 2
> Makefile:147: recipe for target 'all' failed
> make: *** [all] Error 2
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (AVRO-2230) ./build.sh test fails in c++ due to assignment to const
[
https://issues.apache.org/jira/browse/AVRO-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael A. Smith updated AVRO-2230:
---
Summary: ./build.sh test fails in c++ due to assignment to const (was:
./build.sh test fails in c++)
> ./build.sh test fails in c++ due to assignment to const
> ---
>
> Key: AVRO-2230
> URL: https://issues.apache.org/jira/browse/AVRO-2230
> Project: Avro
> Issue Type: Bug
>Reporter: Michael A. Smith
>Priority: Major
>
> In a clean docker build, the c++ build fails with the following error.
> {noformat}
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> [ 1%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o
> In file included from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:0:
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh: In instantiation of ‘void
> std::__cxx1998::vector<_Tp,
> _Alloc>::_M_insert_aux(std::__cxx1998::vector<_Tp, _Alloc>::iterator, const
> _Tp&) [with _Tp = avro::json::Entity; _Alloc =
> std::allocator; std::__cxx1998::vector<_Tp,
> _Alloc>::iterator = __gnu_cxx::__normal_iterator std::__cxx1998::vector
> > >; typename std::__cxx1998::_Vector_base<_Tp, _Alloc>::pointer =
> avro::json::Entity*]’:
> /usr/include/c++/4.9/bits/stl_vector.h:925:28: required from ‘void
> std::__cxx1998::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp =
> avro::json::Entity; _Alloc = std::allocator;
> std::__cxx1998::vector<_Tp, _Alloc>::value_type = avro::json::Entity]’
> /usr/include/c++/4.9/debug/vector:407:22: required from ‘void
> std::__debug::vector<_Tp, _Allocator>::push_back(const _Tp&) [with _Tp =
> avro::json::Entity; _Allocator = std::allocator]’
> /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:72:43: required from here
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:64:17: error: non-static
> const member ‘const size_t avro::json::Entity::line_’, can’t use default
> assignment operator
> class AVRO_DECL Entity {
> ^
> In file included from /usr/include/c++/4.9/vector:69:0,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:26,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:
> /usr/include/c++/4.9/bits/vector.tcc:343:16: note: synthesized method
> ‘avro::json::Entity& avro::json::Entity::operator=(const
> avro::json::Entity&)’ first required here
> *__position = __x_copy;
> ^
> CMakeFiles/avrocpp_s.dir/build.make:514: recipe for target
> 'CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o' failed
> make[2]: *** [CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o] Error 1
> CMakeFiles/Makefile2:425: recipe for target 'CMakeFiles/avrocpp_s.dir/all'
> failed
> make[1]: *** [CMakeFiles/avrocpp_s.dir/all] Error 2
> Makefile:147: recipe for target 'all' failed
> make: *** [all] Error 2
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639146#comment-16639146 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427221202 @kojiromike I fully agree. But instead instead of introducing a new file for Docker testing (https://github.com/apache/avro/pull/336/files#diff-be31a75fe0e789d10685a4ab885644ad), I would prefer to use the current tests: https://github.com/apache/avro/blob/master/build.sh#L40-L75 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1705) Set up Jenkins job to test all languages using Docker
[ https://issues.apache.org/jira/browse/AVRO-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639160#comment-16639160 ] Sean Busbey commented on AVRO-1705: --- (for reference, the jira covering Yetus integration for CI checking of contributions is AVRO-1887) > Set up Jenkins job to test all languages using Docker > - > > Key: AVRO-1705 > URL: https://issues.apache.org/jira/browse/AVRO-1705 > Project: Avro > Issue Type: Task > Components: build >Affects Versions: 1.7.7 >Reporter: Tom White >Priority: Critical > Labels: starter > > The ASF Jenkins instance now supports Docker (BUILDS-25), so we could run all > the tests (for all languages that Avro supports) using the Avro Dockerfile. > We might also do a nightly build of the whole distribution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1705) Set up Jenkins job to test all languages using Docker
[ https://issues.apache.org/jira/browse/AVRO-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639159#comment-16639159 ] Sean Busbey commented on AVRO-1705: --- [~Fokko] you should start a discussion on the dev list. I really want us to use Yetus, because it'll get us more than just what our build tests and it'll go faster. Currently I know Yetus works well from ASF jenkins, and AFAIK there's no Travis support. > Set up Jenkins job to test all languages using Docker > - > > Key: AVRO-1705 > URL: https://issues.apache.org/jira/browse/AVRO-1705 > Project: Avro > Issue Type: Task > Components: build >Affects Versions: 1.7.7 >Reporter: Tom White >Priority: Critical > Labels: starter > > The ASF Jenkins instance now supports Docker (BUILDS-25), so we could run all > the tests (for all languages that Avro supports) using the Avro Dockerfile. > We might also do a nightly build of the whole distribution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2230) ./build.sh test fails in c++
[
https://issues.apache.org/jira/browse/AVRO-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639150#comment-16639150
]
ASF GitHub Bot commented on AVRO-2230:
--
kojiromike commented on issue #335: AVRO-2230 Assignable line_ in Entity
URL: https://github.com/apache/avro/pull/335#issuecomment-427221794
Fixed in #326
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ./build.sh test fails in c++
>
>
> Key: AVRO-2230
> URL: https://issues.apache.org/jira/browse/AVRO-2230
> Project: Avro
> Issue Type: Bug
>Reporter: Michael A. Smith
>Priority: Major
>
> In a clean docker build, the c++ build fails with the following error.
> {noformat}
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> -- Boost version: 1.55.0
> -- Found the following Boost libraries:
> -- filesystem
> -- system
> -- program_options
> -- iostreams
> Enabled snappy codec
> -- Configuring done
> -- Generating done
> -- Build files have been written to: /home/michaels/avro/lang/c++/build
> [ 1%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o
> In file included from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:0:
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh: In instantiation of ‘void
> std::__cxx1998::vector<_Tp,
> _Alloc>::_M_insert_aux(std::__cxx1998::vector<_Tp, _Alloc>::iterator, const
> _Tp&) [with _Tp = avro::json::Entity; _Alloc =
> std::allocator; std::__cxx1998::vector<_Tp,
> _Alloc>::iterator = __gnu_cxx::__normal_iterator std::__cxx1998::vector
> > >; typename std::__cxx1998::_Vector_base<_Tp, _Alloc>::pointer =
> avro::json::Entity*]’:
> /usr/include/c++/4.9/bits/stl_vector.h:925:28: required from ‘void
> std::__cxx1998::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp =
> avro::json::Entity; _Alloc = std::allocator;
> std::__cxx1998::vector<_Tp, _Alloc>::value_type = avro::json::Entity]’
> /usr/include/c++/4.9/debug/vector:407:22: required from ‘void
> std::__debug::vector<_Tp, _Allocator>::push_back(const _Tp&) [with _Tp =
> avro::json::Entity; _Allocator = std::allocator]’
> /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:72:43: required from here
> /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:64:17: error: non-static
> const member ‘const size_t avro::json::Entity::line_’, can’t use default
> assignment operator
> class AVRO_DECL Entity {
> ^
> In file included from /usr/include/c++/4.9/vector:69:0,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.hh:26,
> from /home/michaels/avro/lang/c++/impl/json/JsonDom.cc:19:
> /usr/include/c++/4.9/bits/vector.tcc:343:16: note: synthesized method
> ‘avro::json::Entity& avro::json::Entity::operator=(const
> avro::json::Entity&)’ first required here
> *__position = __x_copy;
> ^
> CMakeFiles/avrocpp_s.dir/build.make:514: recipe for target
> 'CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o' failed
> make[2]: *** [CMakeFiles/avrocpp_s.dir/impl/json/JsonDom.cc.o] Error 1
> CMakeFiles/Makefile2:425: recipe for target 'CMakeFiles/avrocpp_s.dir/all'
> failed
> make[1]: *** [CMakeFiles/avrocpp_s.dir/all] Error 2
> Makefile:147: recipe for target 'all' failed
> make: *** [all] Error 2
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639145#comment-16639145 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427220920 Apologies, I hit enter too soon -- I want to add that I confirmed that the `test_rpc_interop.sh` fails with the exact same error in master. It has nothing to do with this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639143#comment-16639143 ] ASF GitHub Bot commented on AVRO-2229: -- kojiromike commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427220777 I don't think the `test_rpc_interop.sh` test breakage has anything to do with this PR. I think it's a bug in the ruby implementation. I think this PR is fine and (besides the rat thing) moves the project forward. My vote fwiw is that this changeset get merged in so we can move forward with other incremental fixups. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2229) Ability to test using a Docker image
[ https://issues.apache.org/jira/browse/AVRO-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639124#comment-16639124 ] ASF GitHub Bot commented on AVRO-2229: -- Fokko commented on issue #336: [AVRO-2229] Test using a Docker image URL: https://github.com/apache/avro/pull/336#issuecomment-427217379 @kojiromike I'm working on integrating the Docker testing with the existing `build.sh`'s. But this requires some more love. At the current state of the PR, with the docker tests we'd only execute the unit tests. I think it is important to also add the interop tests, but this needs some more attention. I hope to finish this the upcoming days. Recently there was a mail about the Python versions. I've checked and the current CI uses Python 2.7 and Python 3.4. We should decide on Python versions, and add them to the `BUILD.md` and the `setup.py` of the specific project to communicate which versions of Python we support. I've created a Jira to move from the deprecated `java` docker image to `openjdk`: https://issues.apache.org/jira/browse/AVRO-2238 Updating is not trivial since the `java` is based on Debian Jessie, and `openjdk` is based on Debian Stretch. This will update a lot of different packages, for example, it comes with a newer version of Perl and PHP. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ability to test using a Docker image > > > Key: AVRO-2229 > URL: https://issues.apache.org/jira/browse/AVRO-2229 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > Fix For: 1.9.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AVRO-2238) Update Docker image from java to openjdk
Fokko Driesprong created AVRO-2238: -- Summary: Update Docker image from java to openjdk Key: AVRO-2238 URL: https://issues.apache.org/jira/browse/AVRO-2238 Project: Avro Issue Type: Improvement Reporter: Fokko Driesprong Currently the docker image to run the tests is still using java which is deprecated: https://hub.docker.com/_/java/ Therefore we should move to openjdk (https://hub.docker.com/_/openjdk/). Starting with version 8, and also adding 10 and 11 to it to make sure that Avro is compatible with future version of Java. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (AVRO-2233) Add CI to the repository
[ https://issues.apache.org/jira/browse/AVRO-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AVRO-2233. Resolution: Duplicate > Add CI to the repository > > > Key: AVRO-2233 > URL: https://issues.apache.org/jira/browse/AVRO-2233 > Project: Avro > Issue Type: Improvement >Affects Versions: 1.8.2 >Reporter: Fokko Driesprong >Priority: Major > > Since we now have a Docker testsuite that is able to test all languages, it > would be nice to run this testsuite at every pull request, so we can be sure > that the codebase is still good, and we don't have to do it on our own > machines every time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1705) Set up Jenkins job to test all languages using Docker
[ https://issues.apache.org/jira/browse/AVRO-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639117#comment-16639117 ] Fokko Driesprong commented on AVRO-1705: I would like to move to Travis (I'm open for other CI services), to run CI at every commit and PR, so we can make sure that everything is still working as it should. And as a committer we don't have to run the whole testsuite on our own machine. > Set up Jenkins job to test all languages using Docker > - > > Key: AVRO-1705 > URL: https://issues.apache.org/jira/browse/AVRO-1705 > Project: Avro > Issue Type: Task > Components: build >Affects Versions: 1.7.7 >Reporter: Tom White >Priority: Critical > Labels: starter > > The ASF Jenkins instance now supports Docker (BUILDS-25), so we could run all > the tests (for all languages that Avro supports) using the Avro Dockerfile. > We might also do a nightly build of the whole distribution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (AVRO-2237) Fixed type mismatch between Generic Datum Reader/Writer and Convertion
Jeremie Pelletier created AVRO-2237: --- Summary: Fixed type mismatch between Generic Datum Reader/Writer and Convertion Key: AVRO-2237 URL: https://issues.apache.org/jira/browse/AVRO-2237 Project: Avro Issue Type: Bug Components: java Affects Versions: 1.8.2 Reporter: Jeremie Pelletier Both the GenericDatumWriter and GenericDatumReader allow fixed values to be of type "Object", as shown here: [https://github.com/apache/avro/blob/54a79769987d78384899062b59d413412c577de3/lang/java/avro/src/main/java/org/apache/avro/generic/GenericDatumWriter.java#L276] However the Conversion class only accepts "GenericFixed": [https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/Conversion.java#L104] This prevents using "byte[]" as the fixed type while keeping support for logical types at the same time. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-1891) Generated Java code fails with union containing logical type
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638278#comment-16638278
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva edited a comment on issue #329: Improved conversions handling +
pluggable conversions support [AVRO-1891, AVRO-2065]
URL: https://github.com/apache/avro/pull/329#issuecomment-427035082
> I'll hopefully have time to rebase it during today. Is there something
else I need to do for it to proceed to code review?
@nandorKollar Could you please help to assign reviewers to this PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Generated Java code fails with union containing logical type
>
>
> Key: AVRO-1891
> URL: https://issues.apache.org/jira/browse/AVRO-1891
> Project: Avro
> Issue Type: Bug
> Components: java, logical types
>Affects Versions: 1.8.1
>Reporter: Ross Black
>Priority: Blocker
> Fix For: 1.8.3
>
> Attachments: AVRO-1891.patch, AVRO-1891.yshi.1.patch,
> AVRO-1891.yshi.2.patch, AVRO-1891.yshi.3.patch, AVRO-1891.yshi.4.patch
>
>
> Example schema:
> {code}
> {
> "type": "record",
> "name": "RecordV1",
> "namespace": "org.brasslock.event",
> "fields": [
> { "name": "first", "type": ["null", {"type": "long",
> "logicalType":"timestamp-millis"}]}
> ]
> }
> {code}
> The avro compiler generates a field using the relevant joda class:
> {code}
> public org.joda.time.DateTime first
> {code}
> Running the following code to perform encoding:
> {code}
> final RecordV1 record = new
> RecordV1(DateTime.parse("2016-07-29T10:15:30.00Z"));
> final DatumWriter datumWriter = new
> SpecificDatumWriter<>(record.getSchema());
> final ByteArrayOutputStream stream = new ByteArrayOutputStream(8192);
> final BinaryEncoder encoder =
> EncoderFactory.get().directBinaryEncoder(stream, null);
> datumWriter.write(record, encoder);
> encoder.flush();
> final byte[] bytes = stream.toByteArray();
> {code}
> fails with the exception stacktrace:
> {code}
> org.apache.avro.AvroRuntimeException: Unknown datum type
> org.joda.time.DateTime: 2016-07-29T10:15:30.000Z
> at org.apache.avro.generic.GenericData.getSchemaName(GenericData.java:741)
> at
> org.apache.avro.specific.SpecificData.getSchemaName(SpecificData.java:293)
> at org.apache.avro.generic.GenericData.resolveUnion(GenericData.java:706)
> at
> org.apache.avro.generic.GenericDatumWriter.resolveUnion(GenericDatumWriter.java:192)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:110)
> at
> org.apache.avro.specific.SpecificDatumWriter.writeField(SpecificDatumWriter.java:87)
> at
> org.apache.avro.generic.GenericDatumWriter.writeRecord(GenericDatumWriter.java:143)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:105)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:73)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:60)
> at
> org.brasslock.avro.compiler.GeneratedRecordTest.shouldEncodeLogicalTypeInUnion(GeneratedRecordTest.java:82)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at
[jira] [Commented] (AVRO-1891) Generated Java code fails with union containing logical type
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638277#comment-16638277
]
ASF GitHub Bot commented on AVRO-1891:
--
kgalieva commented on issue #329: Improved conversions handling + pluggable
conversions support [AVRO-1891, AVRO-2065]
URL: https://github.com/apache/avro/pull/329#issuecomment-427035082
> I'll hopefully have time to rebase it during today. Is there something
else I need to do for it to proceed to code review?
@nandorKollar Could you please help to assign reviewers to this PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Generated Java code fails with union containing logical type
>
>
> Key: AVRO-1891
> URL: https://issues.apache.org/jira/browse/AVRO-1891
> Project: Avro
> Issue Type: Bug
> Components: java, logical types
>Affects Versions: 1.8.1
>Reporter: Ross Black
>Priority: Blocker
> Fix For: 1.8.3
>
> Attachments: AVRO-1891.patch, AVRO-1891.yshi.1.patch,
> AVRO-1891.yshi.2.patch, AVRO-1891.yshi.3.patch, AVRO-1891.yshi.4.patch
>
>
> Example schema:
> {code}
> {
> "type": "record",
> "name": "RecordV1",
> "namespace": "org.brasslock.event",
> "fields": [
> { "name": "first", "type": ["null", {"type": "long",
> "logicalType":"timestamp-millis"}]}
> ]
> }
> {code}
> The avro compiler generates a field using the relevant joda class:
> {code}
> public org.joda.time.DateTime first
> {code}
> Running the following code to perform encoding:
> {code}
> final RecordV1 record = new
> RecordV1(DateTime.parse("2016-07-29T10:15:30.00Z"));
> final DatumWriter datumWriter = new
> SpecificDatumWriter<>(record.getSchema());
> final ByteArrayOutputStream stream = new ByteArrayOutputStream(8192);
> final BinaryEncoder encoder =
> EncoderFactory.get().directBinaryEncoder(stream, null);
> datumWriter.write(record, encoder);
> encoder.flush();
> final byte[] bytes = stream.toByteArray();
> {code}
> fails with the exception stacktrace:
> {code}
> org.apache.avro.AvroRuntimeException: Unknown datum type
> org.joda.time.DateTime: 2016-07-29T10:15:30.000Z
> at org.apache.avro.generic.GenericData.getSchemaName(GenericData.java:741)
> at
> org.apache.avro.specific.SpecificData.getSchemaName(SpecificData.java:293)
> at org.apache.avro.generic.GenericData.resolveUnion(GenericData.java:706)
> at
> org.apache.avro.generic.GenericDatumWriter.resolveUnion(GenericDatumWriter.java:192)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:110)
> at
> org.apache.avro.specific.SpecificDatumWriter.writeField(SpecificDatumWriter.java:87)
> at
> org.apache.avro.generic.GenericDatumWriter.writeRecord(GenericDatumWriter.java:143)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:105)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:73)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:60)
> at
> org.brasslock.avro.compiler.GeneratedRecordTest.shouldEncodeLogicalTypeInUnion(GeneratedRecordTest.java:82)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at
[jira] [Created] (AVRO-2236) Java Avro Default Value restrictions to first union type leaks to usage of record types
Mario Eberhard created AVRO-2236:
Summary: Java Avro Default Value restrictions to first union type
leaks to usage of record types
Key: AVRO-2236
URL: https://issues.apache.org/jira/browse/AVRO-2236
Project: Avro
Issue Type: Bug
Components: java
Affects Versions: 1.8.2
Reporter: Mario Eberhard
Attachments: avrodefaulttest.zip
Default values are restricted to being of the same type as the first type in a
union.
{code:java}
{
"type": "record",
"name": "ComplexValue",
"fields":
[
{
"name": "value",
"type":
[
"null",
"long"
],
"default": null
}
]
}
{code}
This works as documented. However, the restriction also applies to default
values of this record type:
{code:java}
{
"type": "record",
"name": "ExampleRecord",
"namespace": "com.example",
"fields":
[
{
"name": "value1",
"type":
{
"type": "record",
"name": "ComplexValue",
"fields":
[
{
"name": "value",
"type":
[
"null",
"long"
],
"default": null
}
]
}
},
{
"name": "value2",
"type": "ComplexValue",
"default":
{
"value": 15
}
}
]
}
{code}
In this case the record "ExampleRecord" has a field "value2" of type
"ComplexType". This field is not optional but has a default to be able to read
instance where this field is not present.
During deserialization the following error is thrown:
{code:java}
org.apache.avro.AvroTypeException: Non-null default value for null type: 15
at
org.apache.avro.io.parsing.ResolvingGrammarGenerator.encode(ResolvingGrammarGenerator.java:413)
at
org.apache.avro.io.parsing.ResolvingGrammarGenerator.encode(ResolvingGrammarGenerator.java:365)
at
org.apache.avro.io.parsing.ResolvingGrammarGenerator.encode(ResolvingGrammarGenerator.java:335)
at
org.apache.avro.io.parsing.ResolvingGrammarGenerator.getBinary(ResolvingGrammarGenerator.java:307)
at
org.apache.avro.io.parsing.ResolvingGrammarGenerator.resolveRecords(ResolvingGrammarGenerator.java:285)
at
org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:118)
at
org.apache.avro.io.parsing.ResolvingGrammarGenerator.generate(ResolvingGrammarGenerator.java:50)
at org.apache.avro.io.ResolvingDecoder.resolve(ResolvingDecoder.java:85)
at org.apache.avro.io.ResolvingDecoder.(ResolvingDecoder.java:49)
at
org.apache.avro.io.DecoderFactory.resolvingDecoder(DecoderFactory.java:307)
at
org.apache.avro.generic.GenericDatumReader.getResolver(GenericDatumReader.java:128)
at
org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:143)
at
com.example.SerializationTest.lambda$getDeserializer$1(SerializationTest.java:75)
at
com.example.SerializationTest.valueReadWithCorrectDefaultValue(SerializationTest.java:41)
{code}
I would argue that a concrete instance of "ComplexValue" with a specific value
should be allowed in this case. I see no reason why the default restriction of
the underlying schema should even apply. My guess is, that this is an
unintended consequence of code reuse in the java client.
I added an example gradle project as attachment. Run the tests to reproduce the
above example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-1891) Generated Java code fails with union containing logical type
[
https://issues.apache.org/jira/browse/AVRO-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637884#comment-16637884
]
ASF GitHub Bot commented on AVRO-1891:
--
scatrin commented on issue #329: Improved conversions handling + pluggable
conversions support [AVRO-1891, AVRO-2065]
URL: https://github.com/apache/avro/pull/329#issuecomment-426912754
Glad you like it @kgalieva and @ivangreene. I'll hopefully have time to
rebase it during today. Is there something else I need to do for it to proceed
to code review?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Generated Java code fails with union containing logical type
>
>
> Key: AVRO-1891
> URL: https://issues.apache.org/jira/browse/AVRO-1891
> Project: Avro
> Issue Type: Bug
> Components: java, logical types
>Affects Versions: 1.8.1
>Reporter: Ross Black
>Priority: Blocker
> Fix For: 1.8.3
>
> Attachments: AVRO-1891.patch, AVRO-1891.yshi.1.patch,
> AVRO-1891.yshi.2.patch, AVRO-1891.yshi.3.patch, AVRO-1891.yshi.4.patch
>
>
> Example schema:
> {code}
> {
> "type": "record",
> "name": "RecordV1",
> "namespace": "org.brasslock.event",
> "fields": [
> { "name": "first", "type": ["null", {"type": "long",
> "logicalType":"timestamp-millis"}]}
> ]
> }
> {code}
> The avro compiler generates a field using the relevant joda class:
> {code}
> public org.joda.time.DateTime first
> {code}
> Running the following code to perform encoding:
> {code}
> final RecordV1 record = new
> RecordV1(DateTime.parse("2016-07-29T10:15:30.00Z"));
> final DatumWriter datumWriter = new
> SpecificDatumWriter<>(record.getSchema());
> final ByteArrayOutputStream stream = new ByteArrayOutputStream(8192);
> final BinaryEncoder encoder =
> EncoderFactory.get().directBinaryEncoder(stream, null);
> datumWriter.write(record, encoder);
> encoder.flush();
> final byte[] bytes = stream.toByteArray();
> {code}
> fails with the exception stacktrace:
> {code}
> org.apache.avro.AvroRuntimeException: Unknown datum type
> org.joda.time.DateTime: 2016-07-29T10:15:30.000Z
> at org.apache.avro.generic.GenericData.getSchemaName(GenericData.java:741)
> at
> org.apache.avro.specific.SpecificData.getSchemaName(SpecificData.java:293)
> at org.apache.avro.generic.GenericData.resolveUnion(GenericData.java:706)
> at
> org.apache.avro.generic.GenericDatumWriter.resolveUnion(GenericDatumWriter.java:192)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:110)
> at
> org.apache.avro.specific.SpecificDatumWriter.writeField(SpecificDatumWriter.java:87)
> at
> org.apache.avro.generic.GenericDatumWriter.writeRecord(GenericDatumWriter.java:143)
> at
> org.apache.avro.generic.GenericDatumWriter.writeWithoutConversion(GenericDatumWriter.java:105)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:73)
> at
> org.apache.avro.generic.GenericDatumWriter.write(GenericDatumWriter.java:60)
> at
> org.brasslock.avro.compiler.GeneratedRecordTest.shouldEncodeLogicalTypeInUnion(GeneratedRecordTest.java:82)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at
