Re: [jira] [Resolved] (AVRO-2034) Nested schema types with unexpected fields causes json parse failure

2018-12-14 Thread Daniel Kulp


> On Dec 14, 2018, at 1:43 PM, Zoltan Farkas  
> wrote:
> 
> Daniel, can  you please take a look at my comment on this PR: 
> https://github.com/apache/avro/pull/224/files 
>  ?
> 
> I believe there might still be issues with this implementation in certain 
> situations.

Definitely a possibility.   The PR that was merged takes it a step further in 
allowing some constructs that would previously fail, but it may not fix 100% of 
the cases.   Feel free to create a test case and submit an additional PR.


-- 
Daniel Kulp
dk...@apache.org  - http://dankulp.com/blog 

Talend Community Coder - http://talend.com 


Re: [jira] [Resolved] (AVRO-2034) Nested schema types with unexpected fields causes json parse failure

2018-12-14 Thread Zoltan Farkas
Daniel, can  you please take a look at my comment on this PR: 
https://github.com/apache/avro/pull/224/files 
 ?

I believe there might still be issues with this implementation in certain 
situations.

Thanks!

—Z

> On Dec 11, 2018, at 1:18 PM, Daniel Kulp (JIRA)  wrote:
> 
> 
> [ 
> https://issues.apache.org/jira/browse/AVRO-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
> 
> Daniel Kulp resolved AVRO-2034.
> ---
>   Resolution: Fixed
> Assignee: Daniel Kulp
>Fix Version/s: 1.9.0
> 
>> Nested schema types with unexpected fields causes json parse failure
>> 
>> 
>>Key: AVRO-2034
>>URL: https://issues.apache.org/jira/browse/AVRO-2034
>>Project: Apache Avro
>> Issue Type: Bug
>> Components: java
>>   Affects Versions: 1.8.1
>>   Reporter: Todd Nine
>>   Assignee: Daniel Kulp
>>   Priority: Major
>>Fix For: 1.9.0
>> 
>> 
>> When parsing a nested type with an unexpected field using the JSON parser, 
>> this results in an error.  To reproduce, see the class {{TestNestedRecords}} 
>> in the referenced PR.
>> https://github.com/apache/avro/pull/224
>> Note that this only occurs when the following pattern exists in the schema.
>> # regular field
>> # nested record with additional field
>> # Any subsequent field following the nested record with an unexpected field 
>> appears to reproduce the problem.
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)



[jira] [Commented] (AVRO-2250) Release 1.9.0

2018-12-14 Thread Evan McQuinn (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721594#comment-16721594
 ] 

Evan McQuinn commented on AVRO-2250:


Yeah thanks Florent, I noticed that as well.

Should have been more clear in my comment before, but I was able to confirm 
that neither AtomicDoubleArray nor CompoundOrdering_CustomFieldSerializer are 
present in avro-1.8.2.jar (which is the one our code depends on).

> Release 1.9.0
> -
>
> Key: AVRO-2250
> URL: https://issues.apache.org/jira/browse/AVRO-2250
> Project: Apache Avro
>  Issue Type: Task
>Reporter: Nandor Kollar
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (AVRO-2250) Release 1.9.0

2018-12-14 Thread Florent Guillaume (JIRA)


[ 
https://issues.apache.org/jira/browse/AVRO-2250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721572#comment-16721572
 ] 

Florent Guillaume commented on AVRO-2250:
-

Note, you should
{noformat}
grep AtomicDoubleArray{noformat}
without a trailing s, but it returns the same thing (i.e., not present in 
avro-tools-1.8.2.jar).

 

> Release 1.9.0
> -
>
> Key: AVRO-2250
> URL: https://issues.apache.org/jira/browse/AVRO-2250
> Project: Apache Avro
>  Issue Type: Task
>Reporter: Nandor Kollar
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (AVRO-2285) Remove the run_duration option

2018-12-14 Thread Fokko Driesprong (JIRA)
Fokko Driesprong created AVRO-2285:
--

 Summary: Remove the run_duration option
 Key: AVRO-2285
 URL: https://issues.apache.org/jira/browse/AVRO-2285
 Project: Apache Avro
  Issue Type: Task
Reporter: Fokko Driesprong


We should not use the `run_duration` option anymore. This used to be for 
restarting the scheduler from time to time, but right now the scheduler is 
getting more stable and therefore using this setting is considered bad and 
might cause an inconsistent state.




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)