Re: Avro 1.10.0 release / branch cut
Previously in this thread I proposed to cut the release branch for Avro 1.10 on friday 15 May and let a period of 2 weeks after that for stabilization and then start the vote for the release. However I (as other people in the project) at this moment have less time than expected so I would like to propose to postpone the branch cut and release two weeks to give us some short extra time to finish pending reviews and clean up stuff. New cut date May 29th. I hope this does not change many people plans, please let me know if you have any issues because of this and remember don't hesitate to ping me (hopefully) in advance if you want to discuss any release specific issue. Regards, Ismaël On Tue, Apr 28, 2020 at 10:02 AM Ismaël Mejía wrote: > > Hello everyone, > > As discussed previously [1] we intend to do the Avro 1.10.0 release on > May so I wanted to propose to cut the branch the next May 15th. The > idea is that in the following weeks we work hard on reviews and issue > triage and maybe the latest dependency updates. Once the branch is cut > we let then some days to stabilize the release branch (hopefully 1-2 > weeks) and then go with the vote. > > If you have issues you want to mark as critical to be part of the > release (e.g. security related or data corruption) mark them with the > Fix Version: 1.10.0 field in JIRA and more important if you have > issues that you think won’t be able to make it in time please > unmark/untag them or mark them as version 1.11.0 > > This is the list of open issues for the release, so please go ahead > and help us finish/triage them. > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20AVRO%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22%2C%20Reopened%2C%20%22Patch%20Available%22)%20AND%20fixVersion%20%3D%201.10.0 > > Thanks, and good triage, don’t hesitate to email me or ping me in your > PRs./tickets to bring my attention on critical things for the release. > > Best, > Ismaël
[jira] [Commented] (AVRO-2828) Add missing AvroNotImplementedException implementation.
[
https://issues.apache.org/jira/browse/AVRO-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106622#comment-17106622
]
Hudson commented on AVRO-2828:
--
SUCCESS: Integrated in Jenkins build AvroJava #862 (See
[https://builds.apache.org/job/AvroJava/862/])
AVRO-2828: Add AvroNotImplementedException (#875) (github:
[https://github.com/apache/avro/commit/4898556ee5455231645fc9c4c2e9cc7014dec1c0])
* (edit) lang/php/lib/avro.php
> Add missing AvroNotImplementedException implementation.
> ---
>
> Key: AVRO-2828
> URL: https://issues.apache.org/jira/browse/AVRO-2828
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Siad Ardroumli
>Assignee: Siad Ardroumli
>Priority: Major
> Fix For: 1.10.0
>
>
> `{color:#00}AvroNotImplementedException{color}` is used but not
> implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2833) [Python] lint fails with pycodestyle 2.6.0
[
https://issues.apache.org/jira/browse/AVRO-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106621#comment-17106621
]
Hudson commented on AVRO-2833:
--
SUCCESS: Integrated in Jenkins build AvroJava #862 (See
[https://builds.apache.org/job/AvroJava/862/])
AVRO-2833: Fix python whitespace for lint. (#881) (github:
[https://github.com/apache/avro/commit/e813aff84591724b237c1943e5d20b27d8d50bf4])
* (edit) lang/py/avro/test/test_datafile_interop.py
> [Python] lint fails with pycodestyle 2.6.0
> --
>
> Key: AVRO-2833
> URL: https://issues.apache.org/jira/browse/AVRO-2833
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
> Fix For: 1.10.0
>
>
> It looks like our code fails the lint since the recent update of pycodestyle
> from 2.5.0 to 2.6.0.
> {code}
> +cd lang/py
> + ./build.sh lint test
> GLOB sdist-make: /home/travis/build/RyanSkraba/avro/lang/py/setup.py
> lint create: /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint
> lint installdeps: isort, pycodestyle
> lint inst:
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0+snapshot.zip
> lint installed: avro @
> file:///home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0%2Bsnapshot.zip,isort==4.3.21,pycodestyle==2.6.0
> lint run-test-pre: PYTHONHASHSEED='3539139953'
> lint run-test: commands[0] | isort --check-only
> Skipped 1 files
> lint run-test: commands[1] | pycodestyle
> ./avro/test/test_datafile_interop.py:30:1: E302 expected 2 blank lines, found
> 1
> 1 E302 expected 2 blank lines, found 1
> ERROR: InvocationError for command
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint/bin/pycodestyle (exited
> with code 1)
> {code}
> This can be reproduced locally (and on all PR checks since May 11th).
> We could pin pycodestyle to 2.5.0, but we should also listen to the lint and
> fix this whitespace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (AVRO-2828) Add missing AvroNotImplementedException implementation.
[
https://issues.apache.org/jira/browse/AVRO-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong reassigned AVRO-2828:
--
Assignee: Siad Ardroumli
> Add missing AvroNotImplementedException implementation.
> ---
>
> Key: AVRO-2828
> URL: https://issues.apache.org/jira/browse/AVRO-2828
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Siad Ardroumli
>Assignee: Siad Ardroumli
>Priority: Major
> Fix For: 1.10.0
>
>
> `{color:#00}AvroNotImplementedException{color}` is used but not
> implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (AVRO-2828) Add missing AvroNotImplementedException implementation.
[
https://issues.apache.org/jira/browse/AVRO-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong resolved AVRO-2828.
Fix Version/s: 1.10.0
Resolution: Fixed
> Add missing AvroNotImplementedException implementation.
> ---
>
> Key: AVRO-2828
> URL: https://issues.apache.org/jira/browse/AVRO-2828
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Siad Ardroumli
>Priority: Major
> Fix For: 1.10.0
>
>
> `{color:#00}AvroNotImplementedException{color}` is used but not
> implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2828) Add missing AvroNotImplementedException implementation.
[
https://issues.apache.org/jira/browse/AVRO-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106572#comment-17106572
]
ASF subversion and git services commented on AVRO-2828:
---
Commit 4898556ee5455231645fc9c4c2e9cc7014dec1c0 in avro's branch
refs/heads/master from Siad Ardroumli
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=4898556 ]
AVRO-2828: Add AvroNotImplementedException (#875)
> Add missing AvroNotImplementedException implementation.
> ---
>
> Key: AVRO-2828
> URL: https://issues.apache.org/jira/browse/AVRO-2828
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Siad Ardroumli
>Priority: Major
>
> `{color:#00}AvroNotImplementedException{color}` is used but not
> implemented.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2833) [Python] lint fails with pycodestyle 2.6.0
[
https://issues.apache.org/jira/browse/AVRO-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106571#comment-17106571
]
ASF subversion and git services commented on AVRO-2833:
---
Commit e813aff84591724b237c1943e5d20b27d8d50bf4 in avro's branch
refs/heads/master from RyanSkraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=e813aff ]
AVRO-2833: Fix python whitespace for lint. (#881)
> [Python] lint fails with pycodestyle 2.6.0
> --
>
> Key: AVRO-2833
> URL: https://issues.apache.org/jira/browse/AVRO-2833
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
> Fix For: 1.10.0
>
>
> It looks like our code fails the lint since the recent update of pycodestyle
> from 2.5.0 to 2.6.0.
> {code}
> +cd lang/py
> + ./build.sh lint test
> GLOB sdist-make: /home/travis/build/RyanSkraba/avro/lang/py/setup.py
> lint create: /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint
> lint installdeps: isort, pycodestyle
> lint inst:
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0+snapshot.zip
> lint installed: avro @
> file:///home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0%2Bsnapshot.zip,isort==4.3.21,pycodestyle==2.6.0
> lint run-test-pre: PYTHONHASHSEED='3539139953'
> lint run-test: commands[0] | isort --check-only
> Skipped 1 files
> lint run-test: commands[1] | pycodestyle
> ./avro/test/test_datafile_interop.py:30:1: E302 expected 2 blank lines, found
> 1
> 1 E302 expected 2 blank lines, found 1
> ERROR: InvocationError for command
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint/bin/pycodestyle (exited
> with code 1)
> {code}
> This can be reproduced locally (and on all PR checks since May 11th).
> We could pin pycodestyle to 2.5.0, but we should also listen to the lint and
> fix this whitespace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AVRO-2833) [Python] lint fails with pycodestyle 2.6.0
[
https://issues.apache.org/jira/browse/AVRO-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fokko Driesprong updated AVRO-2833:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> [Python] lint fails with pycodestyle 2.6.0
> --
>
> Key: AVRO-2833
> URL: https://issues.apache.org/jira/browse/AVRO-2833
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
> Fix For: 1.10.0
>
>
> It looks like our code fails the lint since the recent update of pycodestyle
> from 2.5.0 to 2.6.0.
> {code}
> +cd lang/py
> + ./build.sh lint test
> GLOB sdist-make: /home/travis/build/RyanSkraba/avro/lang/py/setup.py
> lint create: /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint
> lint installdeps: isort, pycodestyle
> lint inst:
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0+snapshot.zip
> lint installed: avro @
> file:///home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0%2Bsnapshot.zip,isort==4.3.21,pycodestyle==2.6.0
> lint run-test-pre: PYTHONHASHSEED='3539139953'
> lint run-test: commands[0] | isort --check-only
> Skipped 1 files
> lint run-test: commands[1] | pycodestyle
> ./avro/test/test_datafile_interop.py:30:1: E302 expected 2 blank lines, found
> 1
> 1 E302 expected 2 blank lines, found 1
> ERROR: InvocationError for command
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint/bin/pycodestyle (exited
> with code 1)
> {code}
> This can be reproduced locally (and on all PR checks since May 11th).
> We could pin pycodestyle to 2.5.0, but we should also listen to the lint and
> fix this whitespace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2826) Add .asf.yaml file to configure github notifications
[ https://issues.apache.org/jira/browse/AVRO-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106522#comment-17106522 ] Hudson commented on AVRO-2826: -- SUCCESS: Integrated in Jenkins build AvroJava #861 (See [https://builds.apache.org/job/AvroJava/861/]) AVRO-2826: Add yamllint configuration for Avro (iemejia: [https://github.com/apache/avro/commit/384c355b976e107cff11a85b9fe2658e1f335792]) * (add) .yamllint.yml AVRO-2826: Add .asf.yaml file to configure github notifications (iemejia: [https://github.com/apache/avro/commit/f50faa9c6bdc0ad9bc8db308b74668fa93644102]) * (add) .asf.yaml AVRO-2826: Fix issue with non valid alphanumeric characters for labels (iemejia: [https://github.com/apache/avro/commit/f93cd266d3031e35463a6bfc4aeee92a7550b260]) * (edit) .asf.yaml AVRO-2826: Fix issue with non valid alphanumeric characters for labels (iemejia: [https://github.com/apache/avro/commit/8f4134a09f8cb707cd7f0de784ecda20234c818f]) * (edit) .asf.yaml > Add .asf.yaml file to configure github notifications > > > Key: AVRO-2826 > URL: https://issues.apache.org/jira/browse/AVRO-2826 > Project: Apache Avro > Issue Type: Improvement > Components: build >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > Infra created a new way to configure github notifications. > https://s.apache.org/asfyaml-notify > This ticket is to tackle this for Avro. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2826) Add .asf.yaml file to configure github notifications
[ https://issues.apache.org/jira/browse/AVRO-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106502#comment-17106502 ] ASF subversion and git services commented on AVRO-2826: --- Commit 8f4134a09f8cb707cd7f0de784ecda20234c818f in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=8f4134a ] AVRO-2826: Fix issue with non valid alphanumeric characters for labels in .asf.yaml file (2) > Add .asf.yaml file to configure github notifications > > > Key: AVRO-2826 > URL: https://issues.apache.org/jira/browse/AVRO-2826 > Project: Apache Avro > Issue Type: Improvement > Components: build >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > Infra created a new way to configure github notifications. > https://s.apache.org/asfyaml-notify > This ticket is to tackle this for Avro. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2826) Add .asf.yaml file to configure github notifications
[ https://issues.apache.org/jira/browse/AVRO-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106485#comment-17106485 ] ASF subversion and git services commented on AVRO-2826: --- Commit f93cd266d3031e35463a6bfc4aeee92a7550b260 in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=f93cd26 ] AVRO-2826: Fix issue with non valid alphanumeric characters for labels in .asf.yaml file > Add .asf.yaml file to configure github notifications > > > Key: AVRO-2826 > URL: https://issues.apache.org/jira/browse/AVRO-2826 > Project: Apache Avro > Issue Type: Improvement > Components: build >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > Infra created a new way to configure github notifications. > https://s.apache.org/asfyaml-notify > This ticket is to tackle this for Avro. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AVRO-2835) New Issue to validate new email notifications schema
Ismaël Mejía created AVRO-2835: -- Summary: New Issue to validate new email notifications schema Key: AVRO-2835 URL: https://issues.apache.org/jira/browse/AVRO-2835 Project: Apache Avro Issue Type: New Feature Components: build Reporter: Ismaël Mejía Assignee: Ismaël Mejía Testing -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2826) Add .asf.yaml file to configure github notifications
[ https://issues.apache.org/jira/browse/AVRO-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106473#comment-17106473 ] ASF subversion and git services commented on AVRO-2826: --- Commit f50faa9c6bdc0ad9bc8db308b74668fa93644102 in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=f50faa9 ] AVRO-2826: Add .asf.yaml file to configure github notifications > Add .asf.yaml file to configure github notifications > > > Key: AVRO-2826 > URL: https://issues.apache.org/jira/browse/AVRO-2826 > Project: Apache Avro > Issue Type: Improvement > Components: build >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > Infra created a new way to configure github notifications. > https://s.apache.org/asfyaml-notify > This ticket is to tackle this for Avro. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AVRO-2826) Add .asf.yaml file to configure github notifications
[ https://issues.apache.org/jira/browse/AVRO-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106472#comment-17106472 ] ASF subversion and git services commented on AVRO-2826: --- Commit 384c355b976e107cff11a85b9fe2658e1f335792 in avro's branch refs/heads/master from Ismaël Mejía [ https://gitbox.apache.org/repos/asf?p=avro.git;h=384c355 ] AVRO-2826: Add yamllint configuration for Avro > Add .asf.yaml file to configure github notifications > > > Key: AVRO-2826 > URL: https://issues.apache.org/jira/browse/AVRO-2826 > Project: Apache Avro > Issue Type: Improvement > Components: build >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Minor > > Infra created a new way to configure github notifications. > https://s.apache.org/asfyaml-notify > This ticket is to tackle this for Avro. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AVRO-2834) Overload avpr schema methods
lino arango created AVRO-2834: - Summary: Overload avpr schema methods Key: AVRO-2834 URL: https://issues.apache.org/jira/browse/AVRO-2834 Project: Apache Avro Issue Type: Improvement Components: java Affects Versions: 1.9.2 Reporter: lino arango Is there a way to overload methods in avpr schema? Having the same method name but with different type and number of parameters -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AVRO-2833) [Python] lint fails with pycodestyle 2.6.0
[
https://issues.apache.org/jira/browse/AVRO-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba updated AVRO-2833:
--
Status: Patch Available (was: Open)
> [Python] lint fails with pycodestyle 2.6.0
> --
>
> Key: AVRO-2833
> URL: https://issues.apache.org/jira/browse/AVRO-2833
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
> Fix For: 1.10.0
>
>
> It looks like our code fails the lint since the recent update of pycodestyle
> from 2.5.0 to 2.6.0.
> {code}
> +cd lang/py
> + ./build.sh lint test
> GLOB sdist-make: /home/travis/build/RyanSkraba/avro/lang/py/setup.py
> lint create: /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint
> lint installdeps: isort, pycodestyle
> lint inst:
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0+snapshot.zip
> lint installed: avro @
> file:///home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0%2Bsnapshot.zip,isort==4.3.21,pycodestyle==2.6.0
> lint run-test-pre: PYTHONHASHSEED='3539139953'
> lint run-test: commands[0] | isort --check-only
> Skipped 1 files
> lint run-test: commands[1] | pycodestyle
> ./avro/test/test_datafile_interop.py:30:1: E302 expected 2 blank lines, found
> 1
> 1 E302 expected 2 blank lines, found 1
> ERROR: InvocationError for command
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint/bin/pycodestyle (exited
> with code 1)
> {code}
> This can be reproduced locally (and on all PR checks since May 11th).
> We could pin pycodestyle to 2.5.0, but we should also listen to the lint and
> fix this whitespace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (AVRO-2833) [Python] lint fails with pycodestyle 2.6.0
[
https://issues.apache.org/jira/browse/AVRO-2833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba reassigned AVRO-2833:
-
Assignee: Ryan Skraba
> [Python] lint fails with pycodestyle 2.6.0
> --
>
> Key: AVRO-2833
> URL: https://issues.apache.org/jira/browse/AVRO-2833
> Project: Apache Avro
> Issue Type: Bug
>Reporter: Ryan Skraba
>Assignee: Ryan Skraba
>Priority: Major
> Fix For: 1.10.0
>
>
> It looks like our code fails the lint since the recent update of pycodestyle
> from 2.5.0 to 2.6.0.
> {code}
> +cd lang/py
> + ./build.sh lint test
> GLOB sdist-make: /home/travis/build/RyanSkraba/avro/lang/py/setup.py
> lint create: /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint
> lint installdeps: isort, pycodestyle
> lint inst:
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0+snapshot.zip
> lint installed: avro @
> file:///home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0%2Bsnapshot.zip,isort==4.3.21,pycodestyle==2.6.0
> lint run-test-pre: PYTHONHASHSEED='3539139953'
> lint run-test: commands[0] | isort --check-only
> Skipped 1 files
> lint run-test: commands[1] | pycodestyle
> ./avro/test/test_datafile_interop.py:30:1: E302 expected 2 blank lines, found
> 1
> 1 E302 expected 2 blank lines, found 1
> ERROR: InvocationError for command
> /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint/bin/pycodestyle (exited
> with code 1)
> {code}
> This can be reproduced locally (and on all PR checks since May 11th).
> We could pin pycodestyle to 2.5.0, but we should also listen to the lint and
> fix this whitespace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (AVRO-2833) [Python] lint fails with pycodestyle 2.6.0
Ryan Skraba created AVRO-2833:
-
Summary: [Python] lint fails with pycodestyle 2.6.0
Key: AVRO-2833
URL: https://issues.apache.org/jira/browse/AVRO-2833
Project: Apache Avro
Issue Type: Bug
Reporter: Ryan Skraba
Fix For: 1.10.0
It looks like our code fails the lint since the recent update of pycodestyle
from 2.5.0 to 2.6.0.
{code}
+cd lang/py
+ ./build.sh lint test
GLOB sdist-make: /home/travis/build/RyanSkraba/avro/lang/py/setup.py
lint create: /home/travis/build/RyanSkraba/avro/lang/py/.tox/lint
lint installdeps: isort, pycodestyle
lint inst:
/home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0+snapshot.zip
lint installed: avro @
file:///home/travis/build/RyanSkraba/avro/lang/py/.tox/.tmp/package/1/avro-1.10.0%2Bsnapshot.zip,isort==4.3.21,pycodestyle==2.6.0
lint run-test-pre: PYTHONHASHSEED='3539139953'
lint run-test: commands[0] | isort --check-only
Skipped 1 files
lint run-test: commands[1] | pycodestyle
./avro/test/test_datafile_interop.py:30:1: E302 expected 2 blank lines, found 1
1 E302 expected 2 blank lines, found 1
ERROR: InvocationError for command
/home/travis/build/RyanSkraba/avro/lang/py/.tox/lint/bin/pycodestyle (exited
with code 1)
{code}
This can be reproduced locally (and on all PR checks since May 11th).
We could pin pycodestyle to 2.5.0, but we should also listen to the lint and
fix this whitespace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AVRO-2832) [Java] Create a configurable Formatter for Schemas
[
https://issues.apache.org/jira/browse/AVRO-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba updated AVRO-2832:
--
Issue Type: Improvement (was: Bug)
> [Java] Create a configurable Formatter for Schemas
> --
>
> Key: AVRO-2832
> URL: https://issues.apache.org/jira/browse/AVRO-2832
> Project: Apache Avro
> Issue Type: Improvement
>Reporter: Ryan Skraba
>Priority: Major
>
> The JSON String representation of a Schema is obtained using the
> {{toString(...)}} methods on the class. Instead of using this method, we
> should create a configurable {{Formatter}} to create the JSON representation.
> This would allow configuration options on how the JSON is constructed,
> notably to include/exclude schemas that should be considered "known" when the
> Schema is parsed (see AVRO-2822).
> This is similar to how the old {{parse(...)}} methods directly on Schema were
> deprecated in favour of a {{Parser}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AVRO-2608) The generated java-class attribute URI has an unhandled exception type of URISyntaxException
[
https://issues.apache.org/jira/browse/AVRO-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Skraba updated AVRO-2608:
--
Status: Patch Available (was: Open)
> The generated java-class attribute URI has an unhandled exception type of
> URISyntaxException
>
>
> Key: AVRO-2608
> URL: https://issues.apache.org/jira/browse/AVRO-2608
> Project: Apache Avro
> Issue Type: Bug
> Components: java
>Reporter: Zezeng Wang
>Assignee: Zezeng Wang
>Priority: Major
> Fix For: 1.10.0
>
>
> When creating a java.net.URI Object,there is no handling of a
> URISyntaxException.
> Given a specific record generated from the following avsc:
> {code:java}
> {"namespace": "example.avro",
> "type": "record",
> "name": "User",
> "fields": [
> {"name": "name", "type": "string"},
> {"name": "favorite_number", "type": ["int", "null"]},
> {"name": "favorite_color", "type": ["string", "null"]},
>{
> "name": "ownerAddress",
> "type": [
> "null",
> {
> "type": "string",
> "java-class": "java.net.URI"
> }
> ],
> "default": null
> }
> ]
> }{code}
> and class
> @org.apache.avro.specific.AvroGenerated
> public class User extends org.apache.avro.specific.
> {
> ..
> private java.net.URI ownerAddress;
> ..
> {color:red}this.ownerAddress = new java.net.URI(in.readString());{color}
> *{color:red}//There is Unhandled exception type URISyntaxException{color}*
> }{
> If you want to use the customDecode method, there will be an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AVRO-2822) Need a method to reconstruct the original schema string before referenced schemas were resolved and inlined by the Parser
[
https://issues.apache.org/jira/browse/AVRO-2822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106279#comment-17106279
]
Ryan Skraba commented on AVRO-2822:
---
Before closing this, is there a way we can mark this method as "experimental" ?
I'm thinking Yetus annotations.
>From the [PR|https://github.com/apache/avro/pull/869#issuecomment-623567079],
>I'd prefer this method be deprecated when something like the linked JIRA
>AVRO-2832 is implemented.
> Need a method to reconstruct the original schema string before referenced
> schemas were resolved and inlined by the Parser
> -
>
> Key: AVRO-2822
> URL: https://issues.apache.org/jira/browse/AVRO-2822
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.9.2
>Reporter: Robert Yokota
>Assignee: Robert Yokota
>Priority: Minor
> Fix For: 1.10.0
>
>
> I need a method to reconstruct the original schema string before referenced
> schemas were resolved and inlined by the Parser.
> There is already logic to do this for a schema in the context of a protocol,
> but not after a schema (and its referenced schemas) are submitted to the
> parse() method of Schema.Parser.
> The method would be the following on Schema:
> {code:java}
> public String toString(Collection referencedSchemas, boolean pretty) {
> try {
> StringWriter writer = new StringWriter();
> JsonGenerator gen = FACTORY.createGenerator(writer);
> if (pretty) {
> gen.useDefaultPrettyPrinter();
> }
> Schema.Names names = new Schema.Names();
> if (referencedSchemas != null) {
> for (Schema s : referencedSchemas) {
> names.add(s);
> }
> }
> toJson(names, gen);
> gen.flush();
> return writer.toString();
> } catch (IOException e) {
> throw new AvroRuntimeException(e);
> }
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (AVRO-2832) [Java] Create a configurable Formatter for Schemas
Ryan Skraba created AVRO-2832:
-
Summary: [Java] Create a configurable Formatter for Schemas
Key: AVRO-2832
URL: https://issues.apache.org/jira/browse/AVRO-2832
Project: Apache Avro
Issue Type: Bug
Reporter: Ryan Skraba
The JSON String representation of a Schema is obtained using the
{{toString(...)}} methods on the class. Instead of using this method, we
should create a configurable {{Formatter}} to create the JSON representation.
This would allow configuration options on how the JSON is constructed, notably
to include/exclude schemas that should be considered "known" when the Schema is
parsed (see AVRO-2822).
This is similar to how the old {{parse(...)}} methods directly on Schema were
deprecated in favour of a {{Parser}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
