[GitHub] avro pull request #272: AVRO-2120: Fix NullPointerException thrown by Schema...

2018-01-02 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/272 ---

[GitHub] avro pull request #266: AVRO-2117: Code cleanup

2017-12-29 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/266 ---

[GitHub] avro pull request #272: AVRO-2120: Fix NullPointerException thrown by Schema...

2017-12-23 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/272 AVRO-2120: Fix NullPointerException thrown by Schema.Parser#parse("") Fix for master for https://issues.apache.org/jira/browse/AVRO-2120 . TODO: Also backport to branch 1.8 You

[GitHub] avro pull request #264: Backporting two NPE fixes from master to branch-1.8

2017-12-22 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/264 ---

[GitHub] avro pull request #265: AVRO-2119: Run Apache Rat check on every java build

2017-12-22 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/265 ---

[GitHub] avro pull request #271: AVRO 2118+2119 Fix licensing issues

2017-12-22 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/271 AVRO 2118+2119 Fix licensing issues I have combined the various actions from AVRO-2118 (licensing issues) and AVRO-2119 (Run rat always) into this set of commits. I also updated Apache Rat

[GitHub] avro pull request #269: Avro 2114 for branch-1.8

2017-12-18 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/269 ---

[GitHub] avro pull request #269: Avro 2114 for branch-1.8

2017-12-18 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/269 Avro 2114 for branch-1.8 I backported the fix for https://issues.apache.org/jira/browse/AVRO-2114 (see https://github.com/apache/avro/pull/263 ) to branch-1.8 The only real change

[GitHub] avro pull request #266: Avro 2117 code cleanup

2017-12-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/266 Avro 2117 code cleanup This is a massive set of changes to reduce the number of needless warnings in the (mostly Java) code base. I have kept each type of change in a separate commit so we

[GitHub] avro pull request #265: AVRO-2119: Run Apache Rat check on every java build

2017-12-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/265 AVRO-2119: Run Apache Rat check on every java build This simply forces Apache Rat to run on every Java build. Must be committed to branch-1.7 branch-1.8 and master. You can merge this pull

[GitHub] avro pull request #264: Backporting two NPE fixes from master to branch-1.8

2017-12-12 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/264 Backporting two NPE fixes from master to branch-1.8 I cherry-picked the commits for AVRO-1966 and AVRO-1967 which are both fixes for NPE situations that I would really like to be part of the next

[GitHub] avro pull request #263: AVRO-2114: Make missing value exceptions in nested s...

2017-12-12 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/263 AVRO-2114: Make missing value exceptions in nested structures easier to read. With this patch the exception of a missing nested fields looks like this below. The developer can now clearly

[GitHub] avro pull request #262: AVRO-2043: Remove pre JDK 1.8 surefire specific conf...

2017-12-11 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/262 AVRO-2043: Remove pre JDK 1.8 surefire specific configuration I found a few remnants of the transition from Java 1.7 to 1.8 that can be removed. You can merge this pull request into a Git

[GitHub] avro pull request #168: AVRO-1967: Java: Fix NPE when calling getXyzBuilder ...

2016-12-17 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] avro pull request #168: AVRO-1967: Java: Fix NPE when calling getXyzBuilder ...

2016-12-01 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/168 AVRO-1967: Java: Fix NPE when calling getXyzBuilder on instance where the xyz is null You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] avro pull request #166: AVRO-1966: Java: Fix NPE When copying builder with n...

2016-11-30 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/166 AVRO-1966: Java: Fix NPE When copying builder with nullable record. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nielsbasjes/avro AVRO

[GitHub] avro pull request #162: AVRO-1961: Java: Generate getters that return a Java...

2016-11-23 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/162 AVRO-1961: Java: Generate getters that return a Java 8 Optional. NOTE: This must wait until AFTER the release of Avro 1.8.2. This is a first attempt at making the Java code generator have

[GitHub] avro pull request #153: AVRO-1956 Workaround incompatibility in testing CSha...

2016-11-10 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/153 AVRO-1956 Workaround incompatibility in testing CSharp code I'm not quite sure this is the right solution direction. An alternative would be to verify if the 'missing component is installed

[GitHub] avro pull request #149: AVRO-1944: Fixed invalid toString in records with du...

2016-11-01 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] avro pull request #149: AVRO-1944: Fixed invalid toString in records with du...

2016-10-26 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/149 AVRO-1944: Fixed invalid toString in records with duplicate values I ran into the effect that a record with two fields with the same value (or even both null) would result in a toString

[GitHub] avro pull request #141: AVRO-1932: Java: Allow setting the SchemaStore on ge...

2016-10-15 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/141 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] avro pull request #141: AVRO-1932: Java: Allow setting the SchemaStore on ge...

2016-10-10 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/141 AVRO-1932: Java: Allow setting the SchemaStore on generated classes. This change is needed to allow setting a different SchemaStore in the IDL generated classes. You can merge this pull request

[GitHub] avro pull request #128: AVRO-1923: Stop infinite recursion in GenericData.to...

2016-10-04 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] avro pull request #128: AVRO-1923: Stop infinite recursion in GenericData.to...

2016-09-22 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/128 AVRO-1923: Stop infinite recursion in GenericData.toString Simply keep count of the recursion depth and stop at 50 (which seems to me like a good value) You can merge this pull request

[GitHub] avro pull request #125: AVRO-1914: Fix licencing errors reported by rat.

2016-09-15 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/125 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] avro pull request #124: AVRO-1913: No warnings in the generated Java code.

2016-09-15 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/124 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] avro pull request #125: AVRO-1914: Fix licencing errors reported by rat.

2016-09-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/125 AVRO-1914: Fix licencing errors reported by rat. ./build.sh rat now succeeds You can merge this pull request into a Git repository by running: $ git pull https://github.com/nielsbasjes/avro

[GitHub] avro pull request #124: AVRO-1913: No warnings in the generated Java code.

2016-09-14 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/124 AVRO-1913: No warnings in the generated Java code. In my projects this reduces the compiler warnings to 0 in the generated code. You can merge this pull request into a Git repository by running

[GitHub] avro pull request: AVRO-1814: Fixed name collision between field n...

2016-04-11 Thread nielsbasjes
Github user nielsbasjes closed the pull request at: https://github.com/apache/avro/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] avro pull request: AVRO-1814: Fixed name collision between field n...

2016-03-25 Thread nielsbasjes
GitHub user nielsbasjes opened a pull request: https://github.com/apache/avro/pull/80 AVRO-1814: Fixed name collision between field names and toplevel package names You can merge this pull request into a Git repository by running: $ git pull https://github.com/nielsbasjes