[jira] [Commented] (AVRO-1575) Platform specific end of line hardcoded in unit test causes test failure on Windows.

2017-05-30 Thread Nandor Kollar (JIRA)

[ 
https://issues.apache.org/jira/browse/AVRO-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029388#comment-16029388
 ] 

Nandor Kollar commented on AVRO-1575:
-

Thanks, resolved as duplicate.

> Platform specific end of line hardcoded in unit test causes test failure on 
> Windows.
> 
>
> Key: AVRO-1575
> URL: https://issues.apache.org/jira/browse/AVRO-1575
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.7.7
> Environment: Windows
>Reporter: Zoltan Farkas
>Priority: Trivial
> Attachments: Avro-TestSchemaCompatibility.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> diff --git 
> a/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java 
> b/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> index 10d87df..6114981 100644
> --- 
> a/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> +++ 
> b/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> @@ -246,8 +246,8 @@
>  reader,
>  WRITER_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  WRITER_SCHEMA.toString(true),
>  reader.toString(true)));
>  
> @@ -271,8 +271,8 @@
>  invalidReader,
>  STRING_ARRAY_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  STRING_ARRAY_SCHEMA.toString(true),
>  invalidReader.toString(true)));
>  
> @@ -299,8 +299,8 @@
>  INT_SCHEMA,
>  STRING_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  STRING_SCHEMA.toString(true),
>  INT_SCHEMA.toString(true)));
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AVRO-1575) Platform specific end of line hardcoded in unit test causes test failure on Windows.

2017-05-30 Thread Zoltan Farkas (JIRA)

[ 
https://issues.apache.org/jira/browse/AVRO-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029363#comment-16029363
 ] 

Zoltan Farkas commented on AVRO-1575:
-

This can be closed.

> Platform specific end of line hardcoded in unit test causes test failure on 
> Windows.
> 
>
> Key: AVRO-1575
> URL: https://issues.apache.org/jira/browse/AVRO-1575
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.7.7
> Environment: Windows
>Reporter: Zoltan Farkas
>Priority: Trivial
> Attachments: Avro-TestSchemaCompatibility.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> diff --git 
> a/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java 
> b/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> index 10d87df..6114981 100644
> --- 
> a/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> +++ 
> b/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> @@ -246,8 +246,8 @@
>  reader,
>  WRITER_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  WRITER_SCHEMA.toString(true),
>  reader.toString(true)));
>  
> @@ -271,8 +271,8 @@
>  invalidReader,
>  STRING_ARRAY_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  STRING_ARRAY_SCHEMA.toString(true),
>  invalidReader.toString(true)));
>  
> @@ -299,8 +299,8 @@
>  INT_SCHEMA,
>  STRING_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  STRING_SCHEMA.toString(true),
>  INT_SCHEMA.toString(true)));
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (AVRO-1575) Platform specific end of line hardcoded in unit test causes test failure on Windows.

2017-05-30 Thread Nandor Kollar (JIRA)

[ 
https://issues.apache.org/jira/browse/AVRO-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029218#comment-16029218
 ] 

Nandor Kollar commented on AVRO-1575:
-

It seems this is fixed with the duplicate issue. [~zolyfarkas] is this still an 
outstanding issue? If not, may I close this?

> Platform specific end of line hardcoded in unit test causes test failure on 
> Windows.
> 
>
> Key: AVRO-1575
> URL: https://issues.apache.org/jira/browse/AVRO-1575
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.7.7
> Environment: Windows
>Reporter: Zoltan Farkas
>Priority: Trivial
> Attachments: Avro-TestSchemaCompatibility.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> diff --git 
> a/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java 
> b/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> index 10d87df..6114981 100644
> --- 
> a/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> +++ 
> b/lang/java/avro/src/test/java/org/apache/avro/TestSchemaCompatibility.java
> @@ -246,8 +246,8 @@
>  reader,
>  WRITER_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  WRITER_SCHEMA.toString(true),
>  reader.toString(true)));
>  
> @@ -271,8 +271,8 @@
>  invalidReader,
>  STRING_ARRAY_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  STRING_ARRAY_SCHEMA.toString(true),
>  invalidReader.toString(true)));
>  
> @@ -299,8 +299,8 @@
>  INT_SCHEMA,
>  STRING_SCHEMA,
>  String.format(
> -"Data encoded using writer schema:\n%s\n"
> -+ "will or may fail to decode using reader schema:\n%s\n",
> +"Data encoded using writer schema:%n%s%n"
> ++ "will or may fail to decode using reader schema:%n%s%n",
>  STRING_SCHEMA.toString(true),
>  INT_SCHEMA.toString(true)));
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)