[jira] [Commented] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[
https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700224#comment-16700224
]
ASF GitHub Bot commented on AVRO-2142:
--
iemejia closed pull request #282: AVRO-2142: Fix SchemaBuilder javadoc code
snippet
URL: https://github.com/apache/avro/pull/282
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java
b/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java
index cdc43e032..8ebe45baf 100644
--- a/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java
+++ b/lang/java/avro/src/main/java/org/apache/avro/SchemaBuilder.java
@@ -61,11 +61,11 @@
*
*
* Schema schema = SchemaBuilder
- * .record("HandshakeRequest").namespace("org.apache.avro.ipc)
+ * .record("HandshakeRequest").namespace("org.apache.avro.ipc")
* .fields()
* .name("clientHash").type().fixed("MD5").size(16).noDefault()
* .name("clientProtocol").type().nullable().stringType().noDefault()
- * .name("serverHash").type("MD5")
+ * .name("serverHash").type("MD5").noDefault()
* .name("meta").type().nullable().map().values().bytesType().noDefault()
* .endRecord();
*
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> SchemaBuilder Java documentation code snippet is not valid
> --
>
> Key: AVRO-2142
> URL: https://issues.apache.org/jira/browse/AVRO-2142
> Project: Apache Avro
> Issue Type: Improvement
> Components: doc, java
>Reporter: Ismaël Mejía
>Assignee: Ismaël Mejía
>Priority: Trivial
>
> The code snippet in SchemaBuilder is invalid, it has invalid quotes and
> misses one call in the builder chain.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700226#comment-16700226 ] ASF subversion and git services commented on AVRO-2142: --- Commit 39ec1a3f0addfce06869f705f7a17c03d538fe16 in avro's branch refs/heads/master from [~iemejia] [ https://gitbox.apache.org/repos/asf?p=avro.git;h=39ec1a3 ] AVRO-2142: Fix SchemaBuilder javadoc code snippet > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Apache Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360760#comment-16360760 ] ASF GitHub Bot commented on AVRO-2142: -- iemejia commented on issue #282: AVRO-2142: Fix SchemaBuilder javadoc code snippet URL: https://github.com/apache/avro/pull/282#issuecomment-364924876 Nice, thanks :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Assignee: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (AVRO-2142) SchemaBuilder Java documentation code snippet is not valid
[ https://issues.apache.org/jira/browse/AVRO-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360707#comment-16360707 ] ASF GitHub Bot commented on AVRO-2142: -- iemejia opened a new pull request #282: AVRO-2142: Fix SchemaBuilder javadoc code snippet URL: https://github.com/apache/avro/pull/282 The code snippet in SchemaBuilder is invalid, it has invalid quotes and misses one call in the builder chain. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > SchemaBuilder Java documentation code snippet is not valid > -- > > Key: AVRO-2142 > URL: https://issues.apache.org/jira/browse/AVRO-2142 > Project: Avro > Issue Type: Improvement > Components: doc, java >Reporter: Ismaël Mejía >Priority: Trivial > > The code snippet in SchemaBuilder is invalid, it has invalid quotes and > misses one call in the builder chain. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
