[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[Sean Busbey (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945504#comment-15945504
 ] 

Sean Busbey commented on AVRO-1684:
---

I haven't dug in enough yet to figure that part out.

> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.8.1
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[Ryan Blue (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945493#comment-15945493
 ] 

Ryan Blue commented on AVRO-1684:
-

We should definitely mark 1.8.1 as incompatible. Is it possible to fix the 
parser for future releases?

> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.8.1
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[Sean Busbey (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945468#comment-15945468
 ] 

Sean Busbey commented on AVRO-1684:
---

In light of AVRO-1924, should we flag this as incompatible?

> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.8.1
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[Ryan Blue (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15497024#comment-15497024
 ] 

Ryan Blue commented on AVRO-1684:
-

Yeah, good idea. Thanks!

> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.8.1
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[Doug Cutting (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15494315#comment-15494315
 ] 

Doug Cutting commented on AVRO-1684:


It looks as though the documentation for IDL was not updated:

https://avro.apache.org/docs/current/idl.html

Should I file a new issue for that?

Also, the package documentation for org.apache.avro.specific should be updated 
to describe the new logical type mappings, right?

https://avro.apache.org/docs/current/api/java/org/apache/avro/specific/package-summary.html

> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.8.1
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1521#comment-1521
 ] 

ASF GitHub Bot commented on AVRO-1684:
--

GitHub user rdblue opened a pull request:

https://github.com/apache/avro/pull/86

AVRO-1684: Add time types to the specific compiler.

This adds a dependency on Joda time for both the compiler and the
compiled classes. When generating Java classes, any conversion that is
registered with the compiler's SpecificData instance will be used.

This PR replaces #37, which was closed when the project moved to git.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rdblue/avro AVRO-1684-specific-logical-types

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/86.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #86


commit ed176f5ac9491a1ee9c993dc1d2c09f1c762795b
Author: Ryan Blue 
Date:   2015-05-28T23:59:40Z

AVRO-1684: Add time types to the specific compiler.

This adds a dependency on Joda time for both the compiler and the
compiled classes. When generating Java classes, any conversion that is
registered with the compiler's SpecificData instance will be used.




> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.7.8
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[Dustin Spicuzza (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200244#comment-15200244
 ] 

Dustin Spicuzza commented on AVRO-1684:
---

It would be nice to see this be implemented.

> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.7.8
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133240#comment-15133240
 ] 

ASF GitHub Bot commented on AVRO-1684:
--

Github user asfgit closed the pull request at:

https://github.com/apache/avro/pull/37


> Add date, time, and timestamp to specific object model classes
> --
>
> Key: AVRO-1684
> URL: https://issues.apache.org/jira/browse/AVRO-1684
> Project: Avro
>  Issue Type: New Feature
>  Components: java
>Affects Versions: 1.7.7
>Reporter: Ryan Blue
>Assignee: Ryan Blue
> Fix For: 1.7.8
>
> Attachments: AVRO-1684.1.patch
>
>
> AVRO-1672 adds conversions for date, time, and timestamp. These should be 
> available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[Ryan Blue (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14623164#comment-14623164
 ] 

Ryan Blue commented on AVRO-1684:
-

[~tomwhite], I'm attaching a patch that is based on the current trunk. I 
couldn't update the PR because the latest commits haven't made it to github 
yet. I'll update the PR once they're synced.

 Add date, time, and timestamp to specific object model classes
 --

 Key: AVRO-1684
 URL: https://issues.apache.org/jira/browse/AVRO-1684
 Project: Avro
  Issue Type: New Feature
  Components: java
Affects Versions: 1.7.7
Reporter: Ryan Blue
Assignee: Ryan Blue
 Fix For: 1.7.8

 Attachments: AVRO-1684.1.patch


 AVRO-1672 adds conversions for date, time, and timestamp. These should be 
 available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AVRO-1684) Add date, time, and timestamp to specific object model classes

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AVRO-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590748#comment-14590748
 ] 

ASF GitHub Bot commented on AVRO-1684:
--

GitHub user rdblue opened a pull request:

https://github.com/apache/avro/pull/37

AVRO-1684: Add support for date, time, and timestamp to specific

This is based on AVRO-1672, which adds the date, time, and timestamp 
conversions.

The specific IDL has been updated with 3 new field types: date, time_ms, 
and timestamp_ms. These will translate to fields that use the appropriate 
logical types that were added in AVRO-1672.

The compiler now includes logic to add date, time, and timestamp fields 
using Joda time objects, and the data reader and writer support classes with 
those objects. In addition, there is a test to validate that classes compiled 
from schemas with logical types before this patch still work.

Field conversions have been added to SpecificRecordBase via 
`getConversion(int)` and `getConversion(String fieldName)`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rdblue/avro AVRO-1684-specific-date-time

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 6a046d455bc521bd1da5a5f4ad64d4cb1a75a697
Author: Ryan Blue b...@apache.org
Date:   2015-05-28T22:46:44Z

AVRO-1672: Add time logical types and conversions.

This uses Joda classes to represent the new logical types:
* date = LocalDate
* time-millis = LocalTime
* timestamp-millis = DateTime

Joda is an optional dependency and will only be loaded if the
conversions in org.apache.avro.data.TimeConversions are referenced. By
default, no logical type conversions are enabled so there is no
additional runtime dependency for existing applications.

commit 09b3dbebbf06bd71ccd18039e00d278226e4d2e3
Author: Ryan Blue b...@apache.org
Date:   2015-05-28T23:59:40Z

AVRO-1684: Add time types to the specific compiler.

This adds a dependency on Joda time for both the compiler and the
compiled classes. When generating Java classes, any conversion that is
registered with the compiler's SpecificData instance will be used.

commit bead1610648cc7c0cb63a4b19e0d503b31f1e043
Author: Ryan Blue b...@apache.org
Date:   2015-06-16T20:08:46Z

AVRO-1672: Add tests for specific date/time types.

commit 8754a2ba8ed4675b98bb42bf60043acdebb81326
Author: Ryan Blue b...@apache.org
Date:   2015-06-17T19:20:48Z

AVRO-1684: Make specific time support compatible with existing classes.




 Add date, time, and timestamp to specific object model classes
 --

 Key: AVRO-1684
 URL: https://issues.apache.org/jira/browse/AVRO-1684
 Project: Avro
  Issue Type: New Feature
  Components: java
Affects Versions: 1.7.7
Reporter: Ryan Blue
 Fix For: 1.7.8


 AVRO-1672 adds conversions for date, time, and timestamp. These should be 
 available to specific classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)