[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647360#comment-13647360
]
Scott Carey commented on AVRO-1274:
---
I am working on a modification to the builder that
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647629#comment-13647629
]
Tom White commented on AVRO-1274:
-
I'm slightly reluctant to add lots of overloaded methods
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648048#comment-13648048
]
Scott Carey commented on AVRO-1274:
---
I am planning on constraining the lexical scope via
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647196#comment-13647196
]
Scott Carey commented on AVRO-1274:
---
We may have more work to do here.
How would you
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647221#comment-13647221
]
Scott Carey commented on AVRO-1274:
---
I think the answer to my question would be:
{code}
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13644503#comment-13644503
]
Hudson commented on AVRO-1274:
--
Integrated in AvroJava #367 (See
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13642247#comment-13642247
]
Scott Carey commented on AVRO-1274:
---
+1 Yes, looks good!
Add a schema
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640961#comment-13640961
]
Tom White commented on AVRO-1274:
-
Scott, are you OK for this to be committed now?
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639516#comment-13639516
]
Scott Carey commented on AVRO-1274:
---
This looks good.
Minor nit: perhaps change
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13639554#comment-13639554
]
Doug Cutting commented on AVRO-1274:
'default' is a reserved word in Java and cannot be
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609230#comment-13609230
]
Tom White commented on AVRO-1274:
-
nullable with null default, nullable with no default,
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607768#comment-13607768
]
Doug Cutting commented on AVRO-1274:
Schema, Field, Protocol and Message do actually
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607846#comment-13607846
]
Scott Carey commented on AVRO-1274:
---
I agree, don't hold this up.
It appears to be the
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607952#comment-13607952
]
Tom White commented on AVRO-1274:
-
Thanks for taking a look Scott. I agree that over time
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13608218#comment-13608218
]
Scott Carey commented on AVRO-1274:
---
Another type of schema that the builder cannot
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603315#comment-13603315
]
Tom White commented on AVRO-1274:
-
I'm wondering if the correct way to do this is actually
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603636#comment-13603636
]
Doug Cutting commented on AVRO-1274:
I'm wondering if the correct way to do this is
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603884#comment-13603884
]
Doug Cutting commented on AVRO-1274:
Some nits:
- If a default value has a nested
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602459#comment-13602459
]
Josh Wills commented on AVRO-1274:
--
Hey Tom-- I am of no help on the bytes default values
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602567#comment-13602567
]
Doug Cutting commented on AVRO-1274:
This should look like:
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602613#comment-13602613
]
Doug Cutting commented on AVRO-1274:
Sorry, I wrote the above before looking at your
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602789#comment-13602789
]
Doug Cutting commented on AVRO-1274:
Defaults are primarily used at read time to supply
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601319#comment-13601319
]
Doug Cutting commented on AVRO-1274:
This looks great, Tom, and has long been needed.
[
https://issues.apache.org/jira/browse/AVRO-1274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600838#comment-13600838
]
Josh Wills commented on AVRO-1274:
--
Hey Tom-- I wrote something along these lines way back
24 matches
Mail list logo
