[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-04-22 Thread Leo Romanoff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13638795#comment-13638795 ] Leo Romanoff commented on AVRO-1277: Yes, AVRO-1282 includes all changes from this one

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-22 Thread Leo Romanoff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610342#comment-13610342 ] Leo Romanoff commented on AVRO-1277: The updated version of the patch has some perf.

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-22 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610409#comment-13610409 ] Doug Cutting commented on AVRO-1277: Thanks for benchmarking this. The improvements

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-22 Thread JIRA
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610609#comment-13610609 ] Holger Hoffstätte commented on AVRO-1277: - Doug, thanks for addressing my concerns.

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-22 Thread Leo Romanoff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610932#comment-13610932 ] Leo Romanoff commented on AVRO-1277: I created an issue for Unsafe-based serialization:

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-22 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610985#comment-13610985 ] Doug Cutting commented on AVRO-1277: Re static caches: this should probably be

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-21 Thread Leo Romanoff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609175#comment-13609175 ] Leo Romanoff commented on AVRO-1277: I attach a first version of my patch. It is just

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-21 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609207#comment-13609207 ] Doug Cutting commented on AVRO-1277: This looks like great stuff! Some comments: -

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-21 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609229#comment-13609229 ] Doug Cutting commented on AVRO-1277: Holger, such problems can be avoided by making the

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-21 Thread Leo Romanoff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609281#comment-13609281 ] Leo Romanoff commented on AVRO-1277: @Doug: 1) If I add a test to Perf.java, I cannot

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-21 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609293#comment-13609293 ] Doug Cutting commented on AVRO-1277: # Yes, the standard approach is to run tests from

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-21 Thread Leo Romanoff (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609297#comment-13609297 ] Leo Romanoff commented on AVRO-1277: BTW, regarding the use of ThreadLocals: I think

[jira] [Commented] (AVRO-1277) Improve performance of reflection-based serializers

2013-03-21 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/AVRO-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609326#comment-13609326 ] Doug Cutting commented on AVRO-1277: The ReflectDatumReader is a context here. The