[jira] [Commented] (AVRO-2061) Improve Invalid File Format Error Message
[
https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125461#comment-16125461
]
ASF subversion and git services commented on AVRO-2061:
---
Commit 040a3be09216f188dff2b1bf1c23d21ecd4a265c in avro's branch
refs/heads/master from [~belugabehr]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=040a3be ]
AVRO-2061: Improve Invalid File Format Error Message
> Improve Invalid File Format Error Message
> -
>
> Key: AVRO-2061
> URL: https://issues.apache.org/jira/browse/AVRO-2061
> Project: Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.9.0, 1.8.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: AVRO-2061.1.patch, AVRO-2061.2.patch
>
>
> {code:title=org.apache.avro.file.DataFileStream}
> try {
> vin.readFixed(magic); // read magic
> } catch (IOException e) {
> throw new IOException("Not a data file.", e);
> }
> if (!Arrays.equals(DataFileConstants.MAGIC, magic))
> throw new IOException("Not a data file.");
> {code}
> Please consider improving the error message here. I just saw a MapReduce job
> fail with an IOException with the message "Not a data file." There was
> definitely data files in the input directory, however, they were not Avro
> files. It would have been much more helpful if it told me that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AVRO-2061) Improve Invalid File Format Error Message
[
https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118953#comment-16118953
]
BELUGA BEHR commented on AVRO-2061:
---
[~nkollar] [~cutting] There ya go! Patch submitted. :) Thanks.
> Improve Invalid File Format Error Message
> -
>
> Key: AVRO-2061
> URL: https://issues.apache.org/jira/browse/AVRO-2061
> Project: Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.9.0, 1.8.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: AVRO-2061.1.patch, AVRO-2061.2.patch
>
>
> {code:title=org.apache.avro.file.DataFileStream}
> try {
> vin.readFixed(magic); // read magic
> } catch (IOException e) {
> throw new IOException("Not a data file.", e);
> }
> if (!Arrays.equals(DataFileConstants.MAGIC, magic))
> throw new IOException("Not a data file.");
> {code}
> Please consider improving the error message here. I just saw a MapReduce job
> fail with an IOException with the message "Not a data file." There was
> definitely data files in the input directory, however, they were not Avro
> files. It would have been much more helpful if it told me that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AVRO-2061) Improve Invalid File Format Error Message
[
https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117124#comment-16117124
]
Doug Cutting commented on AVRO-2061:
This should be considered an incompatible change. While not a best practice,
there may be applications that depend on the existing error message.
Also, it might be better to call it an "Avro data file", rather than "object
file".
> Improve Invalid File Format Error Message
> -
>
> Key: AVRO-2061
> URL: https://issues.apache.org/jira/browse/AVRO-2061
> Project: Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.9.0, 1.8.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: AVRO-2061.1.patch
>
>
> {code:title=org.apache.avro.file.DataFileStream}
> try {
> vin.readFixed(magic); // read magic
> } catch (IOException e) {
> throw new IOException("Not a data file.", e);
> }
> if (!Arrays.equals(DataFileConstants.MAGIC, magic))
> throw new IOException("Not a data file.");
> {code}
> Please consider improving the error message here. I just saw a MapReduce job
> fail with an IOException with the message "Not a data file." There was
> definitely data files in the input directory, however, they were not Avro
> files. It would have been much more helpful if it told me that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AVRO-2061) Improve Invalid File Format Error Message
[
https://issues.apache.org/jira/browse/AVRO-2061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116446#comment-16116446
]
Nandor Kollar commented on AVRO-2061:
-
Looks good to me.
> Improve Invalid File Format Error Message
> -
>
> Key: AVRO-2061
> URL: https://issues.apache.org/jira/browse/AVRO-2061
> Project: Avro
> Issue Type: Improvement
> Components: java
>Affects Versions: 1.9.0, 1.8.2
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Trivial
> Attachments: AVRO-2061.1.patch
>
>
> {code:title=org.apache.avro.file.DataFileStream}
> try {
> vin.readFixed(magic); // read magic
> } catch (IOException e) {
> throw new IOException("Not a data file.", e);
> }
> if (!Arrays.equals(DataFileConstants.MAGIC, magic))
> throw new IOException("Not a data file.");
> {code}
> Please consider improving the error message here. I just saw a MapReduce job
> fail with an IOException with the message "Not a data file." There was
> definitely data files in the input directory, however, they were not Avro
> files. It would have been much more helpful if it told me that.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
