[jira] [Commented] (AVRO-2106) Revisit dependencies on Jetty, servlet-api, and Netty

2019-02-07 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763068#comment-16763068
 ] 

Hudson commented on AVRO-2106:
--

FAILURE: Integrated in Jenkins build AvroJava #602 (See 
[https://builds.apache.org/job/AvroJava/602/])
[AVRO-2106] Split netty/jetty out of avro-ipc (dan: 
[https://github.com/apache/avro/commit/ac95febf82b15ffa564cac1d92475cdf6efed9f6])
* (add) 
lang/java/ipc-jetty/src/test/java/org/apache/avro/ipc/jetty/StatsPluginOverhead.java
* (add) 
lang/java/ipc-jetty/src/test/resources/org/apache/avro/ipc/servercert.p12
* (edit) lang/java/mapred/pom.xml
* (edit) lang/java/ipc/pom.xml
* (edit) lang/java/pom.xml
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyServerWithCallbacks.java
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/stats/TestStatsPluginAndServlet.java
* (delete) 
lang/java/ipc/src/main/java/org/apache/avro/ipc/stats/StatsServer.java
* (edit) lang/java/ipc/src/main/java/org/apache/avro/ipc/Ipc.java
* (edit) lang/java/archetypes/avro-service-archetype/src/main/pom/pom.xml
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyServerWithSSL.java
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyServerWithCompression.java
* (add) 
lang/java/ipc-netty/src/main/java/org/apache/avro/ipc/netty/NettyServer.java
* (delete) lang/java/ipc/src/main/java/org/apache/avro/ipc/HttpServer.java
* (delete) 
lang/java/ipc/src/main/java/org/apache/avro/ipc/stats/StaticServlet.java
* (add) 
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServerConcurrentExecution.java
* (add) lang/java/ipc-netty/src/test/truststore
* (add) 
lang/java/ipc-netty/src/main/java/org/apache/avro/ipc/netty/NettyTransceiver.java
* (add) 
lang/java/ipc-netty/src/test/resources/org/apache/avro/ipc/servercert.p12
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/NettyTransceiverWhenFailsToConnect.java
* (edit) lang/java/ipc/src/main/java/org/apache/avro/ipc/stats/StatsPlugin.java
* (add) 
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/HttpServer.java
* (edit) lang/java/compiler/pom.xml
* (delete) lang/java/ipc/src/test/java/org/apache/avro/TestBulkData.java
* (add) 
lang/java/ipc-jetty/src/test/java/org/apache/avro/ipc/jetty/TestBulkData.java
* (delete) lang/java/ipc/src/test/java/org/apache/avro/TestProtocolHttps.java
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/stats/StatsPluginOverhead.java
* (edit) 
lang/java/mapred/src/main/java/org/apache/avro/mapred/tether/TetheredProcess.java
* (edit) lang/java/ipc/src/main/java/org/apache/avro/ipc/stats/StatsServlet.java
* (add) 
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StatsServer.java
* (delete) lang/java/ipc/src/main/java/org/apache/avro/ipc/NettyTransceiver.java
* (edit) 
lang/java/mapred/src/test/java/org/apache/avro/mapred/tether/TetherTaskRunner.java
* (delete) lang/java/ipc/src/test/java/org/apache/avro/TestProtocolNetty.java
* (add) lang/java/ipc-netty/pom.xml
* (edit) 
lang/java/archetypes/avro-service-archetype/src/main/resources/archetype-resources/src/main/java/transport/SimpleOrderServiceClient.java
* (delete) lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyServer.java
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyServerConcurrentExecution.java
* (edit) 
lang/java/archetypes/avro-service-archetype/src/main/resources/archetype-resources/src/main/java/transport/SimpleOrderServiceEndpoint.java
* (add) 
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyTransceiverWhenServerStops.java
* (add) 
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServerWithCompression.java
* (add) 
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServerWithSSL.java
* (add) lang/java/ipc-netty/src/test/keystore
* (add) 
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServer.java
* (delete) lang/java/ipc/src/main/java/org/apache/avro/ipc/NettyServer.java
* (edit) lang/java/ipc/src/test/java/org/apache/avro/ipc/stats/FakeTicks.java
* (add) 
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StaticServlet.java
* (add) lang/java/ipc-jetty/src/test/keystore
* (add) lang/java/ipc-jetty/pom.xml
* (add) 
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestNettyServerWithCallbacks.java
* (add) 
lang/java/ipc-netty/src/test/java/org/apache/avro/ipc/netty/TestProtocolNetty.java
* (add) 
lang/java/ipc-jetty/src/test/java/org/apache/avro/ipc/jetty/TestProtocolHttp.java
* (add) lang/java/ipc-jetty/src/test/truststore
* (add) 
lang/java/ipc-netty/src/main/java/org/apache/avro/ipc/netty/NettyTransportCodec.java
* (delete) 
lang/java/ipc/src/test/java/org/apache/avro/ipc/TestNettyTransceiverWhenServerStops.java
* (delete) 
lang/java/ipc/src/main/java/org/apache/avro/ipc/NettyTransportCodec.java
* (delete)

[jira] [Commented] (AVRO-2106) Revisit dependencies on Jetty, servlet-api, and Netty

2019-02-07 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/AVRO-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763063#comment-16763063
 ] 

ASF subversion and git services commented on AVRO-2106:
---

Commit ac95febf82b15ffa564cac1d92475cdf6efed9f6 in avro's branch 
refs/heads/master from Daniel Kulp
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ac95feb ]

[AVRO-2106] Split netty/jetty out of avro-ipc


> Revisit dependencies on Jetty, servlet-api, and Netty
> -
>
> Key: AVRO-2106
> URL: https://issues.apache.org/jira/browse/AVRO-2106
> Project: Apache Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2, 1.8.0
>Reporter: Nandor Kollar
>Priority: Major
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AVRO-2106) Revisit dependencies on Jetty, servlet-api, and Netty

2017-11-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/AVRO-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257233#comment-16257233
 ] 

ASF GitHub Bot commented on AVRO-2106:
--

GitHub user dkulp opened a pull request:

https://github.com/apache/avro/pull/259

[AVRO-2106] Start splitting jetty/netty out of avro-ipc

This is not ready to be merged, but wanted to prototype this to start a 
discussion to see if this is the right track.

Basically, I pulled the jetty/netty stuff out of avro-ipc into 
implementation specific avro-ipc-jetty and avro-ipc-netty modules.   Thus, the 
stuff remaining in avro-ipc is more "generic" and doesn't rely on either of the 
implementations.

To avoid the "split package" issue, I had to move them to separate 
packages.   That's an incompatibility, but hopefully not major.However, I 
updated the Ipc.java to (reflectively) create the appropriate server that it 
can find.   I'm slowly updating the rest of the projects to use 
Ipc.createServer instead of "new HttpServer" or "new NettyServer" which then 
allows selection of the impl based on which dependency is found.   

Anyway almost all the tests are duplicated in all three modules now (that 
needs to be cleaned up) and I'm still working on downstream modules to flip to 
using the Ipc.createServer stuff, but I wanted to start a discussion before 
going too far with it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dkulp/avro AVRO-2106

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/259.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #259


commit 6123bc0242a831af1d8fe878592b6e97eb9c2b39
Author: Daniel Kulp 
Date:   2017-11-17T16:59:25Z

[AVRO-2106] Start splitting jetty/netty out of avro-ipc




> Revisit dependencies on Jetty, servlet-api, and Netty
> -
>
> Key: AVRO-2106
> URL: https://issues.apache.org/jira/browse/AVRO-2106
> Project: Avro
>  Issue Type: Improvement
>  Components: java
>Affects Versions: 1.7.2, 1.8.0
>Reporter: Nandor Kollar
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be 
> problematic if using Avro in a webapp environment. Would it be possible to 
> make this dependency either optional or provided? Or maybe Avro modularize 
> into sub-modules in such a way that desired features can be assembled 
> piecemeal?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)