[
https://issues.apache.org/jira/browse/BAHIR-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368956#comment-15368956
]
Christian Kadner commented on BAHIR-23:
---------------------------------------
In addition Scala test sources should be included
{{<includeTestSourceDirectory>true</includeTestSourceDirectory>}} since the
examples are being build as test sources
{code:xml}
<plugin>
...
<artifactId>scalastyle-maven-plugin</artifactId>
...
<configuration>
...
<includeTestSourceDirectory>false</includeTestSourceDirectory>
...
<sourceDirectory>${basedir}/src/main/scala</sourceDirectory>
<testSourceDirectories>${basedir}/src/test/scala,${basedir}/examples/src/main/scala</testSourceDirectories>
...
</configuration>
{code}
> Build should fail on Checkstyle violation
> -----------------------------------------
>
> Key: BAHIR-23
> URL: https://issues.apache.org/jira/browse/BAHIR-23
> Project: Bahir
> Issue Type: Bug
> Components: Build
> Affects Versions: 2.0.0
> Reporter: Christian Kadner
> Assignee: Christian Kadner
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Currently the maven build will fail for code style violations in Scala files
> but the build will succeed regardless of code style violations in Java files.
> {code:xml}
> <plugin>
> ...
> <artifactId>scalastyle-maven-plugin</artifactId>
> ...
> <configuration>
> ...
> <failOnViolation>true</failOnViolation>
> ...
> </configuration>
> ...
> </plugin>
> <plugin>
> ...
> <artifactId>maven-checkstyle-plugin</artifactId>
> ...
> <configuration>
> ...
> <failOnViolation>false</failOnViolation>
> ...
> </configuration>
> ...
> </plugin>
> {code}
> As a consequence potential problems in the Java code may not get noticed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
