Build failed in Jenkins: beam_SeedJob #916

See Changes: [lcwik] [BEAM-3502] Remove usage of proto.Builder.clone() in DatastoreIO (#4449) -- Started by timer [EnvInject] - Loading node environment variables. Building

Re: [SQL] Windowing and triggering changes proposal

I'm late to the party as usual, but also added some comments. Overall supportive of this work. Thanks for the clear analysis, Anton. On Tue, Jan 16, 2018 at 10:58 AM Mingmin Xu wrote: > Thanks @Anton for the proposal. Window(w/ trigger) support in SQL is > limited now,

Re: IO configuration and @AutoValue future

So your saying that this configuration storage is something that will not be part of Apache Beam and that backwards compatibility is not being changed then this sounds fine to me. On Fri, Jan 19, 2018 at 9:51 AM, Jean-Baptiste Onofré wrote: > Hi Luke, > > I don't think we

Re: IO configuration and @AutoValue future

Hi Luke, I don't think we have a huge drawback here. The byte code will contain additional information for methods parameters. The only impact is for third parties using Beam by reflection (which is rare, only the project build on top of Beam might be impacted). Regards JB On 01/19/2018

Re: IO configuration and @AutoValue future

@Lukasz: not really since if the parameters changes then the new version will get the new data so this is not a constraint on beam but on the configuration storage which must handle anyway versions compatibility somehow so not a big deal IMHO. Romain Manni-Bucau @rmannibucau

Re: IO configuration and @AutoValue future

Note that using the -parameters flag in javac will require that we never change parameter names inside methods increasing the backwards compatibility burden. On Thu, Jan 18, 2018 at 12:33 AM, Jean-Baptiste Onofré wrote: > Great idea ! > > It sounds good to me. > > Regards >