Re: Links to Java API docs in Beam Website documentation (Was: Version Beam Website Documentation)

2019-12-11 Thread jincheng sun
+1 for using {{site.release_latest}}, which is make more sense to me. Best, Jincheng Kenneth Knowles 于2019年12月11日周三 下午1:12写道: > +1 to site.release_latest > > We do have a dead link checker in the website tests. Does it not catch > moved classes, etc? > > On Tue, Dec 10, 2019 at 1:49 PM Pablo

December board report

2019-12-11 Thread Kenneth Knowles
Hi all, Late notice on this, but the December Board report is due "now". I've started a draft here: https://docs.google.com/document/d/1AJT5j-qRLJPeN5x6nbHD5KqadXLM0zT0Ugmiy_vQ7C8/edit?usp=sharing I included

Re: [PROPOSAL] Revised streaming extensions for Beam SQL

2019-12-11 Thread jincheng sun
Thanks for bring up this discussion Kenn! Definitely +1 for the proposal. I have left some questions in the documentation :) Best, Jincheng Rui Wang 于2019年12月11日周三 上午5:23写道: > Until now as I am not seeing more people are commenting on this proposal, > can we consider this proposal is already

Re: Executing the runner validation tests for the Twister2 runner

2019-12-11 Thread Kenneth Knowles
I dug in to Twister2 a little bit to understand the question better, checking how the various resource managers / launchers are plumbed. How would a user set up automated monitoring for a job? If that is scraping the logs, then it seems unfortunate for users, but I think the Beam runner would

Re: Contributor Permission for BEAM-8953

2019-12-11 Thread Pablo Estrada
Hi Ryan! Welcome! I've added you as contributor, and assigned BEAM-8953 to you. Best -P. On Wed, Dec 11, 2019 at 3:31 PM Ryan Berti wrote: > Hello, > > My name is Ryan Berti, working at Quibi. We're using Beam via SCIO, and > I've run into a situation where I'd like to contribute some minor >

Contributor Permission for BEAM-8953

2019-12-11 Thread Ryan Berti
Hello, My name is Ryan Berti, working at Quibi. We're using Beam via SCIO, and I've run into a situation where I'd like to contribute some minor improvements to the java sdk, specifically to ParquetIO. I've created BEAM-8953 and would like some feedback on the improvement. My JIRA user name is

Re: Cython unit test suites running without Cythonized sources

2019-12-11 Thread Chad Dombrova
> > IIUC, isolated_build=True and the removal of setup.py invocation in the > current virtualenv should eliminate any Cython output files in the repo, > and no need for run_tox_cleanup.sh? > Correct, that script is deleted in this commit:

Re: Cython unit test suites running without Cythonized sources

2019-12-11 Thread Udi Meiri
The `changedir = {envsitepackagesdir}` setting is definitely something I haven't thought of. It solves the shadowing issue without needing to split tests and packages from one another. (though I still think it's unnecessary to include tests in the published package) IIUC, isolated_build=True and

Executing the runner validation tests for the Twister2 runner

2019-12-11 Thread Pulasthi Supun Wickramasinghe
Hi Dev's I have been making some progress on the Twister2 runner for the beam that I mentioned before on the mailing list. The runner is able to run the wordcount example and produce correct results. So I am currently trying to run the runner validation tests. >From what I understood looking at

Re: RFC: python static typing PR

2019-12-11 Thread Chad Dombrova
Hi all, Robert has diligently reviewed the first batch of changes for this PR, and all review notes are addressed and tests are passing: https://github.com/apache/beam/pull/9915 Due to the number of file touched there's a short window of about one or two days before a merge conflict arrives on

Re: Cython unit test suites running without Cythonized sources

2019-12-11 Thread Chad Dombrova
Hi Udi, > Sorry I didn't realize you already had a solution for the shadowing issue > and BEAM-8572. > No worries at all. I haven't had much time to invest into that PR lately (most of it I did at home on my own time), but I did get past most of the major issues. You've been working on so many

Re: Is org.apache.beam.sdk.transforms.FlattenTest.testFlattenMultipleCoders supposed to be supported ?

2019-12-11 Thread Etienne Chauchot
Ok, Thanks Kenn. Le Flatten javadoc says that by default the coder of the output should be the coder of the first input. But in the test, it sets the output coder to something different. Waiting for a consensus on this model point and a common impl in the runners, I'll just exclude this test