Re: Can we solve WindowFn.getOutputTime another way?

2021-02-11 Thread Robert Bradshaw
On Wed, Feb 10, 2021 at 8:03 PM Kenneth Knowles wrote: > > > On Wed, Feb 10, 2021 at 2:24 PM Alex Amato wrote: > >> >> >> On Wed, Feb 10, 2021 at 12:14 PM Kenneth Knowles wrote: >> >>> On a PR (https://github.com/apache/beam/pull/13927) we got into a >>> discussion of a very old and strange

Re: Do we need synchronized processing time? / What to do about "continuation triggers"?

2021-02-11 Thread Robert Bradshaw
Of course the right answer is to just implement sink triggers and sidestep the question altogether :). In the meantime, I think leaving AfterSynchronizedProcessingTime in the model makes the most sense, and runners can choose an implementation between firing eagerly and waiting some amount of

Pull Request Review / Feature Feedback for KafkaIO

2021-02-11 Thread Rion Williams
Hi all, Recently, I encountered a bit of functionality for a pipeline that I was working that seemed to be slightly lacking (specifically the recognition of explicitly defined partitioning in the KafkaIO.WriteRecords transform) so I put together a JIRA related to it [1] as well as a more detailed

Re: [Proposal] Requesting PMC approval to start planning for Beam Summits 2021

2021-02-11 Thread Brittany Hermann
Nothing substantial. Only change is going from a half day, five day event to a 3 day full day event. On Thu, Feb 11, 2021 at 7:24 PM Robert Bradshaw wrote: > Are there any substantive changes from what we did last year? > > On Thu, Feb 11, 2021 at 1:40 PM Brittany Hermann > wrote: > >> Dear

Re: [Proposal] Requesting PMC approval to start planning for Beam Summits 2021

2021-02-11 Thread Robert Bradshaw
Are there any substantive changes from what we did last year? On Thu, Feb 11, 2021 at 1:40 PM Brittany Hermann wrote: > Dear Project Management Committee, > > The Beam Summit is a community event funded by a group of sponsors and > organized by a steering committee formed by members of the Beam

[Proposal] Requesting PMC approval to start planning for Beam Summits 2021

2021-02-11 Thread Brittany Hermann
Dear Project Management Committee, The Beam Summit is a community event funded by a group of sponsors and organized by a steering committee formed by members of the Beam community and who have participated in past editions. I'd like to get the following approvals: -To organize and host the

Re: [PROPOSAL] Preparing for Beam 2.28.0 release

2021-02-11 Thread Nir Gazit
Sure! Thanks! https://github.com/apache/beam/pull/13965 On Thu, Feb 11, 2021 at 7:53 PM Chamikara Jayalath wrote: > Yeah, this seems like a critical fix. Please send a cherry-pick. Also > please make sure that this did not break any post-commits after being > merged. > > Thanks, > Cham > > On

Re: [PROPOSAL] Preparing for Beam 2.28.0 release

2021-02-11 Thread Chamikara Jayalath
Yeah, this seems like a critical fix. Please send a cherry-pick. Also please make sure that this did not break any post-commits after being merged. Thanks, Cham On Thu, Feb 11, 2021 at 9:40 AM Nir Gazit wrote: > Hey, > I hope it's not too late but is it possible to Cherry-pick this PR as well:

Re: [PROPOSAL] Preparing for Beam 2.28.0 release

2021-02-11 Thread Nir Gazit
Hey, I hope it's not too late but is it possible to Cherry-pick this PR as well: https://github.com/apache/beam/pull/13723 It fixes a critical bug that currently prevents the use of S3IO (and probably other IOs) on the Python SDK. Thanks Nir On