Re: Review request for 2 Python BigQuery IO related PRs

2021-03-03 Thread Pablo Estrada
Thanks! Yes, I'll take a look! On Wed, Mar 3, 2021 at 1:19 PM Ahmet Altay wrote: > +Pablo Estrada > > On Wed, Mar 3, 2021 at 1:08 PM Chuck Yang > wrote: > >> Hi Beam devs, >> >> Could I have reviews on the following two PRs? >> >> * [BEAM-11884] Pass destination as str rather than

Re: Review request for 2 Python BigQuery IO related PRs

2021-03-03 Thread Ahmet Altay
+Pablo Estrada On Wed, Mar 3, 2021 at 1:08 PM Chuck Yang wrote: > Hi Beam devs, > > Could I have reviews on the following two PRs? > > * [BEAM-11884] Pass destination as str rather than TableReference > within BigQueryBatchFileLoads #14112 [1] > * [BEAM-11277] Respect schemaUpdateOptions

Review request for 2 Python BigQuery IO related PRs

2021-03-03 Thread Chuck Yang
Hi Beam devs, Could I have reviews on the following two PRs? * [BEAM-11884] Pass destination as str rather than TableReference within BigQueryBatchFileLoads #14112 [1] * [BEAM-11277] Respect schemaUpdateOptions during BigQuery load with temporary tables #14113 [2] The first PR fixes a bug I

Re: [PROPOSAL] Preparing for Beam 2.29.0 release

2021-03-03 Thread Ahmet Altay
+1 and thank you! On Wed, Mar 3, 2021 at 11:51 AM Kenneth Knowles wrote: > Hi All, > > Beam 2.29.0 release is scheduled to be cut in a week, on March 10 > according to the release calendar [1]. > > I'd like to volunteer myself to be the release manager for this release. > I plan on cutting the

[PROPOSAL] Preparing for Beam 2.29.0 release

2021-03-03 Thread Kenneth Knowles
Hi All, Beam 2.29.0 release is scheduled to be cut in a week, on March 10 according to the release calendar [1]. I'd like to volunteer myself to be the release manager for this release. I plan on cutting the release branch on the scheduled date. Any comments or objections? Kenn [1]

Re: Random outputs for ARRAY_CONCAT_AGG fn zetasql

2021-03-03 Thread Kyle Weaver
You will be able to access the actual value inside the function you pass to satisfies. I just meant that you will have to go through a function call. On Wed, Mar 3, 2021 at 1:58 AM Sonam Ramchand < sonam.ramch...@venturedive.com> wrote: > Yeah, that sounds right. But the only thing that confuses

Re: Random outputs for ARRAY_CONCAT_AGG fn zetasql

2021-03-03 Thread Sonam Ramchand
Yeah, that sounds right. But the only thing that confuses me is: PAssert.that(stream).satisfies(row -> assertThat("array_agg_concat_field", actual , containsInAnyOrder(Arrays.asList(1L,2L,3L,4L,5L,6L; How come I can access *actual* here when output is not materialized. On Tue, Mar