Re: Null checking in Beam

2021-03-15 Thread Kenneth Knowles
I will be blunt about my opinions about the general issue: - NullPointerExceptions (and similar) are a solved problem. * They have been since 2003 at the latest [1] (this is when the types were hacked into Java - the foundation dates back to the 70s or earlier) * Checkerframework is a

Re: [PROPOSAL] Preparing for Beam 2.29.0 release

2021-03-15 Thread Kenneth Knowles
Update: There are 8 issues tagged to 2.29.0 release: https://issues.apache.org/jira/issues/?jql=statusCategory%20!%3D%20done%20AND%20project%20%3D%2012319527%20AND%20fixVersion%20%3D%2012349629%20ORDER%20BY%20priority%20DESC%2C%20key%20ASC There are 22 issues in Needs Triage state with priority

Re: Null checking in Beam

2021-03-15 Thread Reuven Lax
I have some deeper concerns with the null checks. The fact that many libraries we use (including guava) don't always annotate their methods forces a lot of workarounds. As a very simple example, the return value from Preconditions.checkNotNull clearly can never be null, yet the nullability checks

Re: Null checking in Beam

2021-03-15 Thread Jan Lukavský
Yes, annotations that we add to the code base on purpose (like @Nullable or @SuppressWarnings) are aboslutely fine. What is worse is that the checked is not only checked, but a code generator. :) For example when one wants to implement Coder by extending CustomCoder and use auto-generating

Optimize your data pipelines with Apache Beam

2021-03-15 Thread Mara Ruvalcaba
** *Optimize your data pipelines with Apache Beam* * Hi Beam Community, The demand for people with data analytics skills is growing. Partnered with Google Cloud and the Apache Beam Open Source community, Beam College provides free training to help supercharge your data processing skills

Re: Null checking in Beam

2021-03-15 Thread Ismaël Mejía
+1 Even if I like the strictness for Null checking, I also think that this is adding too much extra time for builds (that I noticed locally when enabled) and also I agree with Jan that the annotations are really an undesired side effect. For reference when you try to auto complete some method

Re: Contributor permission for jira tickets

2021-03-15 Thread Kezhu Wang
Hi Pablo, Yeh, it is me. Sorry for missing jira username. Thanks! Best, Kezhu Wang On March 16, 2021 at 01:34:02, Pablo Estrada (pabl...@google.com) wrote: Hi! I've added the user 'kezhuw' as contributor. I hope that's you? : ) Welcome! -P. On Mon, Mar 15, 2021 at 10:30 AM Kezhu Wang wrote:

Re: Contributor permission for jira tickets

2021-03-15 Thread Pablo Estrada
Hi! I've added the user 'kezhuw' as contributor. I hope that's you? : ) Welcome! -P. On Mon, Mar 15, 2021 at 10:30 AM Kezhu Wang wrote: > Hi devs, > > I am interesting in Beam. I think I could make some contributions in > diving into Beam. Could you give me permission for jira tickets ? Thanks!

Contributor permission for jira tickets

2021-03-15 Thread Kezhu Wang
Hi devs, I am interesting in Beam. I think I could make some contributions in diving into Beam. Could you give me permission for jira tickets ? Thanks! Best, Kezhu Wang

Re: Please help triage issues!

2021-03-15 Thread Tyson Hamilton
There is a 'Triaged' button that I click: https://photos.app.goo.gl/Ub5Qwnpp6aFrmaDZ9 On Mon, Mar 15, 2021 at 9:48 AM Alex Amato wrote: > (Do I need certain permissions to be able to do this?) > > On Mon, Mar 15, 2021 at 9:47 AM Alex Amato wrote: > >> Would you mind posting a screenshot of

Re: Null checking in Beam

2021-03-15 Thread Kyle Weaver
> > Big +1 for moving this to separate CI job. I really don't like what > annotations are currently added to the code we ship. Tools like Idea add > these annotations to code they generate when overriding classes and that's > very annoying. Users should not be exposed to internal tools like >

Re: Please help triage issues!

2021-03-15 Thread Alex Amato
(Do I need certain permissions to be able to do this?) On Mon, Mar 15, 2021 at 9:47 AM Alex Amato wrote: > Would you mind posting a screenshot of exactly where you are supposed to > click to move a jira issue to "Open" status? I honestly can't find where to > click. I don't see the option in

Re: Please help triage issues!

2021-03-15 Thread Alex Amato
Would you mind posting a screenshot of exactly where you are supposed to click to move a jira issue to "Open" status? I honestly can't find where to click. I don't see the option in the edit dialog box On Sun, Mar 14, 2021 at 8:03 PM Kenneth Knowles wrote: > No need for feeling any guilt :-) >

Upgrading vendored gRPC from 1.26.0 to 1.36.0

2021-03-15 Thread Tomo Suzuki
Hi Beam developers, I'm working on upgrading the vendored gRPC 1.36.0 https://issues.apache.org/jira/browse/BEAM-11227 (PR: https://github.com/apache/beam/pull/14028) Let me know if you have any questions or concerns. Background: Exchanged messages with Ismaël in BEAM-11227, it seems that it the

Re: Beam Website Feedback

2021-03-15 Thread Brian Hulette
Hm thanks for pointing this out Brian. It looks like the Java WindowedWordCount example does process an input file while the Java one processes a PubSub topic. Changing the command would be a good quick fix, but I think the best fix would actually be to make the python example mirror the Java one.

Beam Dependency Check Report (2021-03-15)

2021-03-15 Thread Apache Jenkins Server
High Priority Dependency Updates Of Beam Python SDK: Dependency Name Current Version Latest Version Release Date Of the Current Used Version Release Date Of The Latest Release JIRA Issue chromedriver-binary 88.0.4324.96.0

Re: Null checking in Beam

2021-03-15 Thread Jan Lukavský
Big +1 for moving this to separate CI job. I really don't like what annotations are currently added to the code we ship. Tools like Idea add these annotations to code they generate when overriding classes and that's very annoying. Users should not be exposed to internal tools like nullability

Re: [DISCUSS] Drop support for Flink 1.8 and 1.9

2021-03-15 Thread Etienne Chauchot
Hi, +1 on drop Etienne On 12/03/2021 20:39, Ismaël Mejía wrote: Do we now support 1.8 through 1.12? Yes and that's clearly too much given that the Flink community only support the two latest release. It also hits us because we run tests for all those versions on precommit. On Fri, Mar 12,