Re: PR 17274 - beam on non lts jvm

2022-07-15 Thread Clément Guillaume
Hey all, any chance I could get a review? Le mar. 28 juin 2022, 16:25, Clément Guillaume a écrit : > Hi all > > Could I get a review on https://github.com/apache/beam/pull/17274 > it's about running the direct runner or the "java client" on non lts jvm > > Thank you. >

Re: Disabling Kafka IO SDF implementation

2022-07-15 Thread Chamikara Jayalath via dev
Thanks John. +1 for disabling SDF Kafka till we are confident about it. As John mentioned, we already have the ability to wrap UnboundedSource based Kafka with SDF so this should not break Kafka support for existing runners that require SDF. - Cham On Fri, Jul 15, 2022 at 11:10 AM John Casey wr

Disabling Kafka IO SDF implementation

2022-07-15 Thread John Casey via dev
Hi All, There is an issue right now where Kafka IO's SDF implementation isn't resuming properly when the pipeline restarts https://github.com/apache/beam/issues/21730. In addition, there was an issue where Kafka SDF wasn't committing properly when 'commit in finalize' was specified, and I believe

Re: Trigger phrases in Github Actions

2022-07-15 Thread Jarek Potiuk
Sure :). I think it's really up to you to decide. There are pros/cons of both - it was just my view from experience of running "master" workflows for a while to do stuff like that (we had "labelling" of the PRs on "approve" action). But everyone's mileage is different One con that I did not mentio

Re: Trigger phrases in Github Actions

2022-07-15 Thread Danny McCormick via dev
I tend to disagree with this approach. I think I can generally distill what you said to 3 points, which I'll address below: 1. Every workflow needs a clean worker, and Apache has a limited number of those. As a result, queue times can build up. This is a problem, but it's one that should be resol

Beam High Priority Issue Report

2022-07-15 Thread beamactions
This is your daily summary of Beam's current high priority issues that may need attention. See https://beam.apache.org/contribute/issue-priorities for the meaning and expectations around issue priorities. Unassigned P1 Issues: https://github.com/apache/beam/issues/22287 [Task]: Support new

Re: Trigger phrases in Github Actions

2022-07-15 Thread Jarek Potiuk
My 3 cents. We've been playing with similar approaches in Apache Airflow and I think Github Actions Workflows are not a good idea for this kind of behaviour. Github Action workflows are really "heavy-weight" in many ways, you should really think of them to be spinned to actually do some processing